3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-25 22:30:49 +08:00
Code Issues Projects Releases Wiki Activity

Switch from ALIGNAS() to alignas().

Browse Source 
There is no longer a need to use this macro; compilers have no problem
with `alignas()` nowadays.

Subsequent CLs will remove the macro entirely once it's unused in both
Crashpad and Chromium.

Bug: none
Change-Id: I94675f3f674f9bc32a213e972a017980dcd1c014
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5805982
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Peter Kasting 2024-08-21 17:39:26 -07:00 committed by Mark Mentovai
parent 6265674c98
commit adb22c8169
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
minidump/minidump_extensions.h
View File

@ -116,7 +116,7 @@ enum MinidumpStreamType : uint32_t {
//! file. //! file.
//! //!
//! \sa MINIDUMP_STRING //! \sa MINIDUMP_STRING
struct ALIGNAS(4) PACKED MinidumpUTF8String { struct alignas(4) PACKED MinidumpUTF8String {
// The field names do not conform to typical style, they match the names used // The field names do not conform to typical style, they match the names used
// in MINIDUMP_STRING. This makes it easier to operate on MINIDUMP_STRING (for // in MINIDUMP_STRING. This makes it easier to operate on MINIDUMP_STRING (for
// UTF-16 strings) and MinidumpUTF8String using templates. // UTF-16 strings) and MinidumpUTF8String using templates.
@ -135,7 +135,7 @@ struct ALIGNAS(4) PACKED MinidumpUTF8String {
//! \brief A variable-length array of bytes carried within a minidump file. //! \brief A variable-length array of bytes carried within a minidump file.
//! The data have no intrinsic type and should be interpreted according //! The data have no intrinsic type and should be interpreted according
//! to their referencing context. //! to their referencing context.
struct ALIGNAS(4) PACKED MinidumpByteArray { struct alignas(4) PACKED MinidumpByteArray {
//! \brief The length of the #data field. //! \brief The length of the #data field.
uint32_t length; uint32_t length;
@ -273,7 +273,7 @@ enum MinidumpOS : uint32_t {
}; };
//! \brief A list of ::RVA pointers. //! \brief A list of ::RVA pointers.
struct ALIGNAS(4) PACKED MinidumpRVAList { struct alignas(4) PACKED MinidumpRVAList {
//! \brief The number of children present in the #children array. //! \brief The number of children present in the #children array.
uint32_t count; uint32_t count;
@ -282,7 +282,7 @@ struct ALIGNAS(4) PACKED MinidumpRVAList {
}; };
//! \brief A key-value pair. //! \brief A key-value pair.
struct ALIGNAS(4) PACKED MinidumpSimpleStringDictionaryEntry { struct alignas(4) PACKED MinidumpSimpleStringDictionaryEntry {
//! \brief ::RVA of a MinidumpUTF8String containing the key of a key-value //! \brief ::RVA of a MinidumpUTF8String containing the key of a key-value
//! pair. //! pair.
RVA key; RVA key;
@ -293,7 +293,7 @@ struct ALIGNAS(4) PACKED MinidumpSimpleStringDictionaryEntry {
}; };
//! \brief A list of key-value pairs. //! \brief A list of key-value pairs.
struct ALIGNAS(4) PACKED MinidumpSimpleStringDictionary { struct alignas(4) PACKED MinidumpSimpleStringDictionary {
//! \brief The number of key-value pairs present. //! \brief The number of key-value pairs present.
uint32_t count; uint32_t count;
@ -302,7 +302,7 @@ struct ALIGNAS(4) PACKED MinidumpSimpleStringDictionary {
}; };
//! \brief A typed annotation object. //! \brief A typed annotation object.
struct ALIGNAS(4) PACKED MinidumpAnnotation { struct alignas(4) PACKED MinidumpAnnotation {
//! \brief ::RVA of a MinidumpUTF8String containing the name of the //! \brief ::RVA of a MinidumpUTF8String containing the name of the
//! annotation. //! annotation.
RVA name; RVA name;
@ -319,7 +319,7 @@ struct ALIGNAS(4) PACKED MinidumpAnnotation {
}; };
//! \brief A list of annotation objects. //! \brief A list of annotation objects.
struct ALIGNAS(4) PACKED MinidumpAnnotationList { struct alignas(4) PACKED MinidumpAnnotationList {
//! \brief The number of annotation objects present. //! \brief The number of annotation objects present.
uint32_t count; uint32_t count;
@ -342,7 +342,7 @@ struct ALIGNAS(4) PACKED MinidumpAnnotationList {
//! fields are valid or not. //! fields are valid or not.
//! //!
//! \sa MinidumpModuleCrashpadInfoList //! \sa MinidumpModuleCrashpadInfoList
struct ALIGNAS(4) PACKED MinidumpModuleCrashpadInfo { struct alignas(4) PACKED MinidumpModuleCrashpadInfo {
//! \brief The structure’s currently-defined version number. //! \brief The structure’s currently-defined version number.
//! //!
//! \sa version //! \sa version
@ -392,7 +392,7 @@ struct ALIGNAS(4) PACKED MinidumpModuleCrashpadInfo {
//! \brief A link between a MINIDUMP_MODULE structure and additional //! \brief A link between a MINIDUMP_MODULE structure and additional
//! Crashpad-specific information about a module carried within a minidump //! Crashpad-specific information about a module carried within a minidump
//! file. //! file.
struct ALIGNAS(4) PACKED MinidumpModuleCrashpadInfoLink { struct alignas(4) PACKED MinidumpModuleCrashpadInfoLink {
//! \brief A link to a MINIDUMP_MODULE structure in the module list stream. //! \brief A link to a MINIDUMP_MODULE structure in the module list stream.
//! //!
//! This field is an index into MINIDUMP_MODULE_LIST::Modules. This field’s //! This field is an index into MINIDUMP_MODULE_LIST::Modules. This field’s
@ -419,7 +419,7 @@ struct ALIGNAS(4) PACKED MinidumpModuleCrashpadInfoLink {
//! structure carried within the minidump file will necessarily have //! structure carried within the minidump file will necessarily have
//! Crashpad-specific information provided by a MinidumpModuleCrashpadInfo //! Crashpad-specific information provided by a MinidumpModuleCrashpadInfo
//! structure. //! structure.
struct ALIGNAS(4) PACKED MinidumpModuleCrashpadInfoList { struct alignas(4) PACKED MinidumpModuleCrashpadInfoList {
//! \brief The number of children present in the #modules array. //! \brief The number of children present in the #modules array.
uint32_t count; uint32_t count;
@ -438,7 +438,7 @@ struct ALIGNAS(4) PACKED MinidumpModuleCrashpadInfoList {
//! structure. Revise #kVersion and document each field’s validity based on //! structure. Revise #kVersion and document each field’s validity based on
//! #version, so that newer parsers will be able to determine whether the added //! #version, so that newer parsers will be able to determine whether the added
//! fields are valid or not. //! fields are valid or not.
struct ALIGNAS(4) PACKED MinidumpCrashpadInfo { struct alignas(4) PACKED MinidumpCrashpadInfo {
// UUID has a constructor, which makes it non-POD, which makes this structure // UUID has a constructor, which makes it non-POD, which makes this structure
// non-POD. In order for the default constructor to zero-initialize other // non-POD. In order for the default constructor to zero-initialize other
// members, an explicit constructor must be provided. // members, an explicit constructor must be provided.