3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

DCHECK_IS_ON needs ()

Browse Source 
Found in the course of reintroducing this bug elsewhere

R=danakj@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/1287043005 .

Patch from Nick Carter <nick@chromium.org>.
This commit is contained in:
Nick Carter 2015-08-12 20:47:36 -04:00 committed by Mark Mentovai
parent eb7ca8c374
commit ad09fd1bc8
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/simple_string_dictionary_test.cc
View File

@ -276,7 +276,7 @@ TEST(SimpleStringDictionary, OutOfSpace) {
EXPECT_FALSE(map.GetValueForKey("c")); EXPECT_FALSE(map.GetValueForKey("c"));
} }
#if DCHECK_IS_ON #if DCHECK_IS_ON()
TEST(SimpleStringDictionaryDeathTest, NullKey) { TEST(SimpleStringDictionaryDeathTest, NullKey) {
TSimpleStringDictionary<4, 6, 6> map; TSimpleStringDictionary<4, 6, 6> map;

2
util/misc/initialization_state_dcheck.cc
View File

@ -16,7 +16,7 @@
namespace crashpad { namespace crashpad {
#if DCHECK_IS_ON #if DCHECK_IS_ON()
InitializationStateDcheck::State InitializationStateDcheck::SetInitializing() { InitializationStateDcheck::State InitializationStateDcheck::SetInitializing() {
State old_state = state(); State old_state = state();

4
util/misc/initialization_state_dcheck.h
View File

@ -25,7 +25,7 @@
namespace crashpad { namespace crashpad {
#if DCHECK_IS_ON || DOXYGEN #if DCHECK_IS_ON() || DOXYGEN
//! \brief Tracks whether data are initialized, triggering a DCHECK assertion //! \brief Tracks whether data are initialized, triggering a DCHECK assertion
//! on an invalid data access. //! on an invalid data access.
@ -168,7 +168,7 @@ struct InitializationStateDcheck {
// technically invalid according to the standard, but clang and g++ accept them // technically invalid according to the standard, but clang and g++ accept them
// without complaint even with warnings turned up. They take up no space at all, // without complaint even with warnings turned up. They take up no space at all,
// and they can be “initialized” with the same () syntax used to initialize // and they can be “initialized” with the same () syntax used to initialize
// objects of the DCHECK_IS_ON InitializationStateDcheck class above. // objects of the DCHECK_IS_ON() InitializationStateDcheck class above.
using InitializationStateDcheck = bool[0]; using InitializationStateDcheck = bool[0];
#endif // COMPILER_MSVC #endif // COMPILER_MSVC

2
util/misc/initialization_state_dcheck_test.cc
View File

@ -29,7 +29,7 @@ TEST(InitializationStateDcheck, InitializationStateDcheck) {
INITIALIZATION_STATE_DCHECK_VALID(initialization_state_dcheck); INITIALIZATION_STATE_DCHECK_VALID(initialization_state_dcheck);
} }
#if DCHECK_IS_ON #if DCHECK_IS_ON()
// InitializationStateDcheck only DCHECKs, so the death tests can only run // InitializationStateDcheck only DCHECKs, so the death tests can only run
// when DCHECKs are enabled. // when DCHECKs are enabled.