From a8ad3bdbdfb118775b44f69909bd0609c29d8c23 Mon Sep 17 00:00:00 2001 From: Joshua Peraza Date: Fri, 9 Feb 2018 11:44:48 -0800 Subject: [PATCH] linux: fix incorrect fallthrough Previously, an error would have been logged twice. Bug: crashpad:30 Change-Id: I9445c022550ad14497186c6878863fbf72d8cd59 Reviewed-on: https://chromium-review.googlesource.com/911822 Reviewed-by: Mark Mentovai Commit-Queue: Joshua Peraza --- util/linux/ptracer.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/util/linux/ptracer.cc b/util/linux/ptracer.cc index 20115819..84447362 100644 --- a/util/linux/ptracer.cc +++ b/util/linux/ptracer.cc @@ -285,9 +285,9 @@ size_t GetGeneralPurposeRegistersAndLength(pid_t tid, switch (errno) { #if defined(ARCH_CPU_ARMEL) case EIO: - if (GetGeneralPurposeRegistersLegacy(tid, context, can_log)) { - return sizeof(context->t32); - } + return GetGeneralPurposeRegistersLegacy(tid, context, can_log) + ? sizeof(context->t32) + : 0; #endif // ARCH_CPU_ARMEL default: PLOG_IF(ERROR, can_log) << "ptrace";