3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-19 18:03:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don’t const_cast<char*> the service name parameter to

Browse Source 
bootstrap_look_up().

This hasn’t been required since the 10.5 SDK, which is no longer
supported.

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/999533002
This commit is contained in:
Mark Mentovai 2015-03-10 17:01:12 -04:00
parent 42db629ee3
commit a829f67f81
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/mac/exception_port_tool.cc
View File

@ -186,7 +186,7 @@ void ShowBootstrapService(const std::string& service_name,
MachSendRightPool* mach_send_right_pool) { MachSendRightPool* mach_send_right_pool) {
mach_port_t service_port; mach_port_t service_port;
kern_return_t kr = bootstrap_look_up( kern_return_t kr = bootstrap_look_up(
bootstrap_port, const_cast<char*>(service_name.c_str()), &service_port); bootstrap_port, service_name.c_str(), &service_port);
if (kr != BOOTSTRAP_SUCCESS) { if (kr != BOOTSTRAP_SUCCESS) {
BOOTSTRAP_LOG(ERROR, kr) << "bootstrap_look_up " << service_name; BOOTSTRAP_LOG(ERROR, kr) << "bootstrap_look_up " << service_name;
return; return;
@ -287,8 +287,7 @@ bool SetExceptionPort(const ExceptionHandlerDescription* description,
0, strlen(kHandlerBootstrapColon), kHandlerBootstrapColon) == 0) { 0, strlen(kHandlerBootstrapColon), kHandlerBootstrapColon) == 0) {
const char* service_name = const char* service_name =
description->handler.c_str() + strlen(kHandlerBootstrapColon); description->handler.c_str() + strlen(kHandlerBootstrapColon);
kr = bootstrap_look_up( kr = bootstrap_look_up(bootstrap_port, service_name, &service_port);
bootstrap_port, const_cast<char*>(service_name), &service_port);
if (kr != BOOTSTRAP_SUCCESS) { if (kr != BOOTSTRAP_SUCCESS) {
BOOTSTRAP_LOG(ERROR, kr) << "bootstrap_look_up " << service_name; BOOTSTRAP_LOG(ERROR, kr) << "bootstrap_look_up " << service_name;
return false; return false;