From 9ca1fb932e5e3590ca7ae93d2f5aa0a68dd01974 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Liz=C3=A9?= Date: Thu, 10 Nov 2022 19:01:53 +0100 Subject: [PATCH] [tests] MINSIGSTKSZ is no longer a constant, update tests glibc 2.34 makes MINSIGSTKSZ a runtime value, as noted in the changelog: https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=85e84fe53699fe9e392edffa993612ce08b2954a;hb=HEAD. This prevents tests from building on these systems, remove constexpr to fix it. Change-Id: I83b19aa7c075f0d9b02875aef8985fac6fce18a5 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4020320 Reviewed-by: Mark Mentovai Commit-Queue: Benoit Lize --- client/crashpad_client_linux_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/crashpad_client_linux_test.cc b/client/crashpad_client_linux_test.cc index 3e0b3dec..813d31e6 100644 --- a/client/crashpad_client_linux_test.cc +++ b/client/crashpad_client_linux_test.cc @@ -268,7 +268,7 @@ class ScopedAltSignalStack { void Initialize() { ScopedMmap local_stack_mem; - constexpr size_t stack_size = MINSIGSTKSZ; + const size_t stack_size = MINSIGSTKSZ; ASSERT_TRUE(local_stack_mem.ResetMmap(nullptr, stack_size, PROT_READ | PROT_WRITE,