3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-26 23:01:05 +08:00
Code Issues Projects Releases Wiki Activity

elf: don't warn on trailing unread bytes in the elf dynamic array

Browse Source 
This warning triggers reliably on most binaries and on android, spams
the logcat which may obfuscate other errors.

The actual amount varies, but is typically 40 bytes for 32-bit android
system libraries, 80 bytes for 64-bit android system libraries,
64 bytes for linux system libraries (on my machine), but so far they're
all zeroes.

Change-Id: I658434e8290c75641a3b17034ebdd958834bcd69
Reviewed-on: https://chromium-review.googlesource.com/c/1269740
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
This commit is contained in:
Joshua Peraza 2018-10-08 17:43:20 -07:00 committed by Commit Bot
parent 9554a89ab6
commit 9b2a119dc6
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
snapshot/elf/elf_dynamic_array_reader.cc
View File

@ -42,9 +42,6 @@ bool Read(const ProcessMemoryRange& memory,
switch (entry.d_tag) {
case DT_NULL:
values->swap(local_values);
if (size != 0) {
LOG(WARNING) << size << " trailing bytes not read";
}
return true;
case DT_NEEDED:
// Skip these entries for now.