3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optionally stub out the libcurl-based implementation of HTTPTransport

Browse Source 
Bug: crashpad:220
Change-Id: I6556cd5a32ea95c3dc8c5906e0857c83dc88cd9a
Reviewed-on: https://chromium-review.googlesource.com/938492
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Scott Graham 2018-02-26 14:07:09 -08:00 committed by Commit Bot
parent 8a12f58930
commit 9affa2a0e7
2 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
util/BUILD.gn
View File

@ -14,6 +14,13 @@
import("../build/crashpad_buildconfig.gni")
declare_args() {
if (crashpad_is_linux) {
# Whether the libcurl-based HTTPTransport implementation should be built.
enable_http_transport_libcurl = true
}
}
if (crashpad_is_mac) {
if (crashpad_is_in_chromium) {
import("//build/config/sysroot.gni")
@ -245,7 +252,11 @@ static_library("util") {
}
if (crashpad_is_linux) {
sources += [ "net/http_transport_libcurl.cc" ]
if (enable_http_transport_libcurl) {
sources += [ "net/http_transport_libcurl.cc" ]
} else {
sources += [ "net/http_transport_none.cc" ]
}
}
if (crashpad_is_linux || crashpad_is_android) {
@ -377,7 +388,7 @@ static_library("util") {
if (crashpad_is_fuchsia) {
sources += [
"misc/paths_fuchsia.cc",
"net/http_transport_fuchsia.cc",
"net/http_transport_none.cc",
"process/process_memory_fuchsia.cc",
"process/process_memory_fuchsia.h",
]
@ -408,7 +419,7 @@ static_library("util") {
include_dirs += [ "$root_build_dir/gen" ]
}
if (crashpad_is_linux) {
if (crashpad_is_linux && enable_http_transport_libcurl) {
libs = [ "curl" ]
}
@ -478,7 +489,8 @@ source_set("util_test") {
]
}
if (!crashpad_is_android && !crashpad_is_fuchsia) {
if (!crashpad_is_android && !crashpad_is_fuchsia &&
(!crashpad_is_linux || enable_http_transport_libcurl)) {
# Android and Fuchsia will each require an HTTPTransport implementation
# (libcurl isn’t in either’s SDK) and a solution to
# http_transport_test_server.py, because Python isn’t available on either.
@ -486,8 +498,10 @@ source_set("util_test") {
# the build host with a method to forward requests from the device to the
# host.
#
# TODO(scottmg): Fuchsia will also require an implementation of
# MultiprocessExec for testing.
# Linux optionally compiles in a libcurl-based HTTPTransport, but since curl
# isn't in a base Debian sysroot (which is what Chromium builds against),
# maintain an option to exclude that, for now.
# https://crashpad.chromium.org/bug/220.
sources += [ "net/http_transport_test.cc" ]
}

0
util/net/http_transport_fuchsia.cc → util/net/http_transport_none.cc
View File