3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-13 00:41:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Increase kAllowedOffset for non-optimized build

Browse Source 
"init_stack_vars = true" inserts additional instructions which
usually removed by optimization if code does not rely on undefined
behaviour of uninitialized variables.
However in non-optimized build these instructions may still be present.

Bug: chromium:1030261
Change-Id: I85d1d0a240dcd1c29c6ff148e88d572b5dcc81d1
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1949846
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
This commit is contained in:
Vitaly Buka 2019-12-03 18:21:55 -08:00 committed by Commit Bot
parent 359fc4a133
commit 9a312ddff5
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
snapshot/win/exception_snapshot_win_test.cc
View File

@ -213,6 +213,9 @@ class SimulateDelegate : public ExceptionHandlerServer::Delegate {
// ASan instrumentation inserts more instructions between the expected
// location and what's reported. https://crbug.com/845011.
constexpr uint64_t kAllowedOffset = 500;
#elif !NDEBUG
// Debug build is likely not optimized and contains more instructions.
constexpr uint64_t kAllowedOffset = 150;
#else
constexpr uint64_t kAllowedOffset = 100;
#endif