From 94471409a183289a5f95f7b009a766761dd387cf Mon Sep 17 00:00:00 2001 From: Robert Sesek Date: Thu, 12 Mar 2015 18:51:00 -0400 Subject: [PATCH] handler/mac: Increase the upload timeout from the default 15s to 60s. R=mark@chromium.org Review URL: https://codereview.chromium.org/1008623002 --- handler/mac/crash_report_upload_thread.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/handler/mac/crash_report_upload_thread.cc b/handler/mac/crash_report_upload_thread.cc index 0e77ee73..a4e4607d 100644 --- a/handler/mac/crash_report_upload_thread.cc +++ b/handler/mac/crash_report_upload_thread.cc @@ -343,13 +343,14 @@ CrashReportUploadThread::UploadResult CrashReportUploadThread::UploadReport( report->file_path, "application/octet-stream"); - // TODO(mark): There should be a timeout option for upload. scoped_ptr http_transport(HTTPTransport::Create()); http_transport->SetURL(url_); HTTPHeaders::value_type content_type = http_multipart_builder.GetContentType(); http_transport->SetHeader(content_type.first, content_type.second); http_transport->SetBodyStream(http_multipart_builder.GetBodyStream().Pass()); + // TODO(mark): The timeout should be configurable by the client. + http_transport->SetTimeout(60.0); // 1 minute. if (!http_transport->ExecuteSynchronously(response_body)) { return UploadResult::kRetry;