Fix enum vs unsigned -Wsign-compare warnings

Recent Clang versions started taking into account that enums are signed
on Windows when emitting these warnings.

Bug: chromium:792519
Change-Id: I08767fa1f5c8211e663769c7e76b13a1b7146f4f
Reviewed-on: https://chromium-review.googlesource.com/813497
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Hans Wennborg 2017-12-06 20:32:30 -08:00 committed by Commit Bot
parent a4fc880278
commit 914b0d6755
2 changed files with 2 additions and 2 deletions

View File

@ -59,7 +59,7 @@ void MinidumpFileWriter::InitializeFromSnapshot(
DCHECK_EQ(state(), kStateMutable);
DCHECK_EQ(header_.Signature, 0u);
DCHECK_EQ(header_.TimeDateStamp, 0u);
DCHECK_EQ(header_.Flags, MiniDumpNormal);
DCHECK_EQ(static_cast<MINIDUMP_TYPE>(header_.Flags), MiniDumpNormal);
DCHECK(streams_.empty());
// This time is truncated to an integer number of seconds, not rounded, for

View File

@ -52,7 +52,7 @@ void VerifyMinidumpHeader(const MINIDUMP_HEADER* header,
ASSERT_EQ(header->StreamDirectoryRva, streams ? sizeof(MINIDUMP_HEADER) : 0u);
EXPECT_EQ(header->CheckSum, 0u);
EXPECT_EQ(header->TimeDateStamp, timestamp);
EXPECT_EQ(header->Flags, MiniDumpNormal);
EXPECT_EQ(static_cast<MINIDUMP_TYPE>(header->Flags), MiniDumpNormal);
}
} // namespace test