From 90cde8e30f7d56e46ce7ba8c57524632591a1632 Mon Sep 17 00:00:00 2001 From: Joshua Peraza Date: Thu, 15 Feb 2018 13:33:54 -0800 Subject: [PATCH] Disable upload on Android Crash report upload is currently the responsibility of the embedding client (e.g. Chrome) on Android. Bug: crashpad:30 Change-Id: Ia658ec327783bd6d2ea6d7e279e942f458dd12ef Reviewed-on: https://chromium-review.googlesource.com/922877 Commit-Queue: Joshua Peraza Reviewed-by: Mark Mentovai --- handler/crash_report_upload_thread.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/handler/crash_report_upload_thread.cc b/handler/crash_report_upload_thread.cc index 8d7149ea..290c5a3f 100644 --- a/handler/crash_report_upload_thread.cc +++ b/handler/crash_report_upload_thread.cc @@ -241,6 +241,12 @@ void CrashReportUploadThread::ProcessPendingReport( CrashReportUploadThread::UploadResult CrashReportUploadThread::UploadReport( const CrashReportDatabase::UploadReport* report, std::string* response_body) { +#if defined(OS_ANDROID) + // TODO(jperaza): This method can be enabled on Android after HTTPTransport is + // implemented and Crashpad takes over upload responsibilty on Android. + NOTREACHED(); + return UploadResult::kPermanentFailure; +#else std::map parameters; FileReader* reader = report->Reader(); @@ -322,6 +328,7 @@ CrashReportUploadThread::UploadResult CrashReportUploadThread::UploadReport( } return UploadResult::kSuccess; +#endif // OS_ANDROID } void CrashReportUploadThread::DoWork(const WorkerThread* thread) {