From 8bad6f140e0bb3748f5e69cbccfdfe5266799e8b Mon Sep 17 00:00:00 2001 From: Leonard Chan Date: Fri, 21 Feb 2020 20:40:08 -0800 Subject: [PATCH] [UBSan] Temporarily disable UBSan for gtest and file These should be the remaining instances of UB errors we see. Bug: fuchsia:46805 Change-Id: Id8285386fd6cb52518f6076ddb79ac60025f9f87 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2067754 Reviewed-by: Scott Graham Commit-Queue: Scott Graham --- BUILD.gn | 2 ++ third_party/gtest/BUILD.gn | 1 + util/BUILD.gn | 2 ++ 3 files changed, 5 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index 31c90918..cba955dd 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -28,6 +28,8 @@ config("disable_ubsan") { visibility = [ "snapshot:snapshot", "minidump:minidump_test", + "third_party/gtest:gtest", + "util:util", ] } diff --git a/third_party/gtest/BUILD.gn b/third_party/gtest/BUILD.gn index 58197334..28137681 100644 --- a/third_party/gtest/BUILD.gn +++ b/third_party/gtest/BUILD.gn @@ -34,6 +34,7 @@ if (crashpad_is_in_chromium) { public_deps = [ "//third_party/googletest:gtest", ] + public_configs = [ "../..:disable_ubsan" ] } group("gmock") { testonly = true diff --git a/util/BUILD.gn b/util/BUILD.gn index f057fd96..aa890264 100644 --- a/util/BUILD.gn +++ b/util/BUILD.gn @@ -514,6 +514,8 @@ static_library("util") { if (crashpad_is_android || crashpad_is_linux) { deps += [ "../third_party/lss" ] } + + configs += [ "..:disable_ubsan" ] } if (!crashpad_is_android) {