Omit platform-specific assembler source from builds as needed

The default filename rules do not match .S or .asm, so the
platform-specific assembler implementations of CaptureContext() were not
being affirmatively excluded from other platforms’ builds. This
previously worked without causing problems because the Mac build
environment didn’t know what to do with .asm files, and the Windows
build environment didn’t know what to do with .S files. Now that another
platform that may understand .S files is being added, the rules for when
to build these files must be tailored a bit more tightly.

BUG=crashpad:30

Change-Id: Ib62e619c007320d45279c104b3e229d92698aa72
Reviewed-on: https://chromium-review.googlesource.com/406348
Reviewed-by: Robert Sesek <rsesek@chromium.org>
This commit is contained in:
Mark Mentovai 2016-11-01 16:47:10 -04:00
parent 47a830465f
commit 88e3b6b022
2 changed files with 9 additions and 0 deletions

View File

@ -61,6 +61,11 @@
],
},
}],
['OS!="mac"', {
'sources!': [
'capture_context_mac.S',
],
}],
],
'direct_dependent_settings': {
'include_dirs': [

View File

@ -284,6 +284,10 @@
},
}],
],
}, { # else: OS!="win"
'sources!': [
'win/capture_context.asm',
],
}],
],
},