3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-17 16:43:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary macro from CaptureContext code

Browse Source 
The Windows implementation of CaptureContext used a macro to refer to
the offset of a field in a struct.

Bug: chromium:762167
Change-Id: I621d5c88283b1d066158559aade8811a9825c72e
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2426743
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Eric Astor 2020-09-23 11:45:42 -04:00
parent 36d4bb83b3
commit 865ba27672
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
util/misc/capture_context_win.asm
View File

@ -25,10 +25,6 @@ ifdef _M_IX86
.model flat .model flat
endif endif
offsetof macro structure, field
exitm <structure.&field>
endm
; The CONTEXT structure definitions that follow are based on those in <winnt.h>. ; The CONTEXT structure definitions that follow are based on those in <winnt.h>.
; Field names are prefixed (as in c_Rax) to avoid colliding with the predefined ; Field names are prefixed (as in c_Rax) to avoid colliding with the predefined
; register names (such as Rax). ; register names (such as Rax).
@ -481,8 +477,7 @@ CAPTURECONTEXT_SYMBOL proc frame
cld cld
lea rdi, [rcx.CONTEXT].c_FltSave lea rdi, [rcx.CONTEXT].c_FltSave
xor rax, rax xor rax, rax
mov rcx, (sizeof(CONTEXT) - offsetof(CONTEXT, c_FltSave)) / \ mov rcx, (sizeof(CONTEXT) - CONTEXT.c_FltSave) / sizeof(qword) ; 122
sizeof(qword) ; 122
rep stosq rep stosq
mov rcx, rbx mov rcx, rbx