3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-27 15:32:10 +08:00
Code Issues Projects Releases Wiki Activity

[fuchsia] Temporarily disable hwasan from crashpad tests

Browse Source 
Much of crashpad's unittests propagate tagged pointers to fuchsia
syscalls which do not accept tagged values. Rather than fixing them all
right now, just ensure that the tests do not build with the hwasan
variant if enabled.

Bug: fxbug.dev/108368
Change-Id: Ib32eb95ba671a6b55694075b68c7fbbb733cf501
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4175438
Reviewed-by: Francois Rousseau <frousseau@google.com>
Commit-Queue: Francois Rousseau <frousseau@google.com>
This commit is contained in:
Leonard Chan 2023-01-17 23:18:15 +00:00 committed by Crashpad LUCI CQ
parent 1e10a2370e
commit 84627e1ac7
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BUILD.gn
View File

@ -39,6 +39,8 @@ if (crashpad_is_in_chromium || crashpad_is_in_fuchsia) {
if (crashpad_is_in_fuchsia) { if (crashpad_is_in_fuchsia) {
# TODO(fuchsia:46559): Fix the leaks and remove this. # TODO(fuchsia:46559): Fix the leaks and remove this.
deps += [ "//build/config/sanitizers:suppress-lsan.DO-NOT-USE-THIS" ] deps += [ "//build/config/sanitizers:suppress-lsan.DO-NOT-USE-THIS" ]
# TODO(fxbug.dev/108368): Remove this once the underlying issue is addressed.
exclude_toolchain_tags = [ "hwasan" ]
} }
if (crashpad_is_android) { if (crashpad_is_android) {
use_raw_android_executable = true use_raw_android_executable = true

19
snapshot/BUILD.gn
View File

@ -505,6 +505,10 @@ crashpad_loadable_module("crashpad_snapshot_test_module") {
"$mini_chromium_source_parent:base", "$mini_chromium_source_parent:base",
"../client", "../client",
] ]
if (crashpad_is_in_fuchsia) {
# TODO(fxbug.dev/108368): Remove this once the underlying issue is addressed.
exclude_toolchain_tags = [ "hwasan" ]
}
} }
crashpad_loadable_module("crashpad_snapshot_test_module_large") { crashpad_loadable_module("crashpad_snapshot_test_module_large") {
@ -519,6 +523,11 @@ crashpad_loadable_module("crashpad_snapshot_test_module_large") {
defines = [ "CRASHPAD_INFO_SIZE_TEST_MODULE_LARGE" ] defines = [ "CRASHPAD_INFO_SIZE_TEST_MODULE_LARGE" ]
deps += [ "$mini_chromium_source_parent:base" ] deps += [ "$mini_chromium_source_parent:base" ]
if (crashpad_is_in_fuchsia) {
# TODO(fxbug.dev/108368): Remove this once the underlying issue is addressed.
exclude_toolchain_tags = [ "hwasan" ]
}
} }
crashpad_loadable_module("crashpad_snapshot_test_module_small") { crashpad_loadable_module("crashpad_snapshot_test_module_small") {
@ -533,6 +542,11 @@ crashpad_loadable_module("crashpad_snapshot_test_module_small") {
defines = [ "CRASHPAD_INFO_SIZE_TEST_MODULE_SMALL" ] defines = [ "CRASHPAD_INFO_SIZE_TEST_MODULE_SMALL" ]
deps += [ "$mini_chromium_source_parent:base" ] deps += [ "$mini_chromium_source_parent:base" ]
if (crashpad_is_in_fuchsia) {
# TODO(fxbug.dev/108368): Remove this once the underlying issue is addressed.
exclude_toolchain_tags = [ "hwasan" ]
}
} }
if ((crashpad_is_linux || crashpad_is_android || crashpad_is_fuchsia) && if ((crashpad_is_linux || crashpad_is_android || crashpad_is_fuchsia) &&
@ -543,6 +557,11 @@ if ((crashpad_is_linux || crashpad_is_android || crashpad_is_fuchsia) &&
# This makes `ld` emit both .hash and .gnu.hash sections. # This makes `ld` emit both .hash and .gnu.hash sections.
ldflags = [ "-Wl,--hash-style=both" ] ldflags = [ "-Wl,--hash-style=both" ]
if (crashpad_is_in_fuchsia) {
# TODO(fxbug.dev/108368): Remove this once the underlying issue is addressed.
exclude_toolchain_tags = [ "hwasan" ]
}
} }
} }