Make ScopedGeneric uses slightly more consistent

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1426533008 .

client/settings.cc

@@ -24,11 +24,6 @@ namespace crashpad {
 
 namespace internal {
 
-// static
-FileHandle ScopedLockedFileHandleTraits::InvalidValue() {
-  return kInvalidFileHandle;
-}
-
 // static
 void ScopedLockedFileHandleTraits::Free(FileHandle handle) {
   if (handle != kInvalidFileHandle) {

client/settings.h

@@ -31,7 +31,7 @@ namespace crashpad {
 namespace internal {
 
 struct ScopedLockedFileHandleTraits {
-  static FileHandle InvalidValue();
+  static FileHandle InvalidValue() { return kInvalidFileHandle; }
   static void Free(FileHandle handle);
 };
 

util/win/process_info_test.cc

@@ -525,6 +525,7 @@ struct ScopedRegistryKeyCloseTraits {
     RegCloseKey(key);
   }
 };
+
 using ScopedRegistryKey =
     base::ScopedGeneric<HKEY, ScopedRegistryKeyCloseTraits>;
 

util/win/scoped_local_alloc.cc

@@ -17,10 +17,12 @@
 #include "base/logging.h"
 
 namespace crashpad {
+namespace internal {
 
 // static
 void LocalAllocTraits::Free(HLOCAL memory) {
   PLOG_IF(ERROR, LocalFree(memory) != nullptr) << "LocalFree";
 }
 
+}  // namespace internal
 }  // namespace crashpad

util/win/scoped_local_alloc.h

@@ -21,12 +21,17 @@
 
 namespace crashpad {
 
+namespace internal {
+
 struct LocalAllocTraits {
   static HLOCAL InvalidValue() { return nullptr; }
   static void Free(HLOCAL mem);
 };
 
-using ScopedLocalAlloc = base::ScopedGeneric<HLOCAL, LocalAllocTraits>;
+}  // namespace internal
+
+using ScopedLocalAlloc =
+    base::ScopedGeneric<HLOCAL, internal::LocalAllocTraits>;
 
 }  // namespace crashpad