3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-20 02:23:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a few documentation problems.

Browse Source 
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/688643002
This commit is contained in:
Mark Mentovai 2014-10-29 11:33:34 -04:00
parent 78bec65b27
commit 7f30a9ebef
4 changed files with 25 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/crashpad_info.cc
View File

@ -30,7 +30,7 @@ static const uint32_t kCrashpadInfoVersion = 1;
namespace crashpad { namespace crashpad {
#if CXX_LIBRARY_VERSION >= 2011 #if CXX_LIBRARY_VERSION >= 2011 || DOXYGEN
// In C++11, check that CrashpadInfo has standard layout, which is what is // In C++11, check that CrashpadInfo has standard layout, which is what is
// actually important. // actually important.
static_assert(std::is_standard_layout<CrashpadInfo>::value, static_assert(std::is_standard_layout<CrashpadInfo>::value,

10
compat/non_win/dbghelp.h
View File

@ -164,8 +164,8 @@ enum MINIDUMP_STREAM_TYPE {
//! //!
//! The exact version of the stream that is present is implied by the stream’s //! The exact version of the stream that is present is implied by the stream’s
//! size. Furthermore, this stream contains a field, //! size. Furthermore, this stream contains a field,
//! MINIDUMP_MISC_INFO_STREAM::Flags1, that indicates which data is present //! MINIDUMP_MISC_INFO::Flags1, that indicates which data is present and
//! and valid. //! valid.
MiscInfoStream = 15, MiscInfoStream = 15,
}; };
@ -840,9 +840,9 @@ enum MINIDUMP_TYPE {
//! - A MINIDUMP_MODULE_LIST stream. All loaded modules are present. //! - A MINIDUMP_MODULE_LIST stream. All loaded modules are present.
//! - Typically, a MINIDUMP_MEMORY_LIST stream containing duplicate pointers //! - Typically, a MINIDUMP_MEMORY_LIST stream containing duplicate pointers
//! to the stack memory regions also referenced by the MINIDUMP_THREAD_LIST //! to the stack memory regions also referenced by the MINIDUMP_THREAD_LIST
//! stream. Since Windows 7 (NT 6.1), this type of minidump file also //! stream. This type of minidump file also includes a
//! includes a MINIDUMP_MEMORY_DESCRIPTOR containing the 256 bytes centered //! MINIDUMP_MEMORY_DESCRIPTOR containing the 256 bytes centered around
//! around the exception address or the instruction pointer. //! the exception address or the instruction pointer.
MiniDumpNormal = 0x00000000, MiniDumpNormal = 0x00000000,
}; };

2
snapshot/test/test_module_snapshot.h
View File

@ -28,7 +28,7 @@
namespace crashpad { namespace crashpad {
namespace test { namespace test {
//! \brief A test ModuleSnapshot that can carries arbitrary data for testing //! \brief A test ModuleSnapshot that can carry arbitrary data for testing
//! purposes. //! purposes.
class TestModuleSnapshot final : public ModuleSnapshot { class TestModuleSnapshot final : public ModuleSnapshot {
public: public:

20
util/stdlib/pointer_container.h
View File

@ -17,13 +17,18 @@
#include <vector> #include <vector>
#include "base/basictypes.h"
#include "base/stl_util.h" #include "base/stl_util.h"
namespace crashpad { namespace crashpad {
// PointerContainer allows an STL container such as std::vector<> to “own” //! \brief Allows a standard container to “own” pointer elements stored in it.
// pointer elements stored in it. When the container is destroyed, “delete” will //!
// be called on its pointer elements. //! When the container is destroyed, `delete` will be called on its pointer
//! elements.
//!
//! \note No attempt is made to `delete` elements that are removed from the
//! container by other means, such as replacement or `clear()`.
template <typename ContainerType> template <typename ContainerType>
class PointerContainer : public ContainerType { class PointerContainer : public ContainerType {
public: public:
@ -33,8 +38,17 @@ class PointerContainer : public ContainerType {
private: private:
STLElementDeleter<ContainerType> pointer_deleter_; STLElementDeleter<ContainerType> pointer_deleter_;
DISALLOW_COPY_AND_ASSIGN(PointerContainer);
}; };
//! \brief Allows a `std::vector` to “own” pointer elements stored in it.
//!
//! When the vector is destroyed, `delete` will be called on its pointer
//! elements.
//!
//! \note No attempt is made to `delete` elements that are removed from the
//! vector by other means, such as replacement or `clear()`.
template <typename T> template <typename T>
class PointerVector : public PointerContainer<std::vector<T*>> {}; class PointerVector : public PointerContainer<std::vector<T*>> {};