That last CL did actually take effect:
https://ci.chromium.org/p/crashpad/builders/try/crashpad_try_win_dbg/1536?
(Input properties).

So possibly, I just didn't wait long enough, and the version without
sdk_properties is actually correct. In any case, this causes failures
which block the CQ for unrelated changes, so revert.

TBR: justincohen@chromium.org
Change-Id: Ie79f3b3aaa3c35d0ad0adfb89f3cdf81b4ea4378
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2859469
Reviewed-by: Scott Graham <scottmg@chromium.org>
This commit is contained in:
Scott Graham 2021-04-29 10:00:55 -07:00
parent e9de0a23ff
commit 7e32faac2e

View File

@ -78,7 +78,7 @@ builder_mixins {
dimensions: "os:Windows-10" dimensions: "os:Windows-10"
recipe { recipe {
properties: "target_os:win" properties: "target_os:win"
properties_j: "$depot_tools/windows_sdk:{\"sdk_properties\":{\"version\":\"2021-04-28\"}}" properties_j: "$depot_tools/windows_sdk:{\"version\":\"2021-04-28\"}"
} }
} }