3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

win x86: a few trivial compile fixes when GYP_DEFINES=target_arch=ia32

Browse Source 
(CL to add x86 bots to waterfall in progress too.)

R=mark@chromium.org
BUG=crashpad:49

Review URL: https://codereview.chromium.org/1325173002 .
This commit is contained in:
Scott Graham 2015-09-02 18:35:19 -07:00
parent 3ef04d14f2
commit 754cc3609c
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
snapshot/win/pe_image_reader_test.cc
View File

@ -42,7 +42,7 @@ TEST(PEImageReader, DebugDirectory) {
DWORD age; DWORD age;
std::string pdbname; std::string pdbname;
EXPECT_TRUE(pe_image_reader.DebugDirectoryInformation(&uuid, &age, &pdbname)); EXPECT_TRUE(pe_image_reader.DebugDirectoryInformation(&uuid, &age, &pdbname));
EXPECT_NE(-1, pdbname.find("crashpad_snapshot_test")); EXPECT_NE(std::string::npos, pdbname.find("crashpad_snapshot_test"));
const std::string suffix(".pdb"); const std::string suffix(".pdb");
EXPECT_EQ( EXPECT_EQ(
0, 0,

2
snapshot/win/process_reader_win_test.cc
View File

@ -104,7 +104,7 @@ TEST(ProcessReaderWin, SelfOneThread) {
#if defined(ARCH_CPU_64_BITS) #if defined(ARCH_CPU_64_BITS)
EXPECT_NE(0, threads[0].context.Rip); EXPECT_NE(0, threads[0].context.Rip);
#else #else
EXPECT_NE(0, threads[0].context.Eip); EXPECT_NE(0u, threads[0].context.Eip);
#endif #endif
EXPECT_EQ(0, threads[0].suspend_count); EXPECT_EQ(0, threads[0].suspend_count);

2
test/win/win_child_process.cc
View File

@ -54,7 +54,7 @@ bool GetSwitch(const char* switch_name, std::string* value) {
std::string switch_name_with_equals(switch_name); std::string switch_name_with_equals(switch_name);
switch_name_with_equals += "="; switch_name_with_equals += "=";
for (size_t i = 1; i < num_args; ++i) { for (int i = 1; i < num_args; ++i) {
const wchar_t* arg = args[i]; const wchar_t* arg = args[i];
std::string arg_as_utf8 = base::UTF16ToUTF8(arg); std::string arg_as_utf8 = base::UTF16ToUTF8(arg);
if (arg_as_utf8.compare( if (arg_as_utf8.compare(