3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 22:26:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

win: Avoid some more clang complaints

Browse Source 
R=mark@chromium.org
BUG=chromium:82385

Review URL: https://codereview.chromium.org/1463633002 .
This commit is contained in:
Scott Graham 2015-11-19 15:09:59 -08:00
parent 0a717f0d27
commit 74e69ed555
3 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
client/crashpad_client_win.cc
View File

@ -368,7 +368,7 @@ bool CrashpadClient::UseHandler() {
reinterpret_cast<WinVMAddress>(&g_critical_section_with_debug_info); reinterpret_cast<WinVMAddress>(&g_critical_section_with_debug_info);
} }
ServerToClientMessage response = {0}; ServerToClientMessage response = {};
if (!SendToCrashHandlerServer(ipc_pipe_, message, &response)) { if (!SendToCrashHandlerServer(ipc_pipe_, message, &response)) {
return false; return false;
@ -408,7 +408,7 @@ void CrashpadClient::DumpWithoutCrash(const CONTEXT& context) {
// Create a fake EXCEPTION_POINTERS to give the handler something to work // Create a fake EXCEPTION_POINTERS to give the handler something to work
// with. // with.
EXCEPTION_POINTERS exception_pointers = {0}; EXCEPTION_POINTERS exception_pointers = {};
// This is logically const, but EXCEPTION_POINTERS does not declare it as // This is logically const, but EXCEPTION_POINTERS does not declare it as
// const, so we have to cast that away from the argument. // const, so we have to cast that away from the argument.
@ -421,7 +421,7 @@ void CrashpadClient::DumpWithoutCrash(const CONTEXT& context) {
// some of the top nibble set, so we make sure to pick a value that doesn't, // some of the top nibble set, so we make sure to pick a value that doesn't,
// so as to be unlikely to conflict. // so as to be unlikely to conflict.
const uint32_t kSimulatedExceptionCode = 0x517a7ed; const uint32_t kSimulatedExceptionCode = 0x517a7ed;
EXCEPTION_RECORD record = {0}; EXCEPTION_RECORD record = {};
record.ExceptionCode = kSimulatedExceptionCode; record.ExceptionCode = kSimulatedExceptionCode;
#if defined(ARCH_CPU_64_BITS) #if defined(ARCH_CPU_64_BITS)
record.ExceptionAddress = reinterpret_cast<void*>(context.Rip); record.ExceptionAddress = reinterpret_cast<void*>(context.Rip);

2
util/win/exception_handler_server.cc
View File

@ -446,7 +446,7 @@ bool ExceptionHandlerServer::ServiceClientConnection(
<< message.shutdown.token; << message.shutdown.token;
return false; return false;
} }
ServerToClientMessage shutdown_response = {0}; ServerToClientMessage shutdown_response = {};
LoggingWriteFile(service_context.pipe(), LoggingWriteFile(service_context.pipe(),
&shutdown_response, &shutdown_response,
sizeof(shutdown_response)); sizeof(shutdown_response));

8
util/win/process_info.cc
View File

@ -222,7 +222,7 @@ template <class Traits>
bool ReadProcessData(HANDLE process, bool ReadProcessData(HANDLE process,
WinVMAddress peb_address_vmaddr, WinVMAddress peb_address_vmaddr,
ProcessInfo* process_info) { ProcessInfo* process_info) {
Traits::Pointer peb_address; typename Traits::Pointer peb_address;
if (!AssignIfInRange(&peb_address, peb_address_vmaddr)) { if (!AssignIfInRange(&peb_address, peb_address_vmaddr)) {
LOG(ERROR) << base::StringPrintf("peb address 0x%x out of range", LOG(ERROR) << base::StringPrintf("peb address 0x%x out of range",
peb_address_vmaddr); peb_address_vmaddr);
@ -273,8 +273,10 @@ bool ReadProcessData(HANDLE process,
// Walk the PEB LDR structure (doubly-linked list) to get the list of loaded // Walk the PEB LDR structure (doubly-linked list) to get the list of loaded
// modules. We use this method rather than EnumProcessModules to get the // modules. We use this method rather than EnumProcessModules to get the
// modules in initialization order rather than memory order. // modules in initialization order rather than memory order.
Traits::Pointer last = peb_ldr_data.InInitializationOrderModuleList.Blink; typename Traits::Pointer last =
for (Traits::Pointer cur = peb_ldr_data.InInitializationOrderModuleList.Flink; peb_ldr_data.InInitializationOrderModuleList.Blink;
for (typename Traits::Pointer cur =
peb_ldr_data.InInitializationOrderModuleList.Flink;
; ;
cur = ldr_data_table_entry.InInitializationOrderLinks.Flink) { cur = ldr_data_table_entry.InInitializationOrderLinks.Flink) {
// |cur| is the pointer to the LIST_ENTRY embedded in the // |cur| is the pointer to the LIST_ENTRY embedded in the