[fuchsia] use source_set for C FIDL library

this makes it easier to depend on what we want (the C bindings) rather than having to maintain two lists in sync (sources and deps)

Change-Id: Ib3c7715cf8e54658ab44e4de04d04acedf13d09c
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1558821
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
This commit is contained in:
Francois Rousseau 2019-04-08 15:48:06 -07:00 committed by Commit Bot
parent 5a94b55000
commit 7411c8354b

View File

@ -58,7 +58,6 @@ if (crashpad_is_in_fuchsia) {
}, },
] ]
fidl_gen_sources = []
foreach(fidl_source, fidl_sources) { foreach(fidl_source, fidl_sources) {
fidl_stem = "$target_gen_dir/fidl/${fidl_source.library_name}" fidl_stem = "$target_gen_dir/fidl/${fidl_source.library_name}"
c_stem = "$fidl_root_gen_dir/${fidl_source.header_stem}/c" c_stem = "$fidl_root_gen_dir/${fidl_source.header_stem}/c"
@ -66,11 +65,6 @@ if (crashpad_is_in_fuchsia) {
c_client = "$c_stem/client.cc" c_client = "$c_stem/client.cc"
coding_tables = "$fidl_stem/tables.cc" coding_tables = "$fidl_stem/tables.cc"
fidl_gen_sources += [
c_client,
coding_tables,
]
# Compiles the .fidl file and generates the C bindings. # Compiles the .fidl file and generates the C bindings.
action("fidlc_${fidl_source.library_name}") { action("fidlc_${fidl_source.library_name}") {
visibility = [ ":*" ] visibility = [ ":*" ]
@ -102,11 +96,24 @@ if (crashpad_is_in_fuchsia) {
coding_tables, coding_tables,
] ]
} }
source_set("${fidl_source.library_name}_c") {
sources = [
c_client,
c_header,
coding_tables,
]
deps = [
":fidlc_${fidl_source.library_name}",
]
public_configs = [ ":fidl_config" ]
}
} }
static_library("fuchsia") { static_library("fuchsia") {
sources = sources = [
[
# This is the zx library. # This is the zx library.
"$sdk_pkg_path/zx/channel.cpp", "$sdk_pkg_path/zx/channel.cpp",
"$sdk_pkg_path/zx/event.cpp", "$sdk_pkg_path/zx/event.cpp",
@ -170,10 +177,10 @@ if (crashpad_is_in_fuchsia) {
"$sdk_pkg_path/fidl_base/visitor.h", "$sdk_pkg_path/fidl_base/visitor.h",
"$sdk_pkg_path/fidl_base/walker.cpp", "$sdk_pkg_path/fidl_base/walker.cpp",
"$sdk_pkg_path/fidl_base/walker.h", "$sdk_pkg_path/fidl_base/walker.h",
] + fidl_gen_sources ]
deps = [ deps = [
":fidlc_fuchsia.sysinfo", ":fuchsia.sysinfo_c",
] ]
public_configs = [ public_configs = [