From 71f6724239bf68b73ea950e7ce5e7a315cd0a16d Mon Sep 17 00:00:00 2001 From: Scott Graham Date: Thu, 24 Mar 2016 14:09:24 -0700 Subject: [PATCH] Disable end-to-end test of extra memory range removal In debug builds, the extra memory is sometimes getting captured (probably by a stale stack pointer), so disable this test for now to un-red the bots. We can probably fix it by moving this one test to a separate binary (or perhaps just removing it, I'm not sure it's that useful anyway above and beyond the unit test.) R=mark@chromium.org BUG=crashpad:101 Change-Id: I98a58a467fb4a4d9f84d2e0d020a031a0ea9743c Reviewed-on: https://chromium-review.googlesource.com/334821 Reviewed-by: Scott Graham --- snapshot/win/end_to_end_test.py | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/snapshot/win/end_to_end_test.py b/snapshot/win/end_to_end_test.py index a3506b64..53d1b074 100755 --- a/snapshot/win/end_to_end_test.py +++ b/snapshot/win/end_to_end_test.py @@ -280,15 +280,19 @@ def RunTests(cdb_path, r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\?', ' and not memory after range') - out = CdbRun(cdb_path, dump_path, - 'dd poi(crashy_program!crashpad::g_extra_memory_not_saved)' - '+0x1f30 L4') - # We save only the pointer, not the pointed-to data. If the pointer itself - # wasn't saved, then we won't get any memory printed, so here we're confirming - # the pointer was saved but the memory wasn't. - out.Check(r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\? ' - r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\?', - 'extra memory removal') + if False: + # TODO(scottmg): This is flakily capturing too much memory in Debug builds, + # possibly because a stale pointer is being captured via the stack. + # See: https://bugs.chromium.org/p/crashpad/issues/detail?id=101. + out = CdbRun(cdb_path, dump_path, + 'dd poi(crashy_program!crashpad::g_extra_memory_not_saved)' + '+0x1f30 L4') + # We save only the pointer, not the pointed-to data. If the pointer itself + # wasn't saved, then we won't get any memory printed, so here we're + # confirming the pointer was saved but the memory wasn't. + out.Check(r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\? ' + r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\?', + 'extra memory removal') out = CdbRun(cdb_path, dump_path, '.dumpdebug') out.Check(r'type \?\?\? \(333333\), size 00001000',