diff --git a/snapshot/win/end_to_end_test.py b/snapshot/win/end_to_end_test.py index a3506b64..53d1b074 100755 --- a/snapshot/win/end_to_end_test.py +++ b/snapshot/win/end_to_end_test.py @@ -280,15 +280,19 @@ def RunTests(cdb_path, r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\?', ' and not memory after range') - out = CdbRun(cdb_path, dump_path, - 'dd poi(crashy_program!crashpad::g_extra_memory_not_saved)' - '+0x1f30 L4') - # We save only the pointer, not the pointed-to data. If the pointer itself - # wasn't saved, then we won't get any memory printed, so here we're confirming - # the pointer was saved but the memory wasn't. - out.Check(r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\? ' - r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\?', - 'extra memory removal') + if False: + # TODO(scottmg): This is flakily capturing too much memory in Debug builds, + # possibly because a stale pointer is being captured via the stack. + # See: https://bugs.chromium.org/p/crashpad/issues/detail?id=101. + out = CdbRun(cdb_path, dump_path, + 'dd poi(crashy_program!crashpad::g_extra_memory_not_saved)' + '+0x1f30 L4') + # We save only the pointer, not the pointed-to data. If the pointer itself + # wasn't saved, then we won't get any memory printed, so here we're + # confirming the pointer was saved but the memory wasn't. + out.Check(r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\? ' + r'\?\?\?\?\?\?\?\? \?\?\?\?\?\?\?\?', + 'extra memory removal') out = CdbRun(cdb_path, dump_path, '.dumpdebug') out.Check(r'type \?\?\? \(333333\), size 00001000',