3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 22:16:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

[windows] stop PLOGing report path if stat fails

Browse Source 
apparently we're attempting to log to a C++ out-stream during process exit, and that is causing the run-time to try to do a character-set conversion, requiring it to look up some run-time locale state which has presumably already been torn-down

Bug: chromium:948588
Change-Id: I9431dafd0aaaa8827faf3b24985873733b431e22
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1558812
Commit-Queue: Francois Rousseau <frousseau@google.com>
Reviewed-by: Scott Graham <scottmg@chromium.org>
This commit is contained in:
Francois Rousseau 2019-04-08 14:25:44 -07:00 committed by Commit Bot
parent c8dc08b719
commit 71d2291f4e
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
client/crash_report_database_win.cc
View File

@ -466,8 +466,7 @@ void Metadata::Read() {
if (_wstat64(report_disk.file_path.value().c_str(), &statbuf) == 0) { if (_wstat64(report_disk.file_path.value().c_str(), &statbuf) == 0) {
report_disk.total_size = statbuf.st_size; report_disk.total_size = statbuf.st_size;
} else { } else {
PLOG(ERROR) << "stat " LOG(ERROR) << "failed to stat report";
<< base::UTF16ToUTF8(report_disk.file_path.value());
} }
reports.push_back(report_disk); reports.push_back(report_disk);