3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-27 15:21:13 +08:00
Code Issues Projects Releases Wiki Activity

ios: Fix setup_ios_gn.py after gn roll.

Browse Source 
The CL https://gn-review.googlesource.com/c/gn/+/10140 was brought
by the roll of gn. This CL causes the --root-target to have two
conflicting meaning.

Remove the parameter from //build/ios/setup_ios_gn.py to allow
the script to successfully generate an Xcode project. The drawback
is that more target than necessary may be built when building "All"
in Xcode.

Change-Id: I4eb68567c006646e671797fa321be83a167b98a3
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2538001
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
This commit is contained in:
Justin Cohen 2020-11-13 13:13:45 -05:00 committed by Commit Bot
parent bccb9504d1
commit 70f1ec86f9
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
build/ios/setup_ios_gn.py
View File

@ -199,7 +199,6 @@ class GnGenerator(object):
gn_command = [gn_path, '--root=%s' % os.path.realpath(src_path), '-q'] gn_command = [gn_path, '--root=%s' % os.path.realpath(src_path), '-q']
if generate_xcode_project: if generate_xcode_project:
gn_command.append('--ide=xcode') gn_command.append('--ide=xcode')
gn_command.append('--root-target=gn_all')
gn_command.append('--ninja-executable=autoninja') gn_command.append('--ninja-executable=autoninja')
if self._settings.has_section('filters'): if self._settings.has_section('filters'):
target_filters = self._settings.values('filters') target_filters = self._settings.values('filters')