3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

win: Use a semaphore for synchronization in ProcessSnapshotTest

Browse Source 
Bug: crashpad:160
Test: crashpad_snapshot_test ProcessSnapshotTest.CrashpadInfoChild*
Change-Id: Id9bd1ee6ec71c57ecab2ccba6106d41446d66902
Reviewed-on: https://chromium-review.googlesource.com/458879
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Mark Mentovai 2017-03-24 16:31:41 -04:00 committed by Commit Bot
parent 270490ff79
commit 6c8a3f7007
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
snapshot/win/crashpad_snapshot_test_image_reader.cc
View File

@ -17,12 +17,14 @@
#include "base/logging.h" #include "base/logging.h"
#include "client/crashpad_info.h" #include "client/crashpad_info.h"
#include "util/file/file_io.h" #include "util/file/file_io.h"
#include "util/synchronization/semaphore.h"
#include "util/win/scoped_handle.h" #include "util/win/scoped_handle.h"
namespace { namespace {
DWORD WINAPI LotsOfReferencesThreadProc(void* param) { DWORD WINAPI LotsOfReferencesThreadProc(void* param) {
LONG* count = reinterpret_cast<LONG*>(param); crashpad::Semaphore* semaphore =
reinterpret_cast<crashpad::Semaphore*>(param);
// Allocate a bunch of pointers to things on the stack. // Allocate a bunch of pointers to things on the stack.
int* pointers[1000]; int* pointers[1000];
@ -30,7 +32,7 @@ DWORD WINAPI LotsOfReferencesThreadProc(void* param) {
pointers[i] = new int[2048]; pointers[i] = new int[2048];
} }
InterlockedIncrement(count); semaphore->Signal();
Sleep(INFINITE); Sleep(INFINITE);
return 0; return 0;
} }
@ -48,13 +50,13 @@ int wmain(int argc, wchar_t* argv[]) {
// Create threads with lots of stack pointers to memory. This is used to // Create threads with lots of stack pointers to memory. This is used to
// verify the cap on pointed-to memory. // verify the cap on pointed-to memory.
LONG thread_ready_count = 0; crashpad::Semaphore semaphore(0);
crashpad::ScopedKernelHANDLE threads[100]; crashpad::ScopedKernelHANDLE threads[100];
for (int i = 0; i < arraysize(threads); ++i) { for (int i = 0; i < arraysize(threads); ++i) {
threads[i].reset(CreateThread(nullptr, threads[i].reset(CreateThread(nullptr,
0, 0,
&LotsOfReferencesThreadProc, &LotsOfReferencesThreadProc,
reinterpret_cast<void*>(&thread_ready_count), reinterpret_cast<void*>(&semaphore),
0, 0,
nullptr)); nullptr));
if (!threads[i].is_valid()) { if (!threads[i].is_valid()) {
@ -63,14 +65,8 @@ int wmain(int argc, wchar_t* argv[]) {
} }
} }
for (;;) { for (int i = 0; i < arraysize(threads); ++i) {
if (InterlockedCompareExchange(&thread_ready_count, semaphore.Wait();
thread_ready_count,
arraysize(threads)) == arraysize(threads)) {
// All threads have allocated their references.
break;
}
Sleep(10);
} }
crashpad::CrashpadInfo* crashpad_info = crashpad::CrashpadInfo* crashpad_info =