3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-26 06:31:50 +08:00
Code Issues Projects Releases Wiki Activity

Use NOTREACHED_IN_MIGRATION()

Browse Source 
This was generated by replacing "  NOTREACHED()" with
"  NOTREACHED_IN_MIGRATION()" and running git cl format.

This prepares for making NOTREACHED() [[noreturn]] alongside
NotReachedIsFatal migration of existing inventory.

Bug: chromium:40580068
Change-Id: Idb68e2fc8adba180350b0595fd494cf0f206bded
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5548246
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
This commit is contained in:
Peter Boström 2024-05-17 06:53:13 -07:00 committed by Crashpad LUCI CQ
parent efd29a76c9
commit 6af42bc0b2
30 changed files with 74 additions and 73 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/crashpad_client_linux_test.cc
View File

@ -765,7 +765,7 @@ class StartHandlerForChildTest : public Multiprocess {
__builtin_trap(); __builtin_trap();
NOTREACHED(); NOTREACHED_IN_MIGRATION();
} }
StartHandlerForClientTest test_state_; StartHandlerForClientTest test_state_;

2
client/prune_crash_reports.cc
View File

@ -123,7 +123,7 @@ bool BinaryPruneCondition::ShouldPruneReport(
case OR: case OR:
return lhs_->ShouldPruneReport(report) || rhs_->ShouldPruneReport(report); return lhs_->ShouldPruneReport(report) || rhs_->ShouldPruneReport(report);
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return false; return false;
} }
} }

2
client/settings.cc
View File

@ -292,7 +292,7 @@ FileHandle Settings::GetHandleFromOptions(
return OpenFileForReadAndWrite( return OpenFileForReadAndWrite(
file_path, options.mode, options.permissions); file_path, options.mode, options.permissions);
} }
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return kInvalidFileHandle; return kInvalidFileHandle;
} }

2
handler/crash_report_upload_thread.cc
View File

@ -236,7 +236,7 @@ void CrashReportUploadThread::ProcessPendingReport(
return; return;
case CrashReportDatabase::kCannotRequestUpload: case CrashReportDatabase::kCannotRequestUpload:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return; return;
} }

6
handler/win/hanging_program.cc
View File

@ -40,13 +40,13 @@ DWORD WINAPI Thread1(LPVOID context) {
Sleep(INFINITE); Sleep(INFINITE);
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
} }
DWORD WINAPI Thread2(LPVOID dummy) { DWORD WINAPI Thread2(LPVOID dummy) {
Sleep(INFINITE); Sleep(INFINITE);
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
} }
@ -65,7 +65,7 @@ DWORD WINAPI Thread3(LPVOID context) {
if (!FreeLibrary(dll)) if (!FreeLibrary(dll))
PLOG(FATAL) << "FreeLibrary"; PLOG(FATAL) << "FreeLibrary";
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
} }

2
minidump/minidump_context_writer_test.cc
View File

@ -56,7 +56,7 @@ class TestTypeNames {
if (std::is_same<T, RVA64>()) { if (std::is_same<T, RVA64>()) {
return "RVA64"; return "RVA64";
} }
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return ""; return "";
} }
}; };

2
minidump/minidump_string_writer_test.cc
View File

@ -42,7 +42,7 @@ class TestTypeNames {
if (std::is_same<T, RVA64>()) { if (std::is_same<T, RVA64>()) {
return "RVA64"; return "RVA64";
} }
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return ""; return "";
} }
}; };

4
minidump/minidump_system_info_writer.cc
View File

@ -136,7 +136,7 @@ void MinidumpSystemInfoWriter::InitializeFromSnapshot(
cpu_architecture = kMinidumpCPUArchitectureRISCV64Breakpad; cpu_architecture = kMinidumpCPUArchitectureRISCV64Breakpad;
break; break;
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
cpu_architecture = kMinidumpCPUArchitectureUnknown; cpu_architecture = kMinidumpCPUArchitectureUnknown;
break; break;
} }
@ -185,7 +185,7 @@ void MinidumpSystemInfoWriter::InitializeFromSnapshot(
operating_system = kMinidumpOSIOS; operating_system = kMinidumpOSIOS;
break; break;
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
operating_system = kMinidumpOSUnknown; operating_system = kMinidumpOSUnknown;
break; break;
} }

12
snapshot/cpu_context.cc
View File

@ -174,7 +174,7 @@ uint64_t CPUContext::InstructionPointer() const {
case kCPUArchitectureRISCV64: case kCPUArchitectureRISCV64:
return riscv64->pc; return riscv64->pc;
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return ~0ull; return ~0ull;
} }
} }
@ -192,7 +192,7 @@ uint64_t CPUContext::StackPointer() const {
case kCPUArchitectureRISCV64: case kCPUArchitectureRISCV64:
return riscv64->regs[1]; return riscv64->regs[1];
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return ~0ull; return ~0ull;
} }
} }
@ -202,12 +202,12 @@ uint64_t CPUContext::ShadowStackPointer() const {
case kCPUArchitectureX86: case kCPUArchitectureX86:
case kCPUArchitectureARM: case kCPUArchitectureARM:
case kCPUArchitectureARM64: case kCPUArchitectureARM64:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
case kCPUArchitectureX86_64: case kCPUArchitectureX86_64:
return x86_64->xstate.cet_u.ssp; return x86_64->xstate.cet_u.ssp;
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return ~0ull; return ~0ull;
} }
} }
@ -221,7 +221,7 @@ bool CPUContext::HasShadowStack() const {
case kCPUArchitectureX86_64: case kCPUArchitectureX86_64:
return x86_64->xstate.cet_u.cetmsr != 0; return x86_64->xstate.cet_u.cetmsr != 0;
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return false; return false;
} }
} }
@ -238,7 +238,7 @@ bool CPUContext::Is64Bit() const {
case kCPUArchitectureMIPSEL: case kCPUArchitectureMIPSEL:
return false; return false;
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return false; return false;
} }
} }

3
snapshot/fuchsia/process_snapshot_fuchsia.cc
View File

@ -114,7 +114,8 @@ crashpad::ProcessID ProcessSnapshotFuchsia::ProcessID() const {
crashpad::ProcessID ProcessSnapshotFuchsia::ParentProcessID() const { crashpad::ProcessID ProcessSnapshotFuchsia::ParentProcessID() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // TODO(scottmg): https://crashpad.chromium.org/bug/196 // TODO(scottmg): https://crashpad.chromium.org/bug/196
NOTREACHED_IN_MIGRATION();
return 0; return 0;
} }

10
snapshot/fuchsia/system_snapshot_fuchsia.cc
View File

@ -108,7 +108,7 @@ uint32_t SystemSnapshotFuchsia::CPUX86Signature() const {
#if defined(ARCH_CPU_X86_64) #if defined(ARCH_CPU_X86_64)
return cpuid_.Signature(); return cpuid_.Signature();
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -118,7 +118,7 @@ uint64_t SystemSnapshotFuchsia::CPUX86Features() const {
#if defined(ARCH_CPU_X86_64) #if defined(ARCH_CPU_X86_64)
return cpuid_.Features(); return cpuid_.Features();
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -128,7 +128,7 @@ uint64_t SystemSnapshotFuchsia::CPUX86ExtendedFeatures() const {
#if defined(ARCH_CPU_X86_64) #if defined(ARCH_CPU_X86_64)
return cpuid_.ExtendedFeatures(); return cpuid_.ExtendedFeatures();
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -137,7 +137,7 @@ uint32_t SystemSnapshotFuchsia::CPUX86Leaf7Features() const {
#if defined(ARCH_CPU_X86_64) #if defined(ARCH_CPU_X86_64)
return cpuid_.Leaf7Features(); return cpuid_.Leaf7Features();
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -147,7 +147,7 @@ bool SystemSnapshotFuchsia::CPUX86SupportsDAZ() const {
#if defined(ARCH_CPU_X86_64) #if defined(ARCH_CPU_X86_64)
return cpuid_.SupportsDAZ(); return cpuid_.SupportsDAZ();
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return false; return false;
#endif #endif
} }

10
snapshot/linux/system_snapshot_linux.cc
View File

@ -276,7 +276,7 @@ uint32_t SystemSnapshotLinux::CPUX86Signature() const {
#if defined(ARCH_CPU_X86_FAMILY) #if defined(ARCH_CPU_X86_FAMILY)
return cpuid_.Signature(); return cpuid_.Signature();
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -286,7 +286,7 @@ uint64_t SystemSnapshotLinux::CPUX86Features() const {
#if defined(ARCH_CPU_X86_FAMILY) #if defined(ARCH_CPU_X86_FAMILY)
return cpuid_.Features(); return cpuid_.Features();
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -296,7 +296,7 @@ uint64_t SystemSnapshotLinux::CPUX86ExtendedFeatures() const {
#if defined(ARCH_CPU_X86_FAMILY) #if defined(ARCH_CPU_X86_FAMILY)
return cpuid_.ExtendedFeatures(); return cpuid_.ExtendedFeatures();
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -306,7 +306,7 @@ uint32_t SystemSnapshotLinux::CPUX86Leaf7Features() const {
#if defined(ARCH_CPU_X86_FAMILY) #if defined(ARCH_CPU_X86_FAMILY)
return cpuid_.Leaf7Features(); return cpuid_.Leaf7Features();
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -316,7 +316,7 @@ bool SystemSnapshotLinux::CPUX86SupportsDAZ() const {
#if defined(ARCH_CPU_X86_FAMILY) #if defined(ARCH_CPU_X86_FAMILY)
return cpuid_.SupportsDAZ(); return cpuid_.SupportsDAZ();
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return false; return false;
#endif // ARCH_CPU_X86_FMAILY #endif // ARCH_CPU_X86_FMAILY
} }

6
snapshot/mac/cpu_context_mac.cc
View File

@ -196,7 +196,7 @@ thread_state_flavor_t InitializeCPUContextX86Flavor(
} }
default: { default: {
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return THREAD_STATE_NONE; return THREAD_STATE_NONE;
} }
} }
@ -377,7 +377,7 @@ thread_state_flavor_t InitializeCPUContextX86_64Flavor(
} }
default: { default: {
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return THREAD_STATE_NONE; return THREAD_STATE_NONE;
} }
} }
@ -553,7 +553,7 @@ thread_state_flavor_t InitializeCPUContextARM64Flavor(
} }
default: { default: {
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return THREAD_STATE_NONE; return THREAD_STATE_NONE;
} }
} }

10
snapshot/mac/system_snapshot_mac.cc
View File

@ -204,7 +204,7 @@ uint32_t SystemSnapshotMac::CPUX86Signature() const {
#if defined(ARCH_CPU_X86_FAMILY) #if defined(ARCH_CPU_X86_FAMILY)
return ReadIntSysctlByName<uint32_t>("machdep.cpu.signature", 0); return ReadIntSysctlByName<uint32_t>("machdep.cpu.signature", 0);
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -215,7 +215,7 @@ uint64_t SystemSnapshotMac::CPUX86Features() const {
#if defined(ARCH_CPU_X86_FAMILY) #if defined(ARCH_CPU_X86_FAMILY)
return ReadIntSysctlByName<uint64_t>("machdep.cpu.feature_bits", 0); return ReadIntSysctlByName<uint64_t>("machdep.cpu.feature_bits", 0);
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -226,7 +226,7 @@ uint64_t SystemSnapshotMac::CPUX86ExtendedFeatures() const {
#if defined(ARCH_CPU_X86_FAMILY) #if defined(ARCH_CPU_X86_FAMILY)
return ReadIntSysctlByName<uint64_t>("machdep.cpu.extfeature_bits", 0); return ReadIntSysctlByName<uint64_t>("machdep.cpu.extfeature_bits", 0);
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -251,7 +251,7 @@ uint32_t SystemSnapshotMac::CPUX86Leaf7Features() const {
CallCPUID(7, &eax, &ebx, &ecx, &edx); CallCPUID(7, &eax, &ebx, &ecx, &edx);
return ebx; return ebx;
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -290,7 +290,7 @@ bool SystemSnapshotMac::CPUX86SupportsDAZ() const {
// Test the DAZ bit. // Test the DAZ bit.
return fxsave.mxcsr_mask & (1 << 6); return fxsave.mxcsr_mask & (1 << 6);
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return false; return false;
#endif #endif
} }

4
snapshot/minidump/module_snapshot_minidump.cc
View File

@ -228,14 +228,14 @@ std::vector<AnnotationSnapshot> ModuleSnapshotMinidump::AnnotationObjects()
std::set<CheckedRange<uint64_t>> ModuleSnapshotMinidump::ExtraMemoryRanges() std::set<CheckedRange<uint64_t>> ModuleSnapshotMinidump::ExtraMemoryRanges()
const { const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return std::set<CheckedRange<uint64_t>>(); return std::set<CheckedRange<uint64_t>>();
} }
std::vector<const UserMinidumpStream*> std::vector<const UserMinidumpStream*>
ModuleSnapshotMinidump::CustomMinidumpStreams() const { ModuleSnapshotMinidump::CustomMinidumpStreams() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return std::vector<const UserMinidumpStream*>(); return std::vector<const UserMinidumpStream*>();
} }

6
snapshot/minidump/process_snapshot_minidump.cc
View File

@ -135,7 +135,7 @@ crashpad::ProcessID ProcessSnapshotMinidump::ProcessID() const {
crashpad::ProcessID ProcessSnapshotMinidump::ParentProcessID() const { crashpad::ProcessID ProcessSnapshotMinidump::ParentProcessID() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return 0; return 0;
} }
@ -208,7 +208,7 @@ std::vector<const ModuleSnapshot*> ProcessSnapshotMinidump::Modules() const {
std::vector<UnloadedModuleSnapshot> ProcessSnapshotMinidump::UnloadedModules() std::vector<UnloadedModuleSnapshot> ProcessSnapshotMinidump::UnloadedModules()
const { const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return unloaded_modules_; return unloaded_modules_;
} }
@ -229,7 +229,7 @@ std::vector<const MemoryMapRegionSnapshot*> ProcessSnapshotMinidump::MemoryMap()
std::vector<HandleSnapshot> ProcessSnapshotMinidump::Handles() const { std::vector<HandleSnapshot> ProcessSnapshotMinidump::Handles() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return std::vector<HandleSnapshot>(); return std::vector<HandleSnapshot>();
} }

20
snapshot/minidump/system_snapshot_minidump.cc
View File

@ -100,36 +100,36 @@ std::string SystemSnapshotMinidump::CPUVendor() const {
void SystemSnapshotMinidump::CPUFrequency(uint64_t* current_hz, void SystemSnapshotMinidump::CPUFrequency(uint64_t* current_hz,
uint64_t* max_hz) const { uint64_t* max_hz) const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
} }
uint32_t SystemSnapshotMinidump::CPUX86Signature() const { uint32_t SystemSnapshotMinidump::CPUX86Signature() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return 0; return 0;
} }
uint64_t SystemSnapshotMinidump::CPUX86Features() const { uint64_t SystemSnapshotMinidump::CPUX86Features() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return 0; return 0;
} }
uint64_t SystemSnapshotMinidump::CPUX86ExtendedFeatures() const { uint64_t SystemSnapshotMinidump::CPUX86ExtendedFeatures() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return 0; return 0;
} }
uint32_t SystemSnapshotMinidump::CPUX86Leaf7Features() const { uint32_t SystemSnapshotMinidump::CPUX86Leaf7Features() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return 0; return 0;
} }
bool SystemSnapshotMinidump::CPUX86SupportsDAZ() const { bool SystemSnapshotMinidump::CPUX86SupportsDAZ() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return false; return false;
} }
@ -178,13 +178,13 @@ std::string SystemSnapshotMinidump::OSVersionFull() const {
std::string SystemSnapshotMinidump::MachineDescription() const { std::string SystemSnapshotMinidump::MachineDescription() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return std::string(); return std::string();
} }
bool SystemSnapshotMinidump::NXEnabled() const { bool SystemSnapshotMinidump::NXEnabled() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return false; return false;
} }
@ -194,12 +194,12 @@ void SystemSnapshotMinidump::TimeZone(DaylightSavingTimeStatus* dst_status,
std::string* standard_name, std::string* standard_name,
std::string* daylight_name) const { std::string* daylight_name) const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
} }
uint64_t SystemSnapshotMinidump::AddressMask() const { uint64_t SystemSnapshotMinidump::AddressMask() const {
INITIALIZATION_STATE_DCHECK_VALID(initialized_); INITIALIZATION_STATE_DCHECK_VALID(initialized_);
NOTREACHED(); // https://crashpad.chromium.org/bug/10 NOTREACHED_IN_MIGRATION(); // https://crashpad.chromium.org/bug/10
return 0; return 0;
} }

2
snapshot/sanitized/process_snapshot_sanitized_test.cc
View File

@ -129,7 +129,7 @@ void ChildTestFunction() {
CRASHPAD_CHILD_TEST_MAIN(ChildToBeSanitized) { CRASHPAD_CHILD_TEST_MAIN(ChildToBeSanitized) {
ChildTestFunction(); ChildTestFunction();
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return EXIT_SUCCESS; return EXIT_SUCCESS;
} }

10
snapshot/win/system_snapshot_win.cc
View File

@ -360,7 +360,7 @@ uint32_t SystemSnapshotWin::CPUX86Signature() const {
__cpuid(cpu_info, 1); __cpuid(cpu_info, 1);
return cpu_info[0]; return cpu_info[0];
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -375,7 +375,7 @@ uint64_t SystemSnapshotWin::CPUX86Features() const {
return (static_cast<uint64_t>(cpu_info[2]) << 32) | return (static_cast<uint64_t>(cpu_info[2]) << 32) |
static_cast<uint64_t>(cpu_info[3]); static_cast<uint64_t>(cpu_info[3]);
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -391,7 +391,7 @@ uint64_t SystemSnapshotWin::CPUX86ExtendedFeatures() const {
return (static_cast<uint64_t>(cpu_info[2]) << 32) | return (static_cast<uint64_t>(cpu_info[2]) << 32) |
static_cast<uint64_t>(cpu_info[3]); static_cast<uint64_t>(cpu_info[3]);
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -410,7 +410,7 @@ uint32_t SystemSnapshotWin::CPUX86Leaf7Features() const {
__cpuidex(cpu_info, 7, 0); __cpuidex(cpu_info, 7, 0);
return cpu_info[1]; return cpu_info[1];
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }
@ -441,7 +441,7 @@ bool SystemSnapshotWin::CPUX86SupportsDAZ() const {
// Test the DAZ bit. // Test the DAZ bit.
return (mxcsr_mask & (1 << 6)) != 0; return (mxcsr_mask & (1 << 6)) != 0;
#else #else
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return 0; return 0;
#endif #endif
} }

4
test/linux/fake_ptrace_connection.cc
View File

@ -90,14 +90,14 @@ ProcessMemoryLinux* FakePtraceConnection::Memory() {
bool FakePtraceConnection::Threads(std::vector<pid_t>* threads) { bool FakePtraceConnection::Threads(std::vector<pid_t>* threads) {
// TODO(jperaza): Implement this if/when it's needed. // TODO(jperaza): Implement this if/when it's needed.
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return false; return false;
} }
ssize_t FakePtraceConnection::ReadUpTo(VMAddress address, ssize_t FakePtraceConnection::ReadUpTo(VMAddress address,
size_t size, size_t size,
void* buffer) { void* buffer) {
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return false; return false;
} }

2
util/file/file_io_posix.cc
View File

@ -276,7 +276,7 @@ FileHandle StdioFileHandle(StdioStream stdio_stream) {
return STDERR_FILENO; return STDERR_FILENO;
} }
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return kInvalidFileHandle; return kInvalidFileHandle;
} }

4
util/file/file_io_win.cc
View File

@ -230,7 +230,7 @@ FileOffset LoggingSeekFile(FileHandle file, FileOffset offset, int whence) {
method = FILE_END; method = FILE_END;
break; break;
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
break; break;
} }
@ -283,7 +283,7 @@ FileHandle StdioFileHandle(StdioStream stdio_stream) {
standard_handle = STD_ERROR_HANDLE; standard_handle = STD_ERROR_HANDLE;
break; break;
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return INVALID_HANDLE_VALUE; return INVALID_HANDLE_VALUE;
} }

2
util/file/output_stream_file_writer.cc
View File

@ -56,7 +56,7 @@ bool OutputStreamFileWriter::WriteIoVec(std::vector<WritableIoVec>* iovecs) {
} }
FileOffset OutputStreamFileWriter::Seek(FileOffset offset, int whence) { FileOffset OutputStreamFileWriter::Seek(FileOffset offset, int whence) {
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return -1; return -1;
} }

2
util/mac/mac_util.cc
View File

@ -207,7 +207,7 @@ int MacOSVersionNumber() {
#if __MAC_OS_X_VERSION_MIN_REQUIRED >= __MAC_10_13_4 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= __MAC_10_13_4
// On macOS 10.13.4 and later, the sysctlbyname above should have been // On macOS 10.13.4 and later, the sysctlbyname above should have been
// successful. // successful.
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return -1; return -1;
#else // DT >= 10.13.4 #else // DT >= 10.13.4
// The Darwin major version is always 4 greater than the macOS minor version // The Darwin major version is always 4 greater than the macOS minor version

2
util/mach/child_port_handshake.cc
View File

@ -256,7 +256,7 @@ mach_port_t ChildPortHandshakeServer::RunServer(
break; break;
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
break; break;
} }
} }

2
util/mach/exc_client_variants.cc
View File

@ -123,7 +123,7 @@ kern_return_t UniversalExceptionRaise(exception_behavior_t behavior,
new_state_count); new_state_count);
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
return KERN_INVALID_ARGUMENT; return KERN_INVALID_ARGUMENT;
} }
} }

2
util/mach/exception_ports.cc
View File

@ -80,7 +80,7 @@ ExceptionPorts::ExceptionPorts(TargetType target_type, mach_port_t target_port)
break; break;
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
get_exception_ports_ = nullptr; get_exception_ports_ = nullptr;
set_exception_ports_ = nullptr; set_exception_ports_ = nullptr;
target_name_ = nullptr; target_name_ = nullptr;

8
util/mach/exception_ports_test.cc
View File

@ -188,7 +188,7 @@ class TestExceptionPorts : public MachMultiprocess,
} else if (who_crashes_ == kOtherThreadCrashes) { } else if (who_crashes_ == kOtherThreadCrashes) {
expect_behavior = EXCEPTION_STATE_IDENTITY; expect_behavior = EXCEPTION_STATE_IDENTITY;
} else { } else {
NOTREACHED(); NOTREACHED_IN_MIGRATION();
expect_behavior = 0; expect_behavior = 0;
} }
@ -286,7 +286,7 @@ class TestExceptionPorts : public MachMultiprocess,
} }
default: { default: {
NOTREACHED(); NOTREACHED_IN_MIGRATION();
} }
} }
} }
@ -369,7 +369,7 @@ class TestExceptionPorts : public MachMultiprocess,
break; break;
} }
default: { default: {
NOTREACHED(); NOTREACHED_IN_MIGRATION();
} }
} }
} }
@ -520,7 +520,7 @@ class TestExceptionPorts : public MachMultiprocess,
} }
default: { default: {
NOTREACHED(); NOTREACHED_IN_MIGRATION();
} }
} }
} }

2
util/synchronization/scoped_spin_guard.h
View File

@ -92,7 +92,7 @@ class ScopedSpinGuard final {
SleepNanoseconds(kSpinGuardSleepTimeNanos); SleepNanoseconds(kSpinGuardSleepTimeNanos);
} }
NOTREACHED(); NOTREACHED_IN_MIGRATION();
} }
~ScopedSpinGuard() { ~ScopedSpinGuard() {

2
util/win/registration_protocol_win_test.cc
View File

@ -98,7 +98,7 @@ void CheckAce(PACL acl,
mask = label_ace->Mask; mask = label_ace->Mask;
} break; } break;
default: default:
NOTREACHED(); NOTREACHED_IN_MIGRATION();
break; break;
} }