Be more tidy

Change-Id: I9d2b718c36bd1dd7538241e91b984a50039068f3
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2502773
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Joshua Peraza 2020-10-27 09:14:08 -07:00
parent 640b13f3cb
commit 68b10080d2
3 changed files with 7 additions and 7 deletions

View File

@ -43,10 +43,10 @@
namespace crashpad {
namespace {
class Logger : public LogOutputStream::Delegate {
class Logger final : public LogOutputStream::Delegate {
public:
Logger() = default;
~Logger() = default;
~Logger() override = default;
#if defined(OS_ANDROID)
int Log(const char* buf) override {

View File

@ -50,7 +50,7 @@ class LogOutputStream : public OutputStreamInterface {
virtual size_t LineWidth() = 0;
};
LogOutputStream(std::unique_ptr<Delegate> delegate);
explicit LogOutputStream(std::unique_ptr<Delegate> delegate);
~LogOutputStream() override;
// OutputStreamInterface:

View File

@ -31,11 +31,11 @@ const char* kBeginGuard = "-----BEGIN CRASHPAD MINIDUMP-----";
const char* kEndGuard = "-----END CRASHPAD MINIDUMP-----";
const char* kAbortGuard = "-----ABORT CRASHPAD MINIDUMP-----";
class LogOutputStreamTestDelegate : public LogOutputStream::Delegate {
class LogOutputStreamTestDelegate final : public LogOutputStream::Delegate {
public:
LogOutputStreamTestDelegate(std::string* logging_destination)
explicit LogOutputStreamTestDelegate(std::string* logging_destination)
: logging_destination_(logging_destination) {}
~LogOutputStreamTestDelegate() = default;
~LogOutputStreamTestDelegate() override = default;
int Log(const char* buf) override {
size_t len = strnlen(buf, kLineBufferSize + 1);
@ -53,7 +53,7 @@ class LogOutputStreamTestDelegate : public LogOutputStream::Delegate {
class LogOutputStreamTest : public testing::Test {
public:
LogOutputStreamTest() : test_log_output_() {}
LogOutputStreamTest() {}
protected:
void SetUp() override {