From 658d70efb3a7d3e8a2030667225264c62be2fe27 Mon Sep 17 00:00:00 2001 From: Scott Graham Date: Wed, 4 Feb 2015 20:46:44 -0800 Subject: [PATCH] win: fix 'potentially uninitialized local variable' warnings e.g. d:\src\crashpad\crashpad\minidump\minidump_memory_writer_test.cc(347) : error C2220: warning treated as error - no 'object' file generated d:\src\crashpad\crashpad\minidump\minidump_memory_writer_test.cc(347) : warning C4701: potentially uninitialized local variable 'memory_list' used d:\src\crashpad\crashpad\minidump\minidump_memory_writer_test.cc(347) : warning C4703: potentially uninitialized local pointer variable 'memory_list' used R=mark@chromium.org BUG=crashpad:1 Review URL: https://codereview.chromium.org/899793002 --- minidump/minidump_memory_writer_test.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/minidump/minidump_memory_writer_test.cc b/minidump/minidump_memory_writer_test.cc index e758216d..1aee35de 100644 --- a/minidump/minidump_memory_writer_test.cc +++ b/minidump/minidump_memory_writer_test.cc @@ -88,7 +88,7 @@ TEST(MinidumpMemoryWriter, EmptyMemoryList) { sizeof(MINIDUMP_MEMORY_LIST), file_writer.string().size()); - const MINIDUMP_MEMORY_LIST* memory_list; + const MINIDUMP_MEMORY_LIST* memory_list = nullptr; ASSERT_NO_FATAL_FAILURE( GetMemoryListStream(file_writer.string(), &memory_list, 1)); @@ -112,7 +112,7 @@ TEST(MinidumpMemoryWriter, OneMemoryRegion) { StringFileWriter file_writer; ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer)); - const MINIDUMP_MEMORY_LIST* memory_list; + const MINIDUMP_MEMORY_LIST* memory_list = nullptr; ASSERT_NO_FATAL_FAILURE( GetMemoryListStream(file_writer.string(), &memory_list, 1)); @@ -153,7 +153,7 @@ TEST(MinidumpMemoryWriter, TwoMemoryRegions) { StringFileWriter file_writer; ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer)); - const MINIDUMP_MEMORY_LIST* memory_list; + const MINIDUMP_MEMORY_LIST* memory_list = nullptr; ASSERT_NO_FATAL_FAILURE( GetMemoryListStream(file_writer.string(), &memory_list, 1)); @@ -262,7 +262,7 @@ TEST(MinidumpMemoryWriter, ExtraMemory) { StringFileWriter file_writer; ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer)); - const MINIDUMP_MEMORY_LIST* memory_list; + const MINIDUMP_MEMORY_LIST* memory_list = nullptr; ASSERT_NO_FATAL_FAILURE( GetMemoryListStream(file_writer.string(), &memory_list, 2)); @@ -340,7 +340,7 @@ TEST(MinidumpMemoryWriter, AddFromSnapshot) { StringFileWriter file_writer; ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer)); - const MINIDUMP_MEMORY_LIST* memory_list; + const MINIDUMP_MEMORY_LIST* memory_list = nullptr; ASSERT_NO_FATAL_FAILURE( GetMemoryListStream(file_writer.string(), &memory_list, 1));