3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-27 15:32:10 +08:00
Code Issues Projects Releases Wiki Activity

win: potentially uninitialized locals in minidump_exception_writer_test.cc

Browse Source 
R=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/897863004
This commit is contained in:
Scott Graham 2015-02-05 08:45:34 -08:00
parent 8c74948ae5
commit 55cd6a2714
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
minidump/minidump_exception_writer_test.cc
View File

@ -110,14 +110,14 @@ TEST(MinidumpExceptionWriter, Minimal) {
StringFileWriter file_writer; StringFileWriter file_writer;
ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer)); ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
const MINIDUMP_EXCEPTION_STREAM* observed_exception_stream; const MINIDUMP_EXCEPTION_STREAM* observed_exception_stream = nullptr;
ASSERT_NO_FATAL_FAILURE( ASSERT_NO_FATAL_FAILURE(
GetExceptionStream(file_writer.string(), &observed_exception_stream)); GetExceptionStream(file_writer.string(), &observed_exception_stream));
MINIDUMP_EXCEPTION_STREAM expected_exception_stream = {}; MINIDUMP_EXCEPTION_STREAM expected_exception_stream = {};
expected_exception_stream.ThreadContext.DataSize = sizeof(MinidumpContextX86); expected_exception_stream.ThreadContext.DataSize = sizeof(MinidumpContextX86);
const MinidumpContextX86* observed_context; const MinidumpContextX86* observed_context = nullptr;
ASSERT_NO_FATAL_FAILURE(ExpectExceptionStream(&expected_exception_stream, ASSERT_NO_FATAL_FAILURE(ExpectExceptionStream(&expected_exception_stream,
observed_exception_stream, observed_exception_stream,
file_writer.string(), file_writer.string(),
@ -169,7 +169,7 @@ TEST(MinidumpExceptionWriter, Standard) {
StringFileWriter file_writer; StringFileWriter file_writer;
ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer)); ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
const MINIDUMP_EXCEPTION_STREAM* observed_exception_stream; const MINIDUMP_EXCEPTION_STREAM* observed_exception_stream = nullptr;
ASSERT_NO_FATAL_FAILURE( ASSERT_NO_FATAL_FAILURE(
GetExceptionStream(file_writer.string(), &observed_exception_stream)); GetExceptionStream(file_writer.string(), &observed_exception_stream));
@ -188,7 +188,7 @@ TEST(MinidumpExceptionWriter, Standard) {
} }
expected_exception_stream.ThreadContext.DataSize = sizeof(MinidumpContextX86); expected_exception_stream.ThreadContext.DataSize = sizeof(MinidumpContextX86);
const MinidumpContextX86* observed_context; const MinidumpContextX86* observed_context = nullptr;
ASSERT_NO_FATAL_FAILURE(ExpectExceptionStream(&expected_exception_stream, ASSERT_NO_FATAL_FAILURE(ExpectExceptionStream(&expected_exception_stream,
observed_exception_stream, observed_exception_stream,
file_writer.string(), file_writer.string(),
@ -241,10 +241,10 @@ TEST(MinidumpExceptionWriter, InitializeFromSnapshot) {
StringFileWriter file_writer; StringFileWriter file_writer;
ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer)); ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
const MINIDUMP_EXCEPTION_STREAM* exception; const MINIDUMP_EXCEPTION_STREAM* exception = nullptr;
ASSERT_NO_FATAL_FAILURE(GetExceptionStream(file_writer.string(), &exception)); ASSERT_NO_FATAL_FAILURE(GetExceptionStream(file_writer.string(), &exception));
const MinidumpContextX86* observed_context; const MinidumpContextX86* observed_context = nullptr;
ASSERT_NO_FATAL_FAILURE(ExpectExceptionStream(&expect_exception, ASSERT_NO_FATAL_FAILURE(ExpectExceptionStream(&expect_exception,
exception, exception,
file_writer.string(), file_writer.string(),