From 45993a6959341ab7f61e7c8e751f53eddf1e5622 Mon Sep 17 00:00:00 2001 From: Mark Mentovai Date: Thu, 30 Oct 2014 14:51:40 -0400 Subject: [PATCH] minidump: Fix InitializeFromSnapshot() comments for module lists. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These classes don’t really have “mutators” other than their singular AddModule() methods, and the documentation is clearer when revised in this way. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/691853002 --- minidump/minidump_module_crashpad_info_writer.h | 6 +++--- minidump/minidump_module_writer.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/minidump/minidump_module_crashpad_info_writer.h b/minidump/minidump_module_crashpad_info_writer.h index e9bc2792..2db42a73 100644 --- a/minidump/minidump_module_crashpad_info_writer.h +++ b/minidump/minidump_module_crashpad_info_writer.h @@ -113,9 +113,9 @@ class MinidumpModuleCrashpadInfoListWriter final //! //! \param[in] module_snapshots The module snapshots to use as source data. //! - //! \note Valid in #kStateMutable. No mutator methods may be called before - //! this method, and it is not normally necessary to call any mutator - //! methods after this method. + //! \note Valid in #kStateMutable. AddModule() may not be called before this + //! method, and it is not normally necessary to call AddModule() after + //! this method. void InitializeFromSnapshot( const std::vector& module_snapshots); diff --git a/minidump/minidump_module_writer.h b/minidump/minidump_module_writer.h index 9fb10c2c..6dc0319d 100644 --- a/minidump/minidump_module_writer.h +++ b/minidump/minidump_module_writer.h @@ -320,9 +320,9 @@ class MinidumpModuleListWriter final : public internal::MinidumpStreamWriter { //! //! \param[in] module_snapshots The module snapshots to use as source data. //! - //! \note Valid in #kStateMutable. No mutator methods may be called before - //! this method, and it is not normally necessary to call any mutator - //! methods after this method. + //! \note Valid in #kStateMutable. AddModule() may not be called before this + //! this method, and it is not normally necessary to call AddModule() + //! after this method. void InitializeFromSnapshot( const std::vector& module_snapshots);