3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-17 08:33:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

minidump: Annotate existing virtual destructors that override a base

Browse Source 
class virtual destructor with “override”.

TEST=minidump_test MinidumpContextWriter.*:MinidumpModuleWriter.*
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/675783006
This commit is contained in:
Mark Mentovai 2014-10-23 18:42:26 -04:00
parent dcdbd2098f
commit 44a839614b
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
minidump/minidump_context_writer.h
View File

@ -51,7 +51,7 @@ class MinidumpContextWriter : public internal::MinidumpWritable {
class MinidumpContextX86Writer final : public MinidumpContextWriter { class MinidumpContextX86Writer final : public MinidumpContextWriter {
public: public:
MinidumpContextX86Writer(); MinidumpContextX86Writer();
virtual ~MinidumpContextX86Writer(); ~MinidumpContextX86Writer() override;
//! \brief Returns a pointer to the context structure that this object will //! \brief Returns a pointer to the context structure that this object will
//! write. //! write.
@ -82,7 +82,7 @@ class MinidumpContextX86Writer final : public MinidumpContextWriter {
class MinidumpContextAMD64Writer final : public MinidumpContextWriter { class MinidumpContextAMD64Writer final : public MinidumpContextWriter {
public: public:
MinidumpContextAMD64Writer(); MinidumpContextAMD64Writer();
virtual ~MinidumpContextAMD64Writer(); ~MinidumpContextAMD64Writer() override;
//! \brief Returns a pointer to the context structure that this object will //! \brief Returns a pointer to the context structure that this object will
//! write. //! write.

6
minidump/minidump_module_writer.h
View File

@ -63,7 +63,7 @@ class MinidumpModuleCodeViewRecordPDBLinkWriter
protected: protected:
MinidumpModuleCodeViewRecordPDBLinkWriter(); MinidumpModuleCodeViewRecordPDBLinkWriter();
virtual ~MinidumpModuleCodeViewRecordPDBLinkWriter(); ~MinidumpModuleCodeViewRecordPDBLinkWriter() override;
// MinidumpWritable: // MinidumpWritable:
size_t SizeOfObject() override; size_t SizeOfObject() override;
@ -96,7 +96,7 @@ class MinidumpModuleCodeViewRecordPDB20Writer final
: internal::MinidumpModuleCodeViewRecordPDBLinkWriter< : internal::MinidumpModuleCodeViewRecordPDBLinkWriter<
MinidumpModuleCodeViewRecordPDB20>() {} MinidumpModuleCodeViewRecordPDB20>() {}
virtual ~MinidumpModuleCodeViewRecordPDB20Writer(); ~MinidumpModuleCodeViewRecordPDB20Writer() override;
//! \brief Sets MinidumpModuleCodeViewRecordPDB20::timestamp and //! \brief Sets MinidumpModuleCodeViewRecordPDB20::timestamp and
//! MinidumpModuleCodeViewRecordPDB20::age. //! MinidumpModuleCodeViewRecordPDB20::age.
@ -116,7 +116,7 @@ class MinidumpModuleCodeViewRecordPDB70Writer final
: internal::MinidumpModuleCodeViewRecordPDBLinkWriter< : internal::MinidumpModuleCodeViewRecordPDBLinkWriter<
MinidumpModuleCodeViewRecordPDB70>() {} MinidumpModuleCodeViewRecordPDB70>() {}
virtual ~MinidumpModuleCodeViewRecordPDB70Writer(); ~MinidumpModuleCodeViewRecordPDB70Writer() override;
//! \brief Sets MinidumpModuleCodeViewRecordPDB70::uuid and //! \brief Sets MinidumpModuleCodeViewRecordPDB70::uuid and
//! MinidumpModuleCodeViewRecordPDB70::age. //! MinidumpModuleCodeViewRecordPDB70::age.