3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-04-03 02:25:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[fuchsia] Route diagnostics dictionary to Chromium"

Browse Source 
This reverts commit 21a20ef8adf3949de8dd65758a16f83aab344b3c.

Reason for revert: b/376922343

Original change's description:
> [fuchsia] Route diagnostics dictionary to Chromium
>
> Update the CML to route from parent/diagnostics instead of from parent.
> LogSink and InspectSink will be routed through diagnostics dictionaries
> in the future, and this change is needed in order to allow for a
> soft-transition to dictionary capabilities rather than directly from
> parent.
>
> It's copied from https://crrev.com/c/6354008 to Crashpad. This change
> needs to go to crashpad first before merging to Chromium.
>
> Bug: 376922343
> Change-Id: I76d388827c3a560b1f9dd88168e60458fedda7b8
> Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/6388762
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Zijie He <zijiehe@google.com>

Bug: 376922343
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I2124836b305ac394b97cb6fb636d24bed4c7572d
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/6391935
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Zijie He <zijiehe@google.com>
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Brian Bosak 2025-03-25 09:37:49 -07:00 committed by Crashpad LUCI CQ
parent 279de5e3e8
commit 421b4a975a
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test/fuchsia_crashpad_tests.cml
View File

@ -4,6 +4,8 @@
{
include: [
"//src/sys/test_runners/elf/ambient_exec.shard.cml",
"inspect/offer.shard.cml",
"syslog/client.shard.cml",
],
program: {
binary: "bin/crashpad_tests",
@ -34,10 +36,6 @@
protocol: [ "fuchsia.posix.socket.Provider" ],
from: "#netstack",
},
{
protocol: [ "fuchsia.logger.LogSink" ],
from: "parent/diagnostics",
},
{
protocol: [ "fuchsia.process.Launcher" ],
},
@ -52,15 +50,6 @@
from: "#dns_resolver",
to: "#crashpad_test",
},
{
dictionary: "diagnostics",
from: "parent",
to: [
"#dns_resolver",
"#netstack",
"#crashpad_test",
]
},
{
protocol: "fuchsia.net.routes.State",
from: "#netstack",