3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-27 15:32:10 +08:00
Code Issues Projects Releases Wiki Activity

ios: Use PlatformTest instead of testing::Test

Browse Source 
When trying to update Chromium's copy of crashpad I got this error
message:

Banned functions were used.
    third_party\crashpad\crashpad\client\crashpad_client_ios_test.mm:33:
      testing::Test should not be used in Objective-C++ code as it does
      not drain the autorelease pool at the end of the test. Use
      PlatformTest instead.

So, I'm fixing the code as requested.

The change was introduced in crrev.com/c/3418581

Change-Id: I4888febbd41b6365d9bde5ad062565770496243f
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3459403
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
This commit is contained in:
Bruce Dawson 2022-02-12 13:36:12 -10:00 committed by Crashpad LUCI CQ
parent 0830895880
commit 4112c11b77
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/crashpad_client_ios_test.mm
View File

@ -30,7 +30,7 @@ namespace crashpad {
namespace test {
namespace {
class CrashpadIOSClient : public testing::Test {
class CrashpadIOSClient : public PlatformTest {
protected:
// testing::Test: