From 4094c2628d330181a4dd41883aba9a49816b379f Mon Sep 17 00:00:00 2001 From: Joshua Peraza Date: Thu, 15 Feb 2018 12:20:48 -0800 Subject: [PATCH] Address review comments for 8d0d999 Change-Id: I697a0768d992ffa4ee35dded191960e4adbd69cf Reviewed-on: https://chromium-review.googlesource.com/922728 Reviewed-by: Robert Sesek Commit-Queue: Joshua Peraza --- client/crash_report_database_generic.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/client/crash_report_database_generic.cc b/client/crash_report_database_generic.cc index 5091d1b8..fc1d04e0 100644 --- a/client/crash_report_database_generic.cc +++ b/client/crash_report_database_generic.cc @@ -156,6 +156,8 @@ class ScopedLockFile { private: ScopedRemoveFile lock_file_; + + DISALLOW_COPY_AND_ASSIGN(ScopedLockFile); }; } // namespace @@ -273,8 +275,8 @@ bool CrashReportDatabaseGeneric::Initialize(const base::FilePath& path, return false; } - for (size_t i = 0; i < arraysize(kReportDirectories); ++i) { - if (!LoggingCreateDirectory(base_dir_.Append(kReportDirectories[i]), + for (const base::FilePath::CharType* subdir : kReportDirectories) { + if (!LoggingCreateDirectory(base_dir_.Append(subdir), FilePermissions::kOwnerOnly, true)) { return false;