3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-10 06:36:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use ExcServerSuccessfulReturnValue() in one spot that was missed in

Browse Source 
57eb311528f2.

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/575243002
This commit is contained in:
Mark Mentovai 2014-09-17 18:09:05 -04:00
parent b4fe6dfae0
commit 3f2ba965f5
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
util/mach/exception_ports_test.cc
View File

@ -198,17 +198,7 @@ class TestExceptionPorts : public UniversalMachExcServer,
SetExpectedChildTermination(kTerminationSignal, signal); SetExpectedChildTermination(kTerminationSignal, signal);
} }
// Even for an EXC_CRASH handler, returning KERN_SUCCESS with a return ExcServerSuccessfulReturnValue(behavior, false);
// state-carrying reply will cause the kernel to try to set a new thread
// state, leading to a perceptible waste of time. Returning
// MACH_RCV_PORT_DIED is the only way to suppress this behavior while also
// preventing the kernel from looking for another (host-level) EXC_CRASH
// handler. See 10.9.4 xnu-2422.110.17/osfmk/kern/exception.c
// exception_triage().
exception_behavior_t basic_behavior = behavior & ~MACH_EXCEPTION_CODES;
bool has_state = basic_behavior == EXCEPTION_STATE ||
basic_behavior == EXCEPTION_STATE_IDENTITY;
return has_state ? MACH_RCV_PORT_DIED : KERN_SUCCESS;
} }
private: private: