From 3df478b96d2f243be2b1832413c4325d4cb5e608 Mon Sep 17 00:00:00 2001 From: Avi Drissman Date: Wed, 26 Jul 2023 16:46:52 -0400 Subject: [PATCH] Remove redundant ARC configuration in Crashpad ARC is now enabled by default in Chromium, so enabling it explicitly in Crashpad is redundant. Bug: chromium:733237 Change-Id: I59dd863c0f8e7e16e88b6daccc5f900829c0cec5 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4721646 Reviewed-by: Mark Mentovai Commit-Queue: Mark Mentovai Commit-Queue: Avi Drissman --- build/BUILD.gn | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/build/BUILD.gn b/build/BUILD.gn index 3763d2e1..7d7e08bb 100644 --- a/build/BUILD.gn +++ b/build/BUILD.gn @@ -53,9 +53,10 @@ config("crashpad_fuzzer_flags") { if (crashpad_is_apple) { group("apple_enable_arc") { - if (crashpad_is_in_chromium) { - public_configs = [ "//build/config/compiler:enable_arc" ] - } else if (crashpad_is_standalone) { + # If `crashpad_is_in_chromium`, then because Chromium enables ARC + # compilation by default, no special configuration is needed. + + if (crashpad_is_standalone) { public_configs = [ "//third_party/mini_chromium/mini_chromium/build/config:apple_enable_arc" ] } }