3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-10 06:36:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

[fuchsia] clean up exception handler overload with exception port

Browse Source 
* Fuchsia migrated its call site to the overload without the exception
port as the resume from exception is done outside of Crashpad now
* the overload with the koids and the exception port is kept for the
standalone Crashpad exception server and handler

Bug: fuchsia:ZX-4031
Change-Id: Iec220e2c9bb7b14bdb37b6c008b4fa354dba241d
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1659943
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
This commit is contained in:
Francois Rousseau 2019-06-14 09:17:27 -07:00 committed by Commit Bot
parent e5abe92b2e
commit 3a6f57178a
2 changed files with 3 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
handler/fuchsia/crash_report_exception_handler.cc
View File

@ -90,23 +90,13 @@ bool CrashReportExceptionHandler::HandleException(
return false; return false;
} }
return HandleExceptionHandles(
process, thread, exception_port, local_report_id);
}
bool CrashReportExceptionHandler::HandleExceptionHandles(
const zx::process& process,
const zx::thread& thread,
const zx::unowned_port& exception_port,
UUID* local_report_id) {
ScopedThreadResumeAfterException resume(thread, exception_port); ScopedThreadResumeAfterException resume(thread, exception_port);
return HandleException(process, thread, local_report_id); return HandleException(process, thread, local_report_id);
} }
bool CrashReportExceptionHandler::HandleException( bool CrashReportExceptionHandler::HandleException(const zx::process& process,
const zx::process& process, const zx::thread& thread,
const zx::thread& thread, UUID* local_report_id) {
UUID* local_report_id) {
ScopedTaskSuspend suspend(process); ScopedTaskSuspend suspend(process);
ProcessSnapshotFuchsia process_snapshot; ProcessSnapshotFuchsia process_snapshot;

24
handler/fuchsia/crash_report_exception_handler.h
View File

@ -84,35 +84,11 @@ class CrashReportExceptionHandler {
//! \param[out] local_report_id The unique identifier for the report created //! \param[out] local_report_id The unique identifier for the report created
//! in the local report database. Optional. //! in the local report database. Optional.
//! \return `true` on success, or `false` with an error logged. //! \return `true` on success, or `false` with an error logged.
//!
//! \deprecated Use the port-less version instead and have the caller resume.
bool HandleException(uint64_t process_id, bool HandleException(uint64_t process_id,
uint64_t thread_id, uint64_t thread_id,
const zx::unowned_port& exception_port, const zx::unowned_port& exception_port,
UUID* local_report_id = nullptr); UUID* local_report_id = nullptr);
//! \brief Called when the exception handler server has caught an exception
//! and wants a crash dump to be taken.
//!
//! This function is expected to call `zx_task_resume_from_exception()` in
//! order to complete handling of the exception.
//!
//! \param[in] process The handle to the process which sustained the
//! exception.
//! \param[in] thread The handle to the thread of \a process which sustained
//! the exception.
//! \param[in] exception_port The exception port on which the exception was
//! serviced. This can be used to resume the excepting thread.
//! \param[out] local_report_id The unique identifier for the report created
//! in the local report database. Optional.
//! \return `true` on success, or `false` with an error logged.
//!
//! \deprecated Use the port-less #HandleException instead.
bool HandleExceptionHandles(const zx::process& process,
const zx::thread& thread,
const zx::unowned_port& exception_port,
UUID* local_report_id = nullptr);
//! \brief Called when the exception handler server has caught an exception //! \brief Called when the exception handler server has caught an exception
//! and wants a crash dump to be taken. //! and wants a crash dump to be taken.
//! //!