From 2db30e035a0084493ef44bdcc5887a8147f74add Mon Sep 17 00:00:00 2001 From: Mark Mentovai Date: Wed, 1 Nov 2017 20:27:19 -0400 Subject: [PATCH] win: Fix Clang -Wsign-compare warnings in new test code This test code appeared in 9609b7471676, and was missed by the similar warning cleanup of a51e912004a6, which was developed in parallel. Bug: crashpad:192, chromium:779790 Change-Id: I4ed88ed025e4be4410c98ceaca395218f00007be Reviewed-on: https://chromium-review.googlesource.com/750024 Reviewed-by: Robert Sesek --- snapshot/win/pe_image_annotations_reader_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snapshot/win/pe_image_annotations_reader_test.cc b/snapshot/win/pe_image_annotations_reader_test.cc index f576394c..e1026008 100644 --- a/snapshot/win/pe_image_annotations_reader_test.cc +++ b/snapshot/win/pe_image_annotations_reader_test.cc @@ -102,7 +102,7 @@ void TestAnnotationsOnCrash(TestType type, EXPECT_EQ(all_annotations_simple_map["#TEST# empty_value"], ""); // Verify the typed annotation objects. - EXPECT_EQ(all_annotation_objects.size(), 3); + EXPECT_EQ(all_annotation_objects.size(), 3u); bool saw_same_name_3 = false, saw_same_name_4 = false; for (const auto& annotation : all_annotation_objects) { EXPECT_EQ(annotation.type,