3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-27 23:41:02 +08:00
Code Issues Projects Releases Wiki Activity

win: Locally disable allocation alignment warning

Browse Source 
A (somewhat cursory) inspection leads me to believe that there's
no particular alignment requirements for this object at this location,
so this warning can be ignored.

d:\src\crashpad\crashpad\minidump\minidump_context_writer.cc(43) : error C2220: warning treated as error - no 'object' file generated
d:\src\crashpad\crashpad\minidump\minidump_context_writer.cc(43) : warning C4316: 'crashpad::MinidumpContextAMD64Writer' : object allocated on the heap may not be aligned 16

R=mark@chromium.org
BUG=crashpad:1

Review URL: https://codereview.chromium.org/893393002
This commit is contained in:
Scott Graham 2015-02-04 17:36:38 -08:00
parent 74a34e9c4b
commit 2b46aaabda
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
minidump/minidump_context_writer.cc
View File

@ -39,8 +39,16 @@ scoped_ptr<MinidumpContextWriter> MinidumpContextWriter::CreateFromSnapshot(
}
case kCPUArchitectureX86_64: {
#if defined(COMPILER_MSVC) && defined(ARCH_CPU_X86)
#pragma warning(push)
#pragma warning(disable: 4316) // Object allocated on the heap may not be 16
// byte aligned.
#endif
MinidumpContextAMD64Writer* context_amd64 =
new MinidumpContextAMD64Writer();
#if defined(COMPILER_MSVC) && defined(ARCH_CPU_X86)
#pragma warning(pop)
#endif
context.reset(context_amd64);
context_amd64->InitializeFromSnapshot(context_snapshot->x86_64);
break;