From 20d6dee0374e9f42616630f75c1afe6cf998f183 Mon Sep 17 00:00:00 2001 From: Justin Cohen Date: Fri, 25 Mar 2022 22:16:27 -0400 Subject: [PATCH] Roll crashpad/third_party/googletest/googletest/ 5bcd8e3bb..af29db7ec (148 commits) https://chromium.googlesource.com/external/github.com/google/googletest/+log/5bcd8e3bb929..af29db7ec28d $ git log 5bcd8e3bb..af29db7ec --date=short --no-merges --format='%ad %ae %s' 2022-03-23 absl-team Address deprecation warning surfaced by Github presubmit tests 2022-03-23 mattias.ellert Split gmock-matchers_test into 4 smaller test #3653 2022-03-22 absl-team Only print disabled test banner if the test matches gtest_filter 2022-03-21 absl-team Clarify public access on gmock examples. 2022-03-18 bmesser Remove sanity as it is offensive to neurodiverse individuals. 2022-03-15 absl-team Running clang-format over all of GoogleTest 2022-03-14 dinor Remove references to deleted script gen_gtest_pred_impl.py 2022-03-08 absl-team Mark ACTION_Pn()-generated functions as must-use-result, adding non-compilation tests. 2022-03-08 sobik.szymon Add myself to contributors 2022-03-08 sobik.szymon Adjust documentation regarding xml and json source file location otput. 2022-03-08 sobik.szymon Adjust xml and json unit tests to test for source file and line location. 2022-03-08 sobik.szymon Add support for testing of xml and json output of source file and line location 2022-03-08 sobik.szymon Output source file path and line number in xml and json files. 2022-02-17 dmauro Update GCC/Clang Linux tests to use Bazel 5.0.0 2022-02-14 absl-team Address conversion warning by explicitly casting to size_t 2022-02-09 absl-team Add a 3-arg overload for ResultOf() matcher that takes a description string for better error messages. 2022-02-05 hgsilverman Apply requested changes by using std::inserter with move. 2022-02-05 noiseless-ak Fix gtest-help-test failure on OpenBSD 2022-02-01 absl-team GetCurrentOsStackTraceExceptTop (both the method of UnitTestImpl and the wrapper function in gtest.cc) rely on the fact that the inner call is not getting optimized. This CL annotates them with the appropriate attributes. 2022-01-29 hgsilverman Do constant time matching for exact match filters. 2022-01-28 dmauro Finish some missed pieces of the TestCase to TestSuite Migration 2022-01-26 dinor Change `ReturnArg` to use perfect forwarding of arguments (#3733) 2022-01-25 melroy Let me give a change to try it again - updating to latest version 2022-01-24 absl-team Make recreate_environments_when_repeating=false the default. 2022-01-19 absl-team Factor out AssertionResult into dedicated gtest-assertion-result header + implementation files to prevent cyclic includes between gtest.h and gtest_pred_impl.h 2022-01-18 absl-team Consistently apply IWYU pragmas across googletest and googlemock headers 2022-01-14 dinor Fix reference to source file in gmock FAQ 2022-01-14 dmauro Update test Docker image to GCC 11.2, Clang 14 (prerelease), CMake 3.22.1, and Bazel 4.2.2 2022-01-13 ayush854032 FIX #2174 -- remove `DEBUG_POSTFIX` 2022-01-12 absl-team Fix run-on sentence 2022-01-06 hgsilverman Fix a typo in comments. 2021-12-22 hgsilverman Use normal for loop instead of accumulate. 2021-12-17 hgsilverman Improve code readablity. 2021-12-17 hgsilverman Apply requested changes to preserve old behavior. 2021-12-03 hgsilverman Reimplement MatchesFilter with new interfaces. 2021-11-23 hgsilverman Apply requested changes. 2021-10-17 hgsilverman Get rid of redundant filter matching code 2021-10-17 hgsilverman Add comments describing the behavior of filters 2021-10-17 hgsilverman Process filter string once instead of per test 2022-01-05 bsilver16384 Remove another GTEST_DISALLOW_ASSIGN_ that crept in 2022-01-05 73706994+jjfvanderpol Set CMake Policy CMP0077 to NEW 2022-01-04 4789010+ramkumar-kr Update example to reflect the tests below 2022-01-01 ayush854032 FIX #3719 -- Fix `clang` conversion warnings 2021-12-27 absl-team Include the param names in the generated description of the MATCHER_P matchers. 2021-12-22 absl-team Clarify "package" means "Bazel package", and promote `testonly=True` rather than `testing` sub-directory. 2021-12-22 dmauro Makes the Python imports consistently use full paths from the repository root, unifying the behavior between Bazel and CMake 2021-12-21 dmauro Makes TestForDeathTest.CRTDebugDeath only run when _DEBUG is defined 2021-12-21 philip.j.m link to regex on qnx in cmake 2021-12-15 dinor Release tests for UnitTestOptions::MatchesFilter 2021-12-07 absl-team Add NOLINT to address modernize-use-trailing-return-type in TEST_F uses (...) 2021-09-14 absl-team Googletest export 2021-09-15 761129+derekmauro Revert grammatically incorrect change 2021-09-10 absl-team Googletest export 2021-08-20 absl-team Googletest export 2021-08-20 absl-team Googletest export 2021-08-19 invalid_ms_user Simplify example code with c++11 2021-08-12 absl-team Googletest export 2021-08-10 dmauro Googletest export 2021-08-09 dmauro Googletest export 2021-08-10 akashkumarsingh11032001 add a missing 'a' 2021-08-10 akashkumarsingh11032001 Create CONTRIBUTING.md 2021-08-06 absl-team Internal change 2021-08-06 victordk13 Format test properties in xml printer 2021-08-05 iamberkeyavas typo fix gmock_cook_book 2021-08-03 absl-team Googletest export 2021-08-03 absl-team Googletest export 2021-08-02 absl-team Googletest export 2021-07-29 absl-team Googletest export 2021-07-29 otnaiud Typo, double "the" 2021-07-28 absl-team Internal change 2021-07-24 slowy.arfy fix: typo codespelling comment 2021-07-22 absl-team Googletest export 2021-07-21 absl-team Googletest export 2021-07-19 dmauro Googletest export 2021-07-14 761129+derekmauro Fix location of GOOGLETEST_CM0011 marker 2021-07-08 absl-team Googletest export 2021-07-08 absl-team Googletest export 2021-07-07 absl-team Googletest export 2021-07-02 absl-team Googletest export 2021-07-02 absl-team Googletest export 2021-07-07 manuel Link -lregex on QNX 2021-07-01 jeremy.nimmer Use GTEST_DONT_DEFINE_TEST_F to guard TEST_F 2021-06-29 absl-team Googletest export 2021-06-28 absl-team Googletest export 2021-06-28 absl-team Googletest export 2021-06-25 manuel Don't link pthread on QNX 2021-06-23 alex Fix EXPECT_DEATH() and ASSERT_DEATH() triggering -Wcovered-switch-default 2021-06-18 dmauro Googletest export 2021-06-03 pochkaenkov feat: make a matcher ElementsAreArray applicable for std ranges 2021-06-13 hyuk.myeong fix typos 2021-06-11 absl-team Googletest export 2021-06-10 absl-team Googletest export 2021-06-09 absl-team Googletest export 2021-06-09 dmauro Googletest export 2021-06-09 absl-team Googletest export 2021-06-09 absl-team Googletest export 2021-06-08 absl-team Googletest export 2020-12-30 mattias.ellert Port to GNU/Hurd 2020-12-29 julien.jemine Using auto instead of container::const_iterator 2020-12-24 georgthegreat Use proper feature test macro to test if library supports char8_t Created with: roll-dep crashpad/third_party/googletest/googletest Change-Id: I34a2d997498b73a17ee9ee71db45081f2ebab9a4 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3553800 Reviewed-by: Mark Mentovai Commit-Queue: Justin Cohen --- DEPS | 2 +- third_party/googletest/BUILD.gn | 34 +++++++++++++++++---------------- 2 files changed, 19 insertions(+), 17 deletions(-) diff --git a/DEPS b/DEPS index 6c4cd0c1..2f8a2e64 100644 --- a/DEPS +++ b/DEPS @@ -33,7 +33,7 @@ deps = { }, 'crashpad/third_party/googletest/googletest': Var('chromium_git') + '/external/github.com/google/googletest@' + - '5bcd8e3bb929714e031a542d303f818e5a5af45d', + 'af29db7ec28d6df1c7f0f745186884091e602e07', 'crashpad/third_party/lss/lss': Var('chromium_git') + '/linux-syscall-support.git@' + 'e1e7b0ad8ee99a875b272c8e33e308472e897660', diff --git a/third_party/googletest/BUILD.gn b/third_party/googletest/BUILD.gn index 6d98a38b..2cfb5089 100644 --- a/third_party/googletest/BUILD.gn +++ b/third_party/googletest/BUILD.gn @@ -55,6 +55,7 @@ if (crashpad_is_in_chromium) { static_library("googletest") { testonly = true sources = [ + "$googletest_dir/googletest/include/gtest/gtest-assertion-result.h", "$googletest_dir/googletest/include/gtest/gtest-death-test.h", "$googletest_dir/googletest/include/gtest/gtest-matchers.h", "$googletest_dir/googletest/include/gtest/gtest-message.h", @@ -78,6 +79,7 @@ if (crashpad_is_in_chromium) { "$googletest_dir/googletest/include/gtest/internal/gtest-string.h", "$googletest_dir/googletest/include/gtest/internal/gtest-type-util.h", "$googletest_dir/googletest/src/gtest-all.cc", + "$googletest_dir/googletest/src/gtest-assertion-result.cc", "$googletest_dir/googletest/src/gtest-death-test.cc", "$googletest_dir/googletest/src/gtest-filepath.cc", "$googletest_dir/googletest/src/gtest-internal-inl.h", @@ -176,14 +178,6 @@ if (crashpad_is_in_chromium) { configs -= [ "$mini_chromium_dir/build/config:Wexit_time_destructors" ] configs += [ ":googletest_private_config" ] deps = [ ":googletest" ] - - if (crashpad_is_clang) { - cflags_cc = [ - # For googletest/googlemock/test/gmock-matchers_test.cc’s - # Unstreamable::value_. - "-Wno-unused-private-field", - ] - } } test("gtest_premature_exit_test") { @@ -299,7 +293,11 @@ if (crashpad_is_in_chromium) { "$googletest_dir/googlemock/test/gmock-cardinalities_test.cc", "$googletest_dir/googlemock/test/gmock-function-mocker_test.cc", "$googletest_dir/googlemock/test/gmock-internal-utils_test.cc", - "$googletest_dir/googlemock/test/gmock-matchers_test.cc", + "$googletest_dir/googlemock/test/gmock-matchers-arithmetic_test.cc", + "$googletest_dir/googlemock/test/gmock-matchers-comparisons_test.cc", + "$googletest_dir/googlemock/test/gmock-matchers-containers_test.cc", + "$googletest_dir/googlemock/test/gmock-matchers-misc_test.cc", + "$googletest_dir/googlemock/test/gmock-matchers_test.h", "$googletest_dir/googlemock/test/gmock-more-actions_test.cc", "$googletest_dir/googlemock/test/gmock-nice-strict_test.cc", "$googletest_dir/googlemock/test/gmock-port_test.cc", @@ -324,17 +322,21 @@ if (crashpad_is_in_chromium) { # always use the override modifier with MOCK_METHOD. "-Wno-inconsistent-missing-override", - # For googletest/googlemock/test/gmock-matchers_test.cc’s - # testing::googlemock_matchers_test::Unprintable::c_ and deprecated - # std::iterator. - "-Wno-unused-private-field", - "-Wno-deprecated-declarations", + # For googlemock/test/gmock-matchers-misc_test.cc comparison of + # integers of different signs. + "-Wno-sign-compare", ] } if (crashpad_is_win) { - # TODO: Correct SDK in vc\tools\msvc\14.14.26428\include\functional - cflags = [ "/wd4789" ] # VAR of size N bytes will be overrun + cflags = [ + # TODO: Correct SDK in vc\tools\msvc\14.14.26428\include\functional + "/wd4789", # VAR of size N bytes will be overrun + + # For googlemock/test/gmock-matchers-misc_test.cc comparison of + # integers of different signs. + "/wd4018", + ] } }