3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-26 23:01:05 +08:00
Code Issues Projects Releases Wiki Activity

[fuchsia] actually clean up lock file in release mode

Browse Source 
* the call to LoggingRemoveFile wrapped ina DCHECK is actually only executed in debug mode :-(
* found the issue using zxdb!

Bug: fuchsia:DX-344
Bug: crashpad:217, crashpad:196
Change-Id: I5332a17ccffd94b9bad8c61831adb797bd53a13d
Tested:`crasher` on device
Reviewed-on: https://chromium-review.googlesource.com/c/1364452
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Francois Rousseau <frousseau@google.com>
This commit is contained in:
Francois Rousseau 2018-12-05 19:58:48 -08:00 committed by Commit Bot
parent 109bece2c3
commit 1a9209b581
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
client/settings.cc
View File

@ -63,7 +63,8 @@ void Settings::ScopedLockedFileHandle::Destroy() {
CheckedCloseFile(handle_);
}
if (!lockfile_path_.empty()) {
DCHECK(LoggingRemoveFile(lockfile_path_));
const bool success = LoggingRemoveFile(lockfile_path_);
DCHECK(success);
}
}