Remove/replace unnecessary includes of logging.h

If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.

This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.

Bug: chromium:1031540
Change-Id: Ia46806bd95fe498bcf3cf6d2c13ffa4081678043
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2255361
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
This commit is contained in:
Hans Wennborg 2020-06-22 11:14:31 +02:00 committed by Commit Bot
parent 032f1aecc2
commit 161bfed35a
86 changed files with 64 additions and 88 deletions

View File

@ -22,7 +22,7 @@
#include <string.h>
#include <sys/types.h>
#include "base/logging.h"
#include "base/check.h"
#include "base/macros.h"
#include "base/numerics/safe_conversions.h"
#include "base/strings/string_piece.h"

View File

@ -14,7 +14,7 @@
#include "client/annotation_list.h"
#include "base/logging.h"
#include "base/check_op.h"
#include "client/crashpad_info.h"
namespace crashpad {

View File

@ -14,7 +14,6 @@
#include "client/crash_report_database.h"
#include "base/logging.h"
#include "build/build_config.h"
namespace crashpad {

View File

@ -20,7 +20,8 @@
#include <sys/types.h>
#include <unistd.h>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/notreached.h"
#include "client/annotation.h"
#include "client/annotation_list.h"
#include "client/crash_report_database.h"

View File

@ -17,7 +17,6 @@
#include <vector>
#include "base/files/file_path.h"
#include "base/logging.h"
#include "gtest/gtest.h"
#include "test/test_paths.h"
#include "test/scoped_temp_dir.h"

View File

@ -14,7 +14,6 @@
#include "client/simple_address_range_bag.h"
#include "base/logging.h"
#include "gtest/gtest.h"
#include "test/gtest_death.h"

View File

@ -21,7 +21,7 @@
#include <algorithm>
#include <type_traits>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/macros.h"
#include "base/strings/string_piece.h"
#include "util/misc/implicit_cast.h"

View File

@ -14,7 +14,7 @@
#include "client/simple_string_dictionary.h"
#include "base/logging.h"
#include "base/check_op.h"
#include "gtest/gtest.h"
#include "test/gtest_death.h"

View File

@ -17,7 +17,6 @@
#include <sys/types.h>
#include <unistd.h>
#include "base/logging.h"
#include "build/build_config.h"
#include "gtest/gtest.h"
#include "snapshot/linux/process_snapshot_linux.h"

View File

@ -16,7 +16,7 @@
#include <utility>
#include "base/logging.h"
#include "base/check_op.h"
#include "minidump/minidump_module_crashpad_info_writer.h"
#include "minidump/minidump_simple_string_dictionary_writer.h"
#include "snapshot/process_snapshot.h"

View File

@ -16,7 +16,7 @@
#include <utility>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/numerics/safe_conversions.h"
#include "minidump/minidump_context_writer.h"
#include "snapshot/exception_snapshot.h"

View File

@ -14,7 +14,7 @@
#include "minidump/minidump_memory_info_writer.h"
#include "base/logging.h"
#include "base/check_op.h"
#include "snapshot/memory_map_region_snapshot.h"
#include "util/file/file_writer.h"

View File

@ -14,7 +14,7 @@
#include "minidump/minidump_stream_writer.h"
#include "base/logging.h"
#include "base/check_op.h"
namespace crashpad {
namespace internal {

View File

@ -16,7 +16,8 @@
#include <string.h>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/notreached.h"
#include "base/stl_util.h"
#include "minidump/minidump_string_writer.h"
#include "snapshot/system_snapshot.h"

View File

@ -18,7 +18,7 @@
#include <set>
#include <utility>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/numerics/safe_conversions.h"
#include "snapshot/thread_snapshot.h"

View File

@ -17,7 +17,7 @@
#include <stddef.h>
#include <string.h>
#include "base/logging.h"
#include "base/notreached.h"
#include "base/stl_util.h"
#include "util/misc/arraysize.h"
#include "util/misc/implicit_cast.h"

View File

@ -20,7 +20,6 @@
#include <algorithm>
#include "base/logging.h"
#include "build/build_config.h"
#include "client/annotation.h"
#include "client/annotation_list.h"

View File

@ -18,7 +18,6 @@
#include <link.h>
#include <unistd.h>
#include "base/logging.h"
#include "build/build_config.h"
#include "gtest/gtest.h"
#include "test/multiprocess_exec.h"

View File

@ -16,7 +16,6 @@
#include <elf.h>
#include "base/logging.h"
#include "snapshot/elf/elf_image_reader.h"
namespace crashpad {

View File

@ -14,7 +14,7 @@
#include "snapshot/fuchsia/memory_map_region_snapshot_fuchsia.h"
#include "base/logging.h"
#include "base/check_op.h"
#include "base/stl_util.h"
namespace crashpad {

View File

@ -16,8 +16,9 @@
#include <zircon/syscalls.h>
#include "base/check_op.h"
#include "base/fuchsia/fuchsia_logging.h"
#include "base/logging.h"
#include "base/notreached.h"
#include "base/numerics/safe_conversions.h"
#include "base/strings/stringprintf.h"
#include "snapshot/posix/timezone.h"

View File

@ -14,7 +14,7 @@
#include "snapshot/fuchsia/thread_snapshot_fuchsia.h"
#include "base/logging.h"
#include "base/check_op.h"
#include "snapshot/fuchsia/cpu_context_fuchsia.h"
namespace crashpad {

View File

@ -26,7 +26,7 @@
#include <map>
#include <utility>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/mac/mach_logging.h"
#include "base/posix/eintr_wrapper.h"
#include "base/stl_util.h"

View File

@ -14,7 +14,7 @@
#include "snapshot/mac/thread_snapshot_mac.h"
#include "base/logging.h"
#include "base/check_op.h"
#include "snapshot/mac/cpu_context_mac.h"
#include "snapshot/mac/process_reader_mac.h"

View File

@ -16,7 +16,6 @@
#include <stdint.h>
#include "base/logging.h"
#include "base/strings/utf_string_conversions.h"
#include "minidump/minidump_extensions.h"

View File

@ -20,7 +20,6 @@
#include <string>
#include "base/logging.h"
#include "base/macros.h"
#include "base/stl_util.h"
#include "base/strings/stringprintf.h"

View File

@ -14,7 +14,7 @@
#include <windows.h>
#include "base/logging.h"
#include "base/check.h"
#include "client/annotation.h"
#include "client/annotation_list.h"
#include "client/crashpad_info.h"

View File

@ -15,7 +15,7 @@
#include <intrin.h>
#include <windows.h>
#include "base/logging.h"
#include "base/check_op.h"
#include "client/crashpad_client.h"
#include "util/misc/capture_context.h"
#include "util/win/address_types.h"

View File

@ -15,7 +15,7 @@
#include <intrin.h>
#include <windows.h>
#include "base/logging.h"
#include "base/check_op.h"
#include "client/crashpad_client.h"
#include "client/simulate_crash.h"
#include "util/misc/capture_context.h"

View File

@ -14,7 +14,7 @@
#include <windows.h>
#include "base/logging.h"
#include "base/check.h"
#include "client/crashpad_info.h"
#include "util/file/file_io.h"

View File

@ -17,10 +17,10 @@
#include <iterator>
#include <vector>
#include "base/logging.h"
#include "base/check_op.h"
#include "snapshot/capture_memory.h"
#include "snapshot/win/cpu_context_win.h"
#include "snapshot/win/capture_memory_delegate_win.h"
#include "snapshot/win/cpu_context_win.h"
#include "snapshot/win/process_reader_win.h"
namespace crashpad {

View File

@ -15,7 +15,7 @@
#import <UIKit/UIKit.h>
#import <XCTest/XCTest.h>
#include "base/logging.h"
#include "base/check.h"
#import "test/ios/cptest_google_test_runner_delegate.h"
#if !defined(__has_feature) || !__has_feature(objc_arc)

View File

@ -16,7 +16,7 @@
#import <UIKit/UIKit.h>
#include "base/logging.h"
#include "base/check.h"
#include "gtest/gtest.h"
#include "test/ios/cptest_google_test_runner_delegate.h"

View File

@ -20,7 +20,7 @@
#include <string>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/mac/scoped_mach_port.h"
#include "base/strings/stringprintf.h"
#include "handler/mac/exception_handler_server.h"

View File

@ -21,7 +21,6 @@
#include <string>
#include "base/auto_reset.h"
#include "base/logging.h"
#include "base/mac/scoped_mach_port.h"
#include "gtest/gtest.h"
#include "test/errors.h"

View File

@ -14,7 +14,7 @@
#include "test/main_arguments.h"
#include "base/logging.h"
#include "base/check.h"
namespace crashpad {
namespace test {

View File

@ -16,11 +16,11 @@
#include <map>
#include "base/logging.h"
#include "base/check.h"
#include "base/strings/utf_string_conversions.h"
#include "test/main_arguments.h"
#include "util/stdlib/map_insert.h"
#include "test/test_paths.h"
#include "util/stdlib/map_insert.h"
namespace crashpad {
namespace test {

View File

@ -16,7 +16,7 @@
#include <sys/types.h>
#include "base/logging.h"
#include "base/check.h"
#include "base/strings/utf_string_conversions.h"
#include "gtest/gtest.h"
#include "util/win/command_line.h"

View File

@ -23,8 +23,8 @@
#include <string>
#include "base/auto_reset.h"
#include "base/check_op.h"
#include "base/files/scoped_file.h"
#include "base/logging.h"
#include "base/posix/eintr_wrapper.h"
#include "base/strings/stringprintf.h"
#include "build/build_config.h"

View File

@ -16,7 +16,7 @@
#include <sys/mman.h>
#include "base/logging.h"
#include "base/check.h"
#include "base/process/process_metrics.h"
namespace crashpad {

View File

@ -16,7 +16,7 @@
#include <windows.h>
#include "base/logging.h"
#include "base/check.h"
#include "base/process/process_metrics.h"
namespace crashpad {

View File

@ -19,7 +19,7 @@
#include <string.h>
#include <unistd.h>
#include "base/logging.h"
#include "base/check.h"
#include "build/build_config.h"
#include "gtest/gtest.h"
#include "test/errors.h"

View File

@ -16,12 +16,12 @@
#include <windows.h>
#include "base/logging.h"
#include "base/check.h"
#include "base/strings/string16.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "util/misc/random_string.h"
#include "gtest/gtest.h"
#include "util/misc/random_string.h"
namespace crashpad {
namespace test {

View File

@ -16,7 +16,7 @@
#include <shellapi.h>
#include "base/logging.h"
#include "base/check.h"
#include "base/scoped_generic.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"

View File

@ -26,8 +26,8 @@
#include <utility>
#include <vector>
#include "base/check_op.h"
#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/numerics/safe_conversions.h"
#include "base/stl_util.h"
#include "base/strings/utf_string_conversions.h"

View File

@ -19,7 +19,7 @@
#include <algorithm>
#include <limits>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/numerics/safe_conversions.h"
#include "base/stl_util.h"

View File

@ -17,7 +17,6 @@
#include <set>
#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "gtest/gtest.h"

View File

@ -16,7 +16,6 @@
#include <sys/time.h>
#include "base/logging.h"
#include "build/build_config.h"
#include "gtest/gtest.h"
#include "test/errors.h"

View File

@ -18,7 +18,6 @@
#include <time.h>
#include <unistd.h>
#include "base/logging.h"
#include "gtest/gtest.h"
#include "test/linux/fake_ptrace_connection.h"
#include "util/misc/time.h"

View File

@ -14,7 +14,6 @@
#include "util/linux/proc_task_reader.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/strings/stringprintf.h"
#include "gtest/gtest.h"

View File

@ -22,7 +22,7 @@
#include <algorithm>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/posix/eintr_wrapper.h"
#include "util/misc/memory_sanitizer.h"

View File

@ -14,7 +14,6 @@
#include "util/linux/socket.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/posix/eintr_wrapper.h"
#include "gtest/gtest.h"

View File

@ -14,7 +14,6 @@
#include "util/mach/child_port_server.h"
#include "base/logging.h"
#include "base/stl_util.h"
#include "util/mach/child_portServer.h"
#include "util/mach/mach_message.h"

View File

@ -18,7 +18,7 @@
#include <ostream>
#include <utility>
#include "base/logging.h"
#include "base/check_op.h"
#include "util/mach/mach_message.h"
namespace crashpad {

View File

@ -18,7 +18,7 @@
#include <vector>
#include "base/logging.h"
#include "base/notreached.h"
#include "util/mach/exc.h"
#include "util/mach/mach_exc.h"

View File

@ -20,7 +20,6 @@
#include <algorithm>
#include <vector>
#include "base/logging.h"
#include "base/stl_util.h"
#include "build/build_config.h"
#include "util/mac/mac_util.h"

View File

@ -19,10 +19,11 @@
#include <signal.h>
#include <unistd.h>
#include "base/logging.h"
#include "base/check.h"
#include "base/mac/mach_logging.h"
#include "base/mac/scoped_mach_port.h"
#include "base/macros.h"
#include "base/notreached.h"
#include "base/strings/stringprintf.h"
#include "gtest/gtest.h"
#include "test/mac/mach_errors.h"

View File

@ -14,7 +14,6 @@
#include "util/mach/notify_server.h"
#include "base/logging.h"
#include "base/stl_util.h"
#include "util/mach/mach_message.h"
#include "util/mach/notifyServer.h"

View File

@ -14,7 +14,6 @@
#include "util/misc/capture_context_test_util.h"
#include "base/logging.h"
#include "gtest/gtest.h"
#include "util/misc/from_pointer_cast.h"

View File

@ -14,7 +14,6 @@
#include "util/misc/capture_context_test_util.h"
#include "base/logging.h"
#include "gtest/gtest.h"
#include "util/misc/from_pointer_cast.h"

View File

@ -19,7 +19,6 @@
#include <algorithm>
#include "base/format_macros.h"
#include "base/logging.h"
#include "base/stl_util.h"
#include "base/strings/stringprintf.h"
#include "gtest/gtest.h"

View File

@ -17,8 +17,8 @@
//! \file
#include "base/check_op.h"
#include "base/compiler_specific.h"
#include "base/logging.h"
#include "base/macros.h"
#include "build/build_config.h"
#include "util/misc/initialization_state.h"

View File

@ -18,7 +18,7 @@
#include <memory>
#include "base/logging.h"
#include "base/check_op.h"
#include "base/memory/free_deleter.h"
#include "gtest/gtest.h"
#include "test/gtest_death.h"

View File

@ -18,7 +18,6 @@
#include <zircon/process.h>
#include <zircon/syscalls.h>
#include "base/logging.h"
namespace crashpad {

View File

@ -16,7 +16,7 @@
#include <stdint.h>
#include "base/logging.h"
#include "base/check_op.h"
namespace crashpad {

View File

@ -25,7 +25,6 @@
#include <type_traits>
#include "base/logging.h"
#include "base/rand_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"

View File

@ -19,7 +19,7 @@
#include <algorithm>
#include <limits>
#include "base/logging.h"
#include "base/check.h"
#include "util/misc/implicit_cast.h"
namespace crashpad {

View File

@ -20,7 +20,7 @@
#include <utility>
#include <vector>
#include "base/logging.h"
#include "base/check.h"
#include "base/rand_util.h"
#include "base/strings/stringprintf.h"
#include "util/net/http_body.h"

View File

@ -25,7 +25,6 @@
#include "base/files/file_path.h"
#include "base/format_macros.h"
#include "base/logging.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"

View File

@ -18,7 +18,7 @@
#include <limits>
#include <tuple>
#include "base/logging.h"
#include "base/check.h"
#include "base/numerics/safe_conversions.h"
#include "base/numerics/safe_math.h"
#include "util/misc/implicit_cast.h"

View File

@ -18,8 +18,8 @@
#include <paths.h>
#include <unistd.h>
#include "base/check.h"
#include "base/files/scoped_file.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/posix/eintr_wrapper.h"

View File

@ -16,7 +16,6 @@
#include <limits>
#include "base/logging.h"
#include "base/stl_util.h"
#include "build/build_config.h"
#include "gtest/gtest.h"

View File

@ -22,7 +22,6 @@
#include <limits>
#include "base/logging.h"
namespace {

View File

@ -14,7 +14,7 @@
#include "util/stdlib/strlcpy.h"
#include "base/logging.h"
#include "base/check.h"
#include "build/build_config.h"
#if defined(OS_WIN) && defined(WCHAR_T_IS_UTF16)

View File

@ -16,7 +16,6 @@
#include <memory>
#include "base/logging.h"
#include "base/macros.h"
#include "util/file/file_io.h"
#include "util/file/file_reader.h"

View File

@ -13,7 +13,7 @@
// limitations under the License.
#include "util/stream/test_output_stream.h"
#include "base/logging.h"
#include "base/check.h"
namespace crashpad {
namespace test {

View File

@ -17,7 +17,7 @@
#include <cmath>
#include <ostream>
#include "base/logging.h"
#include "base/check_op.h"
namespace crashpad {

View File

@ -18,7 +18,7 @@
#include <limits>
#include <ostream>
#include "base/logging.h"
#include "base/check_op.h"
namespace crashpad {

View File

@ -14,7 +14,7 @@
#include "util/thread/thread.h"
#include "base/logging.h"
#include "base/check.h"
namespace crashpad {

View File

@ -16,6 +16,7 @@
#include <sys/types.h>
#include "base/check_op.h"
#include "base/logging.h"
#include "base/threading/thread_local_storage.h"

View File

@ -14,7 +14,7 @@
#include "util/thread/worker_thread.h"
#include "base/logging.h"
#include "base/check.h"
#include "util/thread/thread.h"
namespace crashpad {

View File

@ -18,7 +18,6 @@
#include <shellapi.h>
#include <sys/types.h>
#include "base/logging.h"
#include "base/scoped_generic.h"
#include "base/stl_util.h"
#include "gtest/gtest.h"

View File

@ -14,7 +14,7 @@
#include "util/win/get_function.h"
#include "base/logging.h"
#include "base/check.h"
#include "base/strings/utf_string_conversions.h"
namespace crashpad {

View File

@ -14,7 +14,6 @@
#include "util/win/nt_internals.h"
#include "base/logging.h"
#include "util/win/get_function.h"
// Declarations that the system headers should provide but dont.

View File

@ -19,8 +19,8 @@
#include <string>
#include <memory>
#include "base/check.h"
#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/stl_util.h"
#include "build/build_config.h"

View File

@ -14,7 +14,7 @@
#include "util/win/scoped_handle.h"
#include "base/logging.h"
#include "base/check.h"
#include "util/file/file_io.h"
namespace crashpad {