From 10222b12362c94aad2fbe2dfb4b277eab3275446 Mon Sep 17 00:00:00 2001 From: Scott Graham Date: Fri, 16 Feb 2018 09:48:15 -0800 Subject: [PATCH] fuchsia: Disable TimeZone.Basic test as timezones are non-functional TZ related functionality isn't working in Fuchsia right now https://fuchsia.googlesource.com/zircon/+/master/third_party/ulib/musl/src/time/__tz.c#9 so this test has no chance of working. Disable for now. Bug: crashpad:196 Change-Id: I77c3d38e5f5fc98f2e7bf8c493df269eb142ce75 Reviewed-on: https://chromium-review.googlesource.com/923201 Commit-Queue: Scott Graham Reviewed-by: Mark Mentovai --- snapshot/BUILD.gn | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/snapshot/BUILD.gn b/snapshot/BUILD.gn index 0fe97d3f..0f3c5bdb 100644 --- a/snapshot/BUILD.gn +++ b/snapshot/BUILD.gn @@ -338,7 +338,11 @@ source_set("snapshot_test") { "win/process_snapshot_win_test.cc", "win/system_snapshot_win_test.cc", ] - } else { + } else if (!crashpad_is_fuchsia) { + # Timezones are currently non-functional on Fuchsia: + # https://fuchsia.googlesource.com/zircon/+/master/third_party/ulib/musl/src/time/__tz.c#9 + # https://crashpad.chromium.org/bug/196. Relevant upstream bugs are ZX-337 + # and ZX-1731. sources += [ "posix/timezone_test.cc" ] }