From 0e3c38a4ca521a7db430ba2fce96536b79c1ae3d Mon Sep 17 00:00:00 2001
From: Mark Mentovai <mark@chromium.org>
Date: Thu, 9 Nov 2017 15:27:25 -0500
Subject: [PATCH] win: Make ProcessSnapshotTest.CrashpadInfoChild use a loaded
 module
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When this test examines a module that doesn’t have a CodeView PDB link,
it will fail. Such a link may be missing when linking with Lexan
ld-link.exe without /DEBUG. The test had been examining the executable
as its module. Since it’s easier to provide a single small module linked
with /DEBUG than it is to require that the test executable always be
linked with /DEBUG, the test is revised to always load a module and
operate on it. The module used is the existing
crashpad_snapshot_test_image_reader_module.dll. It was chosen because
it’s also used by PEImageReader.DebugDirectory, which also requires a
CodeView PDB link.

It’s the build system’s responsibility to ensure that
crashpad_snapshot_test_image_reader_module.dll is linked appropriately.
Crashpad’s own GYP-based build always links with /DEBUG. Chrome’s
GN-based Crashpad build will require additional attention at
symbol_level = 0.

Bug: chromium:782781
Change-Id: I0dda8cd13278b82842263e76bcc46362bd3998df
Reviewed-on: https://chromium-review.googlesource.com/761501
Reviewed-by: Leonard Mosescu <mosescu@chromium.org>
---
 snapshot/win/pe_image_reader_test.cc | 40 +++++++++++++++++-----------
 test/scoped_module_handle.h          |  3 +++
 2 files changed, 28 insertions(+), 15 deletions(-)

diff --git a/snapshot/win/pe_image_reader_test.cc b/snapshot/win/pe_image_reader_test.cc
index c4aa5f0c..ac456e2d 100644
--- a/snapshot/win/pe_image_reader_test.cc
+++ b/snapshot/win/pe_image_reader_test.cc
@@ -23,42 +23,52 @@
 #include "gtest/gtest.h"
 #include "snapshot/win/process_reader_win.h"
 #include "test/errors.h"
+#include "test/scoped_module_handle.h"
 #include "test/test_paths.h"
 #include "util/misc/from_pointer_cast.h"
 #include "util/win/get_module_information.h"
 #include "util/win/module_version.h"
 #include "util/win/process_info.h"
 
-extern "C" IMAGE_DOS_HEADER __ImageBase;
-
 namespace crashpad {
 namespace test {
 namespace {
 
 TEST(PEImageReader, DebugDirectory) {
+  base::FilePath module_path =
+      TestPaths::BuildArtifact(L"snapshot",
+                               L"image_reader_module",
+                               TestPaths::FileType::kLoadableModule);
+  ScopedModuleHandle module_handle(LoadLibrary(module_path.value().c_str()));
+  ASSERT_TRUE(module_handle.valid()) << ErrorMessage("LoadLibrary");
+
   PEImageReader pe_image_reader;
   ProcessReaderWin process_reader;
   ASSERT_TRUE(process_reader.Initialize(GetCurrentProcess(),
                                         ProcessSuspensionState::kRunning));
-  HMODULE self = reinterpret_cast<HMODULE>(&__ImageBase);
+
   MODULEINFO module_info;
-  ASSERT_TRUE(CrashpadGetModuleInformation(
-      GetCurrentProcess(), self, &module_info, sizeof(module_info)))
+  ASSERT_TRUE(CrashpadGetModuleInformation(GetCurrentProcess(),
+                                           module_handle.get(),
+                                           &module_info,
+                                           sizeof(module_info)))
       << ErrorMessage("GetModuleInformation");
-  EXPECT_EQ(module_info.lpBaseOfDll, self);
-  ASSERT_TRUE(pe_image_reader.Initialize(&process_reader,
-                                         FromPointerCast<WinVMAddress>(self),
-                                         module_info.SizeOfImage,
-                                         "self"));
+  EXPECT_EQ(module_info.lpBaseOfDll, module_handle.get());
+
+  base::FilePath module_basename = module_path.BaseName();
+  ASSERT_TRUE(pe_image_reader.Initialize(
+      &process_reader,
+      FromPointerCast<WinVMAddress>(module_handle.get()),
+      module_info.SizeOfImage,
+      base::UTF16ToUTF8(module_basename.value())));
+
   UUID uuid;
   DWORD age;
   std::string pdbname;
   ASSERT_TRUE(pe_image_reader.DebugDirectoryInformation(&uuid, &age, &pdbname));
-  std::string self_name = base::UTF16ToUTF8(
-      TestPaths::ExpectedExecutableBasename(L"crashpad_snapshot_test")
-          .RemoveFinalExtension()
-          .value());
-  EXPECT_NE(pdbname.find(self_name), std::string::npos);
+  std::string module_name =
+      base::UTF16ToUTF8(module_basename.RemoveFinalExtension().value());
+  EXPECT_NE(pdbname.find(module_name), std::string::npos);
   const std::string suffix(".pdb");
   EXPECT_EQ(
       pdbname.compare(pdbname.size() - suffix.size(), suffix.size(), suffix),
diff --git a/test/scoped_module_handle.h b/test/scoped_module_handle.h
index 3863cad3..20b5e153 100644
--- a/test/scoped_module_handle.h
+++ b/test/scoped_module_handle.h
@@ -59,6 +59,9 @@ class ScopedModuleHandle {
   explicit ScopedModuleHandle(ModuleHandle handle);
   ~ScopedModuleHandle();
 
+  //! \return The module handle being managed.
+  ModuleHandle get() const { return handle_; }
+
   //! \return `true` if this object manages a valid loadable module handle.
   bool valid() const { return handle_ != nullptr; }