3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2025-03-10 06:36:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use an even better random number generation scheme in the prune test

Browse Source 
base::RandInt(0, max - 1) has a uniform distribution.
base::RandUint64() % max does not.

TEST=crashpad_client_test PruneCrashReports.PruneOrder
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/1417443002 .
This commit is contained in:
Mark Mentovai 2015-10-19 11:43:58 -04:00
parent 30678f1e82
commit 07dbc3259c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/prune_crash_reports_test.cc
View File

@ -208,7 +208,7 @@ TEST(PruneCrashReports, PruneOrder) {
} }
// The randomness from std::rand() is not, so use a better rand() instead. // The randomness from std::rand() is not, so use a better rand() instead.
const auto random_generator = [](int rand_max) { const auto random_generator = [](int rand_max) {
return base::RandUint64() % rand_max; return base::RandInt(0, rand_max - 1);
}; };
std::random_shuffle(reports.begin(), reports.end(), random_generator); std::random_shuffle(reports.begin(), reports.end(), random_generator);
std::vector<CrashReportDatabase::Report> pending_reports( std::vector<CrashReportDatabase::Report> pending_reports(