Include-what-you-use related to logging.h

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when Chromium's logging.h
no longer includes check.h, check_op.h, and notreached.h.

DEPS is also updated to roll mini_chromium to ae14a14ab4 which
includes these new header files.

Bug: chromium:1031540
Change-Id: I36f646d0a93854989dc602d0dc7139dd7a7b8621
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2250251
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

DEPS

@@ -42,7 +42,7 @@ deps = {
       '7bde79cc274d06451bf65ae82c012a5d3e476b5a',
   'crashpad/third_party/mini_chromium/mini_chromium':
       Var('chromium_git') + '/chromium/mini_chromium@' +
-      '8ca5ea356cdb97913d62d379d503567a80d90726',
+      'ae14a14ab4cea36db9c446741581d427a7fc7f89',
   'crashpad/third_party/libfuzzer/src':
       Var('chromium_git') + '/chromium/llvm-project/compiler-rt/lib/fuzzer.git@' +
       'fda403cf93ecb8792cb1d061564d89a6553ca020',

client/prune_crash_reports.cc

@@ -21,6 +21,7 @@
 #include <vector>
 
 #include "base/logging.h"
+#include "base/notreached.h"
 #include "build/build_config.h"
 
 namespace crashpad {

client/simple_address_range_bag.h

@@ -20,6 +20,7 @@
 
 #include <type_traits>
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/numerics/safe_conversions.h"

client/simulate_crash_mac.cc

@@ -17,6 +17,7 @@
 #include <string.h>
 #include <sys/types.h>
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "base/mac/mach_logging.h"
 #include "base/mac/scoped_mach_port.h"

handler/crash_report_upload_thread.cc

@@ -23,6 +23,7 @@
 #include <vector>
 
 #include "base/logging.h"
+#include "base/notreached.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"

handler/win/hanging_program.cc

@@ -17,6 +17,7 @@
 
 #include "base/debug/alias.h"
 #include "base/logging.h"
+#include "base/notreached.h"
 #include "base/stl_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"

snapshot/capture_memory.cc

@@ -19,6 +19,7 @@
 #include <limits>
 #include <memory>
 
+#include "base/logging.h"
 #include "base/stl_util.h"
 #include "snapshot/memory_snapshot.h"
 

snapshot/capture_memory.h

@@ -19,6 +19,7 @@
 
 #include <vector>
 
+#include "base/macros.h"
 #include "snapshot/cpu_context.h"
 #include "util/numeric/checked_range.h"
 

snapshot/linux/system_snapshot_linux.cc

@@ -22,6 +22,7 @@
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
+#include "base/notreached.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/stringprintf.h"

snapshot/mac/cpu_context_mac.cc

@@ -18,6 +18,7 @@
 #include <string.h>
 
 #include "base/logging.h"
+#include "base/notreached.h"
 
 namespace crashpad {
 

snapshot/mac/mach_o_image_symbol_table_reader.cc

@@ -21,6 +21,7 @@
 #include <memory>
 #include <utility>
 
+#include "base/logging.h"
 #include "base/strings/stringprintf.h"
 #include "util/mac/checked_mach_address_range.h"
 #include "util/process/process_memory_mac.h"

snapshot/memory_snapshot.cc

@@ -17,6 +17,7 @@
 #include <algorithm>
 
 #include "base/format_macros.h"
+#include "base/logging.h"
 #include "base/strings/stringprintf.h"
 #include "util/numeric/checked_range.h"
 

snapshot/memory_snapshot_generic.h

@@ -18,6 +18,7 @@
 #include <stdint.h>
 #include <sys/types.h>
 
+#include "base/logging.h"
 #include "base/macros.h"
 #include "base/numerics/safe_math.h"
 #include "snapshot/memory_snapshot.h"

snapshot/minidump/minidump_context_converter.cc

@@ -16,6 +16,7 @@
 
 #include <string.h>
 
+#include "base/logging.h"
 #include "base/stl_util.h"
 #include "minidump/minidump_context.h"
 

snapshot/minidump/module_snapshot_minidump.cc

@@ -18,6 +18,7 @@
 #include <string.h>
 
 #include "base/logging.h"
+#include "base/notreached.h"
 #include "minidump/minidump_extensions.h"
 #include "snapshot/minidump/minidump_annotation_reader.h"
 #include "snapshot/minidump/minidump_simple_string_dictionary_reader.h"

snapshot/minidump/process_snapshot_minidump.cc

@@ -16,6 +16,8 @@
 
 #include <utility>
 
+#include "base/logging.h"
+#include "base/notreached.h"
 #include "base/strings/utf_string_conversions.h"
 #include "minidump/minidump_extensions.h"
 #include "snapshot/memory_map_region_snapshot.h"

snapshot/minidump/system_snapshot_minidump.cc

@@ -14,6 +14,7 @@
 
 #include "snapshot/minidump/system_snapshot_minidump.h"
 
+#include "base/notreached.h"
 #include "snapshot/minidump/minidump_string_reader.h"
 
 namespace crashpad {

snapshot/sanitized/process_snapshot_sanitized_test.cc

@@ -15,6 +15,7 @@
 #include "snapshot/sanitized/process_snapshot_sanitized.h"
 
 #include "base/macros.h"
+#include "base/notreached.h"
 #include "build/build_config.h"
 #include "gtest/gtest.h"
 #include "test/multiprocess_exec.h"

snapshot/sanitized/sanitization_information.cc

@@ -16,6 +16,7 @@
 
 #include <limits>
 
+#include "base/logging.h"
 #include "client/annotation.h"
 
 namespace crashpad {

snapshot/win/exception_snapshot_win.cc

@@ -14,6 +14,7 @@
 
 #include "snapshot/win/exception_snapshot_win.h"
 
+#include "base/logging.h"
 #include "client/crashpad_client.h"
 #include "snapshot/capture_memory.h"
 #include "snapshot/memory_snapshot.h"

snapshot/win/pe_image_annotations_reader.cc

@@ -17,6 +17,7 @@
 #include <string.h>
 #include <sys/types.h>
 
+#include "base/logging.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "client/annotation.h"

snapshot/win/system_snapshot_win.cc

@@ -23,6 +23,7 @@
 #include <utility>
 #include <vector>
 
+#include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"

test/linux/fake_ptrace_connection.cc

@@ -16,6 +16,7 @@
 
 #include <utility>
 
+#include "base/notreached.h"
 #include "build/build_config.h"
 #include "gtest/gtest.h"
 #include "util/file/file_io.h"

test/win/win_multiprocess_with_temp_dir.cc

@@ -16,6 +16,7 @@
 
 #include <tlhelp32.h>
 
+#include "base/logging.h"
 #include "test/errors.h"
 #include "util/process/process_id.h"
 #include "util/win/process_info.h"

util/file/file_io.cc

@@ -14,6 +14,7 @@
 
 #include "util/file/file_io.h"
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/numerics/safe_conversions.h"

util/file/file_io_posix.cc

@@ -26,6 +26,7 @@
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
+#include "base/notreached.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/strings/stringprintf.h"
 #include "build/build_config.h"

util/file/file_io_win.cc

@@ -19,6 +19,7 @@
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
+#include "base/notreached.h"
 #include "base/strings/utf_string_conversions.h"
 
 namespace {

util/file/output_stream_file_writer.cc

@@ -15,6 +15,7 @@
 #include "util/file/output_stream_file_writer.h"
 
 #include "base/logging.h"
+#include "base/notreached.h"
 #include "util/stream/output_stream_interface.h"
 
 namespace crashpad {

util/linux/socket.cc

@@ -16,6 +16,7 @@
 
 #include <unistd.h>
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
 #include "third_party/lss/lss.h"

util/mach/child_port_handshake.cc

@@ -26,9 +26,11 @@
 #include <algorithm>
 #include <utility>
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "base/mac/mach_logging.h"
 #include "base/mac/scoped_mach_port.h"
+#include "base/notreached.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/rand_util.h"
 #include "base/stl_util.h"

util/mach/composite_mach_message_server.cc

@@ -15,6 +15,7 @@
 #include "util/mach/composite_mach_message_server.h"
 
 #include <algorithm>
+#include <ostream>
 #include <utility>
 
 #include "base/logging.h"

util/mach/exception_ports.cc

@@ -16,6 +16,7 @@
 
 #include "base/logging.h"
 #include "base/mac/mach_logging.h"
+#include "base/notreached.h"
 
 namespace crashpad {
 

util/mach/exception_types.cc

@@ -22,6 +22,7 @@
 #include <kern/exc_resource.h>
 #include <strings.h>
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "base/mac/mach_logging.h"
 #include "util/mac/mac_util.h"

util/mach/scoped_task_suspend.cc

@@ -14,6 +14,7 @@
 
 #include "util/mach/scoped_task_suspend.h"
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "base/mac/mach_logging.h"
 

util/misc/capture_context_broken.cc

@@ -14,7 +14,9 @@
 
 #include "util/misc/capture_context.h"
 
-#include "base/logging.h"
+#include <ostream>
+
+#include "base/check.h"
 
 namespace crashpad {
 

util/misc/clock_posix.cc

@@ -16,7 +16,9 @@
 
 #include <time.h>
 
-#include "base/logging.h"
+#include <ostream>
+
+#include "base/check.h"
 #include "base/posix/eintr_wrapper.h"
 #include "build/build_config.h"
 

util/misc/zlib.cc

@@ -14,7 +14,9 @@
 
 #include "util/misc/zlib.h"
 
-#include "base/logging.h"
+#include <ostream>
+
+#include "base/check.h"
 #include "base/strings/stringprintf.h"
 #include "third_party/zlib/zlib_crashpad.h"
 

util/numeric/checked_address_range.cc

@@ -14,6 +14,7 @@
 
 #include "util/numeric/checked_address_range.h"
 
+#include "base/check_op.h"
 #include "base/format_macros.h"
 #include "base/strings/stringprintf.h"
 

util/posix/double_fork_and_exec.cc

@@ -19,6 +19,7 @@
 #include <sys/wait.h>
 #include <unistd.h>
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/strings/stringprintf.h"

util/posix/drop_privileges.cc

@@ -14,7 +14,9 @@
 
 #include <unistd.h>
 
-#include "base/logging.h"
+#include <ostream>
+
+#include "base/check_op.h"
 #include "build/build_config.h"
 
 namespace crashpad {

util/posix/scoped_mmap.cc

@@ -18,6 +18,7 @@
 
 #include <algorithm>
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/numerics/safe_math.h"

util/posix/signals.cc

@@ -18,6 +18,7 @@
 
 #include <vector>
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
 

util/process/process_memory.cc

@@ -18,6 +18,7 @@
 
 #include <algorithm>
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "util/numeric/safe_assignment.h"
 

util/stream/base94_output_stream.cc

@@ -16,6 +16,7 @@
 
 #include <algorithm>
 
+#include "base/check.h"
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
 

util/stream/log_output_stream.cc

@@ -18,6 +18,7 @@
 
 #include <algorithm>
 
+#include "base/check.h"
 #include "base/logging.h"
 
 #if defined(OS_ANDROID)

util/synchronization/semaphore_mac.cc

@@ -15,6 +15,7 @@
 #include "util/synchronization/semaphore.h"
 
 #include <cmath>
+#include <ostream>
 
 #include "base/logging.h"
 

util/synchronization/semaphore_posix.cc

@@ -20,6 +20,7 @@
 
 #include <chrono>
 
+#include "base/check_op.h"
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
 #include "util/misc/time.h"

util/synchronization/semaphore_win.cc

@@ -16,6 +16,7 @@
 
 #include <cmath>
 #include <limits>
+#include <ostream>
 
 #include "base/logging.h"
 

util/thread/thread_posix.cc

@@ -16,7 +16,9 @@
 
 #include <errno.h>
 
-#include "base/logging.h"
+#include <ostream>
+
+#include "base/check.h"
 
 namespace crashpad {
 

util/thread/thread_win.cc

@@ -14,7 +14,9 @@
 
 #include "util/thread/thread.h"
 
-#include "base/logging.h"
+#include <ostream>
+
+#include "base/check.h"
 
 namespace crashpad {
 

util/win/registration_protocol_win_test.cc

@@ -22,6 +22,7 @@
 #include <vector>
 
 #include "base/logging.h"
+#include "base/notreached.h"
 #include "base/strings/string16.h"
 #include "gtest/gtest.h"
 #include "test/errors.h"

util/win/scoped_set_event.cc

@@ -14,6 +14,7 @@
 
 #include "util/win/scoped_set_event.h"
 
+#include "base/check.h"
 #include "base/logging.h"
 
 namespace crashpad {