3party/crashpad
0
0
Fork 0
mirror of https://github.com/chromium/crashpad.git synced 2024-12-29 00:32:35 +08:00
Code Issues Projects Releases Wiki Activity
crashpad/snapshot/crashpad_info_size_test_module.cc

129 lines
4.4 KiB
C++
Raw Normal View History

Tolerate safe size mismatches in the CrashpadInfo struct The handler will now be less strict about checking CrashpadInfo struct sizes. Assuming the signature and version fields match: - If the handler sees a struct smaller than it’s expecting, the module was likely built with an earlier version of the client library, and it’s safe to treat the unknown fields as though they were zero or other suitable default values. - If the handler sees a struct larger than it’s expecting, the module was likely built with a later version of the client library. In that case, actions desired by the client will not be performed, but this is not otherwise an error condition. The CrashpadInfo struct must always be at least large enough to contain at least the size field. The signature and version fields are always checked. The section size must be at least as large as the size carried within the struct. To account for possible section padding, strict equality is not required. Bug: chromium:784427 Test: crashpad_snapshot_test CrashpadInfoSizes_ClientOptions/*.* Change-Id: Ibb0690ca6ed5e7619d1278a68ba7e893d55f19fb Reviewed-on: https://chromium-review.googlesource.com/767709 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-11-15 12:43:44 -05:00
// Copyright 2017 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include <stdint.h>
#include "build/build_config.h"
Migrate to OS_MAC and OS_APPLE in Crashpad This migrates: defined(OS_MACOSX) -> defined(OS_APPLE) defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC) Bug: chromium:1105907 Change-Id: I1b4abc19bbbe8df90e9c6e64cd29324b40b8ab71 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2321777 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-07-27 22:20:52 -04:00
#if defined(OS_APPLE)
Tolerate safe size mismatches in the CrashpadInfo struct The handler will now be less strict about checking CrashpadInfo struct sizes. Assuming the signature and version fields match: - If the handler sees a struct smaller than it’s expecting, the module was likely built with an earlier version of the client library, and it’s safe to treat the unknown fields as though they were zero or other suitable default values. - If the handler sees a struct larger than it’s expecting, the module was likely built with a later version of the client library. In that case, actions desired by the client will not be performed, but this is not otherwise an error condition. The CrashpadInfo struct must always be at least large enough to contain at least the size field. The signature and version fields are always checked. The section size must be at least as large as the size carried within the struct. To account for possible section padding, strict equality is not required. Bug: chromium:784427 Test: crashpad_snapshot_test CrashpadInfoSizes_ClientOptions/*.* Change-Id: Ibb0690ca6ed5e7619d1278a68ba7e893d55f19fb Reviewed-on: https://chromium-review.googlesource.com/767709 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-11-15 12:43:44 -05:00
#include <mach-o/loader.h>
#elif defined(OS_WIN)
#include <windows.h>
Migrate to OS_MAC and OS_APPLE in Crashpad This migrates: defined(OS_MACOSX) -> defined(OS_APPLE) defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC) Bug: chromium:1105907 Change-Id: I1b4abc19bbbe8df90e9c6e64cd29324b40b8ab71 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2321777 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-07-27 22:20:52 -04:00
#endif // OS_APPLE
Tolerate safe size mismatches in the CrashpadInfo struct The handler will now be less strict about checking CrashpadInfo struct sizes. Assuming the signature and version fields match: - If the handler sees a struct smaller than it’s expecting, the module was likely built with an earlier version of the client library, and it’s safe to treat the unknown fields as though they were zero or other suitable default values. - If the handler sees a struct larger than it’s expecting, the module was likely built with a later version of the client library. In that case, actions desired by the client will not be performed, but this is not otherwise an error condition. The CrashpadInfo struct must always be at least large enough to contain at least the size field. The signature and version fields are always checked. The section size must be at least as large as the size carried within the struct. To account for possible section padding, strict equality is not required. Bug: chromium:784427 Test: crashpad_snapshot_test CrashpadInfoSizes_ClientOptions/*.* Change-Id: Ibb0690ca6ed5e7619d1278a68ba7e893d55f19fb Reviewed-on: https://chromium-review.googlesource.com/767709 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-11-15 12:43:44 -05:00
namespace crashpad {
#if defined(CRASHPAD_INFO_SIZE_TEST_MODULE_SMALL) == \
defined(CRASHPAD_INFO_SIZE_TEST_MODULE_LARGE)
#error Define exactly one of these macros
#endif
// This module contains a CrashpadInfo structure that’s either smaller or larger
// than the one defined in the client library, depending on which macro is
// defined when it’s compiled. This tests the snapshot layer’s ability to read
// smaller structures (as might be found in modules built with older versions of
// the client library than a handler’s snapshot library) and larger ones (the
// “vice-versa” situation). This needs to be done without taking a dependency on
// the client library, which would bring with it a correct copy of the
// CrashpadInfo structure. As a result, all types have been simplified to
// fixed-size integers and void* pointers.
struct TestCrashpadInfo {
uint32_t signature_;
uint32_t size_;
uint32_t version_;
uint32_t indirectly_referenced_memory_cap_;
uint32_t padding_0_;
uint8_t crashpad_handler_behavior_;
uint8_t system_crash_reporter_forwarding_;
uint8_t gather_indirectly_referenced_memory_;
uint8_t padding_1_;
void* extra_memory_ranges_;
void* simple_annotations_;
#if !defined(CRASHPAD_INFO_SIZE_TEST_MODULE_SMALL)
void* user_data_minidump_stream_head_;
void* annotations_list_;
#endif // CRASHPAD_INFO_SIZE_TEST_MODULE_SMALL
#if defined(CRASHPAD_INFO_SIZE_TEST_MODULE_LARGE)
uint8_t trailer_[64 * 1024];
#endif // CRASHPAD_INFO_SIZE_TEST_MODULE_LARGE
};
// Put it in the correct section.
//
// The initializer also duplicates constants from the client library, sufficient
// to get this test version to be interpreted as a genuine CrashpadInfo
// structure. The size is set to the actual size of this structure (that’s kind
// of the point of this test).
#if defined(OS_POSIX)
__attribute__((
Migrate to OS_MAC and OS_APPLE in Crashpad This migrates: defined(OS_MACOSX) -> defined(OS_APPLE) defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC) Bug: chromium:1105907 Change-Id: I1b4abc19bbbe8df90e9c6e64cd29324b40b8ab71 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2321777 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
2020-07-27 22:20:52 -04:00
#if defined(OS_APPLE)
Tolerate safe size mismatches in the CrashpadInfo struct The handler will now be less strict about checking CrashpadInfo struct sizes. Assuming the signature and version fields match: - If the handler sees a struct smaller than it’s expecting, the module was likely built with an earlier version of the client library, and it’s safe to treat the unknown fields as though they were zero or other suitable default values. - If the handler sees a struct larger than it’s expecting, the module was likely built with a later version of the client library. In that case, actions desired by the client will not be performed, but this is not otherwise an error condition. The CrashpadInfo struct must always be at least large enough to contain at least the size field. The signature and version fields are always checked. The section size must be at least as large as the size carried within the struct. To account for possible section padding, strict equality is not required. Bug: chromium:784427 Test: crashpad_snapshot_test CrashpadInfoSizes_ClientOptions/*.* Change-Id: Ibb0690ca6ed5e7619d1278a68ba7e893d55f19fb Reviewed-on: https://chromium-review.googlesource.com/767709 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-11-15 12:43:44 -05:00
section(SEG_DATA ",crashpad_info"),
fuchsia: Get crashpad_snapshot_test building ProcessSnapshotFuchsia is just a stub, so running fails immediately. Bug: crashpad:196 Change-Id: Ie281cc13c4ff4a6e9699e882dbd6207daaab346d Reviewed-on: https://chromium-review.googlesource.com/809234 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2017-12-05 15:43:23 -08:00
#endif
Tolerate safe size mismatches in the CrashpadInfo struct The handler will now be less strict about checking CrashpadInfo struct sizes. Assuming the signature and version fields match: - If the handler sees a struct smaller than it’s expecting, the module was likely built with an earlier version of the client library, and it’s safe to treat the unknown fields as though they were zero or other suitable default values. - If the handler sees a struct larger than it’s expecting, the module was likely built with a later version of the client library. In that case, actions desired by the client will not be performed, but this is not otherwise an error condition. The CrashpadInfo struct must always be at least large enough to contain at least the size field. The signature and version fields are always checked. The section size must be at least as large as the size carried within the struct. To account for possible section padding, strict equality is not required. Bug: chromium:784427 Test: crashpad_snapshot_test CrashpadInfoSizes_ClientOptions/*.* Change-Id: Ibb0690ca6ed5e7619d1278a68ba7e893d55f19fb Reviewed-on: https://chromium-review.googlesource.com/767709 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-11-15 12:43:44 -05:00
#if defined(ADDRESS_SANITIZER)
aligned(64),
#endif // defined(ADDRESS_SANITIZER)
Fix CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOptions These tests needed to be updated to expose CrashpadInfo in the same way as the main CrashpadInfo g_crashpad_info is found on Linux/Android/Fuchsia. Unfortunately, while the tests pass on Fuchsia when run in isolation, the implementation of dlclose() on Fuchsia currently does nothing. So, if the full test suite is run, there's interference between the test modules (i.e. the values in _small vs. the values in _large), so the tests fail. I filed ZX-1728 upstream about this to see if it might be implemented, or if the test will need to spawn a clean child to do the module load tests in. Bug: crashpad:196 Change-Id: I9ee01b142a29c508c6967dc83da824afa254d379 Reviewed-on: https://chromium-review.googlesource.com/923182 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-02-16 09:55:34 -08:00
visibility("hidden"),
used))
Tolerate safe size mismatches in the CrashpadInfo struct The handler will now be less strict about checking CrashpadInfo struct sizes. Assuming the signature and version fields match: - If the handler sees a struct smaller than it’s expecting, the module was likely built with an earlier version of the client library, and it’s safe to treat the unknown fields as though they were zero or other suitable default values. - If the handler sees a struct larger than it’s expecting, the module was likely built with a later version of the client library. In that case, actions desired by the client will not be performed, but this is not otherwise an error condition. The CrashpadInfo struct must always be at least large enough to contain at least the size field. The signature and version fields are always checked. The section size must be at least as large as the size carried within the struct. To account for possible section padding, strict equality is not required. Bug: chromium:784427 Test: crashpad_snapshot_test CrashpadInfoSizes_ClientOptions/*.* Change-Id: Ibb0690ca6ed5e7619d1278a68ba7e893d55f19fb Reviewed-on: https://chromium-review.googlesource.com/767709 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-11-15 12:43:44 -05:00
#elif defined(OS_WIN)
#pragma section("CPADinfo", read, write)
__declspec(allocate("CPADinfo"))
#else // !defined(OS_POSIX) && !defined(OS_WIN)
#error Port
#endif // !defined(OS_POSIX) && !defined(OS_WIN)
fuchsia: Fully initialize TestCrashpadInfo structure The in-Fuchsia build fails with: ../../third_party/crashpad/snapshot/crashpad_info_size_test_module.cc:89:77: error: missing field 'indirectly_referenced_memory_cap_' initializer [-Werror,-Wmissing-field-initializers] TestCrashpadInfo g_test_crashpad_info = {'CPad', sizeof(TestCrashpadInfo), 1}; kulakowski mentioned in the context of the = {0} CL recently that they've turned on some somewhat unusual warnings because they have a higher-than-usual amount of C code, as well as code that has to build as both C and C++. I think that's where this one comes from. Bug: crashpad:196 Change-Id: Ie1b373a32f99615366c7fcd65cd4ae4761385ff9 Reviewed-on: https://chromium-review.googlesource.com/862802 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-01-11 15:51:23 -08:00
TestCrashpadInfo g_test_crashpad_info = {'CPad',
sizeof(TestCrashpadInfo),
1,
0,
0,
0,
0,
0,
0,
nullptr,
nullptr,
#if !defined(CRASHPAD_INFO_SIZE_TEST_MODULE_SMALL)
nullptr,
nullptr,
#endif // CRASHPAD_INFO_SIZE_TEST_MODULE_SMALL
#if defined(CRASHPAD_INFO_SIZE_TEST_MODULE_LARGE)
{}
#endif // CRASHPAD_INFO_SIZE_TEST_MODULE_LARGE
};
Tolerate safe size mismatches in the CrashpadInfo struct The handler will now be less strict about checking CrashpadInfo struct sizes. Assuming the signature and version fields match: - If the handler sees a struct smaller than it’s expecting, the module was likely built with an earlier version of the client library, and it’s safe to treat the unknown fields as though they were zero or other suitable default values. - If the handler sees a struct larger than it’s expecting, the module was likely built with a later version of the client library. In that case, actions desired by the client will not be performed, but this is not otherwise an error condition. The CrashpadInfo struct must always be at least large enough to contain at least the size field. The signature and version fields are always checked. The section size must be at least as large as the size carried within the struct. To account for possible section padding, strict equality is not required. Bug: chromium:784427 Test: crashpad_snapshot_test CrashpadInfoSizes_ClientOptions/*.* Change-Id: Ibb0690ca6ed5e7619d1278a68ba7e893d55f19fb Reviewed-on: https://chromium-review.googlesource.com/767709 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-11-15 12:43:44 -05:00
} // namespace crashpad
extern "C" {
#if defined(OS_POSIX)
__attribute__((visibility("default")))
#elif defined(OS_WIN)
__declspec(dllexport)
#else
#error Port
#endif // OS_POSIX
crashpad::TestCrashpadInfo* TestModule_GetCrashpadInfo() {
Fix CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOptions These tests needed to be updated to expose CrashpadInfo in the same way as the main CrashpadInfo g_crashpad_info is found on Linux/Android/Fuchsia. Unfortunately, while the tests pass on Fuchsia when run in isolation, the implementation of dlclose() on Fuchsia currently does nothing. So, if the full test suite is run, there's interference between the test modules (i.e. the values in _small vs. the values in _large), so the tests fail. I filed ZX-1728 upstream about this to see if it might be implemented, or if the test will need to spawn a clean child to do the module load tests in. Bug: crashpad:196 Change-Id: I9ee01b142a29c508c6967dc83da824afa254d379 Reviewed-on: https://chromium-review.googlesource.com/923182 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
2018-02-16 09:55:34 -08:00
// Note that there's no need to do the back-reference here to the note on
// POSIX like CrashpadInfo::GetCrashpadInfo() because the note .S file is
// directly included into this test binary.
Tolerate safe size mismatches in the CrashpadInfo struct The handler will now be less strict about checking CrashpadInfo struct sizes. Assuming the signature and version fields match: - If the handler sees a struct smaller than it’s expecting, the module was likely built with an earlier version of the client library, and it’s safe to treat the unknown fields as though they were zero or other suitable default values. - If the handler sees a struct larger than it’s expecting, the module was likely built with a later version of the client library. In that case, actions desired by the client will not be performed, but this is not otherwise an error condition. The CrashpadInfo struct must always be at least large enough to contain at least the size field. The signature and version fields are always checked. The section size must be at least as large as the size carried within the struct. To account for possible section padding, strict equality is not required. Bug: chromium:784427 Test: crashpad_snapshot_test CrashpadInfoSizes_ClientOptions/*.* Change-Id: Ibb0690ca6ed5e7619d1278a68ba7e893d55f19fb Reviewed-on: https://chromium-review.googlesource.com/767709 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-11-15 12:43:44 -05:00
return &crashpad::g_test_crashpad_info;
}
} // extern "C"
#if defined(OS_WIN)
BOOL WINAPI DllMain(HINSTANCE hinstance, DWORD reason, LPVOID reserved) {
return TRUE;
}
#endif // OS_WIN
Reference in New Issue Copy Permalink