2022-09-06 19:14:07 -04:00
|
|
|
// Copyright 2014 The Crashpad Authors
|
2014-08-26 17:10:19 -04:00
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
test: Move util/test to its own top-level directory, test.
After 9e79ea1da719, it no longer makes sense for crashpad_util_test_lib
to “hide” in util/util_test.gyp. All of util/test is moved to its own
top-level directory, test, which all other test code is allowed to
depend on. test, too, is allowed to depend on all other non-test code.
In a future change, when crashpad_util_test_lib gains a dependency on
crashpad_client, it won’t look so weird for something in util (even
though it’s in util/test) to depend on something in client, because the
thing that needs to depend on client will live in test, not util.
BUG=crashpad:33
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/1051533002
2015-03-31 17:44:14 -04:00
|
|
|
#include "test/multiprocess.h"
|
2014-08-26 17:10:19 -04:00
|
|
|
|
2016-10-31 14:58:30 -04:00
|
|
|
#include <signal.h>
|
2014-09-09 17:04:47 -04:00
|
|
|
#include <stdlib.h>
|
2014-08-26 17:10:19 -04:00
|
|
|
#include <unistd.h>
|
|
|
|
|
|
|
|
#include "gtest/gtest.h"
|
mac: Tests that crash intentionally shouldn’t go to ReportCrash
Crashpad has many tests that crash intentionally. Some of these are
gtest death tests, and others arrange for intentional crashes to test
Crashpad’s own crash-catching logic. On macOS, all of the gtest death
tests and some of the other intentional crashes were being logged by
ReportCrash, the system’s crash reporter. Since these reports
corresponded to intentional crashes, they were never useful, and served
only to clutter ~/Library/Logs/DiagnosticReports.
Since Crashpad is adept at handling exceptions on its own, this
introduces the “exception swallowing server”,
crashpad_exception_swallower, which is a Mach exception server that
implements a no-op exception handler routine for all exceptions
received. The exception swallowing server is established as the task
handler for EXC_CRASH and EXC_CORPSE_NOTIFY exceptions during gtest
death tests invoked by {ASSERT,EXPECT}_DEATH_{CHECK,CRASH}, and for all
child processes invoked by the Multiprocess test infrastructure. The
exception swallowing server is not in effect at other times, so
unexpected crashes in test code can still be handled by ReportCrash or
another crash reporter.
With this change in place, no new reports are generated in the
user-level ~/Library/Logs/DiagnosticReports or the system’s
/Library/Logs/DiagnosticReports during a run of Crashpad’s full test
suite on macOS.
Bug: crashpad:33
Change-Id: I13891853a7e25accc30da21fa7ea8bd7d1f3bd2f
Reviewed-on: https://chromium-review.googlesource.com/777859
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-11-20 13:32:26 -05:00
|
|
|
#include "test/gtest_death.h"
|
2014-12-17 14:35:18 -08:00
|
|
|
#include "util/file/file_io.h"
|
2014-08-26 17:10:19 -04:00
|
|
|
|
2014-10-07 17:28:50 -04:00
|
|
|
namespace crashpad {
|
|
|
|
namespace test {
|
2014-08-26 17:10:19 -04:00
|
|
|
namespace {
|
|
|
|
|
|
|
|
class TestMultiprocess final : public Multiprocess {
|
|
|
|
public:
|
|
|
|
TestMultiprocess() : Multiprocess() {}
|
|
|
|
|
2021-09-20 12:55:12 -07:00
|
|
|
TestMultiprocess(const TestMultiprocess&) = delete;
|
|
|
|
TestMultiprocess& operator=(const TestMultiprocess&) = delete;
|
|
|
|
|
2014-08-26 17:10:19 -04:00
|
|
|
~TestMultiprocess() {}
|
|
|
|
|
|
|
|
private:
|
2014-09-22 13:06:12 -04:00
|
|
|
// Multiprocess:
|
|
|
|
|
2014-10-14 11:11:57 -04:00
|
|
|
void MultiprocessParent() override {
|
2015-01-28 14:49:42 -08:00
|
|
|
FileHandle read_handle = ReadPipeHandle();
|
2014-08-26 17:10:19 -04:00
|
|
|
char c;
|
Make file_io reads more rational and predictable
ReadFile() attempted to continue reading after a short read. In most
cases, this is fine. However, ReadFile() would keep trying to fill a
partially-filled buffer until experiencing a 0-length read(), signaling
end-of-file. For certain weird file descriptors like terminal input, EOF
is an ephemeral condition, and attempting to read beyond EOF doesn’t
actually return 0 (EOF) provided that they remain open, it will block
waiting for more input. Consequently, ReadFile() and anything based on
ReadFile() had an undocumented and quirky interface, which was that any
short read that it returned (not an underlying short read) actually
indicated EOF.
This facet of ReadFile() was unexpected, so it’s being removed. The new
behavior is that ReadFile() will return an underlying short read. The
behavior of FileReaderInterface::Read() is updated in accordance with
this change.
Upon experiencing a short read, the caller can determine the best
action. Most callers were already prepared for this behavior. Outside of
util/file, only crashpad_database_util properly implemented EOF
detection according to previous semantics, and adapting it to new
semantics is trivial.
Callers who require an exact-length read can use the new
ReadFileExactly(), or the newly renamed LoggingReadFileExactly() or
CheckedReadFileExactly(). These functions will retry following a short
read. The renamed functions were previously called LoggingReadFile() and
CheckedReadFile(), but those names implied that they were simply
wrapping ReadFile(), which is not the case. They wrapped ReadFile() and
further, insisted on a full read. Since ReadFile()’s semantics are now
changing but these functions’ are not, they’re now even more distinct
from ReadFile(), and must be renamed to avoid confusion.
Test: *
Change-Id: I06b77e0d6ad8719bd2eb67dab93a8740542dd908
Reviewed-on: https://chromium-review.googlesource.com/456676
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-03-16 13:36:38 -04:00
|
|
|
CheckedReadFileExactly(read_handle, &c, 1);
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_EQ(c, 'M');
|
2014-08-26 17:10:19 -04:00
|
|
|
|
|
|
|
pid_t pid;
|
Make file_io reads more rational and predictable
ReadFile() attempted to continue reading after a short read. In most
cases, this is fine. However, ReadFile() would keep trying to fill a
partially-filled buffer until experiencing a 0-length read(), signaling
end-of-file. For certain weird file descriptors like terminal input, EOF
is an ephemeral condition, and attempting to read beyond EOF doesn’t
actually return 0 (EOF) provided that they remain open, it will block
waiting for more input. Consequently, ReadFile() and anything based on
ReadFile() had an undocumented and quirky interface, which was that any
short read that it returned (not an underlying short read) actually
indicated EOF.
This facet of ReadFile() was unexpected, so it’s being removed. The new
behavior is that ReadFile() will return an underlying short read. The
behavior of FileReaderInterface::Read() is updated in accordance with
this change.
Upon experiencing a short read, the caller can determine the best
action. Most callers were already prepared for this behavior. Outside of
util/file, only crashpad_database_util properly implemented EOF
detection according to previous semantics, and adapting it to new
semantics is trivial.
Callers who require an exact-length read can use the new
ReadFileExactly(), or the newly renamed LoggingReadFileExactly() or
CheckedReadFileExactly(). These functions will retry following a short
read. The renamed functions were previously called LoggingReadFile() and
CheckedReadFile(), but those names implied that they were simply
wrapping ReadFile(), which is not the case. They wrapped ReadFile() and
further, insisted on a full read. Since ReadFile()’s semantics are now
changing but these functions’ are not, they’re now even more distinct
from ReadFile(), and must be renamed to avoid confusion.
Test: *
Change-Id: I06b77e0d6ad8719bd2eb67dab93a8740542dd908
Reviewed-on: https://chromium-review.googlesource.com/456676
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-03-16 13:36:38 -04:00
|
|
|
CheckedReadFileExactly(read_handle, &pid, sizeof(pid));
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_EQ(ChildPID(), pid);
|
2014-08-26 17:10:19 -04:00
|
|
|
|
|
|
|
c = 'm';
|
2015-01-28 14:49:42 -08:00
|
|
|
CheckedWriteFile(WritePipeHandle(), &c, 1);
|
2014-08-26 17:10:19 -04:00
|
|
|
|
|
|
|
// The child will close its end of the pipe and exit. Make sure that the
|
|
|
|
// parent sees EOF.
|
2015-01-28 14:49:42 -08:00
|
|
|
CheckedReadFileAtEOF(read_handle);
|
2014-08-26 17:10:19 -04:00
|
|
|
}
|
|
|
|
|
2014-10-14 11:11:57 -04:00
|
|
|
void MultiprocessChild() override {
|
2015-01-28 14:49:42 -08:00
|
|
|
FileHandle write_handle = WritePipeHandle();
|
2014-08-26 17:10:19 -04:00
|
|
|
|
|
|
|
char c = 'M';
|
2015-01-28 14:49:42 -08:00
|
|
|
CheckedWriteFile(write_handle, &c, 1);
|
2014-08-26 17:10:19 -04:00
|
|
|
|
|
|
|
pid_t pid = getpid();
|
2015-01-28 14:49:42 -08:00
|
|
|
CheckedWriteFile(write_handle, &pid, sizeof(pid));
|
2014-08-26 17:10:19 -04:00
|
|
|
|
Make file_io reads more rational and predictable
ReadFile() attempted to continue reading after a short read. In most
cases, this is fine. However, ReadFile() would keep trying to fill a
partially-filled buffer until experiencing a 0-length read(), signaling
end-of-file. For certain weird file descriptors like terminal input, EOF
is an ephemeral condition, and attempting to read beyond EOF doesn’t
actually return 0 (EOF) provided that they remain open, it will block
waiting for more input. Consequently, ReadFile() and anything based on
ReadFile() had an undocumented and quirky interface, which was that any
short read that it returned (not an underlying short read) actually
indicated EOF.
This facet of ReadFile() was unexpected, so it’s being removed. The new
behavior is that ReadFile() will return an underlying short read. The
behavior of FileReaderInterface::Read() is updated in accordance with
this change.
Upon experiencing a short read, the caller can determine the best
action. Most callers were already prepared for this behavior. Outside of
util/file, only crashpad_database_util properly implemented EOF
detection according to previous semantics, and adapting it to new
semantics is trivial.
Callers who require an exact-length read can use the new
ReadFileExactly(), or the newly renamed LoggingReadFileExactly() or
CheckedReadFileExactly(). These functions will retry following a short
read. The renamed functions were previously called LoggingReadFile() and
CheckedReadFile(), but those names implied that they were simply
wrapping ReadFile(), which is not the case. They wrapped ReadFile() and
further, insisted on a full read. Since ReadFile()’s semantics are now
changing but these functions’ are not, they’re now even more distinct
from ReadFile(), and must be renamed to avoid confusion.
Test: *
Change-Id: I06b77e0d6ad8719bd2eb67dab93a8740542dd908
Reviewed-on: https://chromium-review.googlesource.com/456676
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-03-16 13:36:38 -04:00
|
|
|
CheckedReadFileExactly(ReadPipeHandle(), &c, 1);
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_EQ(c, 'm');
|
2014-08-26 17:10:19 -04:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
TEST(Multiprocess, Multiprocess) {
|
|
|
|
TestMultiprocess multiprocess;
|
|
|
|
multiprocess.Run();
|
|
|
|
}
|
|
|
|
|
2014-09-09 17:04:47 -04:00
|
|
|
class TestMultiprocessUnclean final : public Multiprocess {
|
|
|
|
public:
|
|
|
|
enum TerminationType {
|
|
|
|
kExitSuccess = 0,
|
|
|
|
kExitFailure,
|
|
|
|
kExit2,
|
|
|
|
kAbort,
|
|
|
|
};
|
|
|
|
|
|
|
|
explicit TestMultiprocessUnclean(TerminationType type)
|
|
|
|
: Multiprocess(),
|
|
|
|
type_(type) {
|
|
|
|
if (type_ == kAbort) {
|
|
|
|
SetExpectedChildTermination(kTerminationSignal, SIGABRT);
|
|
|
|
} else {
|
|
|
|
SetExpectedChildTermination(kTerminationNormal, ExitCode());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-09-20 12:55:12 -07:00
|
|
|
TestMultiprocessUnclean(const TestMultiprocessUnclean&) = delete;
|
|
|
|
TestMultiprocessUnclean& operator=(const TestMultiprocessUnclean&) = delete;
|
|
|
|
|
2014-09-09 17:04:47 -04:00
|
|
|
~TestMultiprocessUnclean() {}
|
|
|
|
|
|
|
|
private:
|
|
|
|
int ExitCode() const {
|
|
|
|
return type_;
|
|
|
|
}
|
|
|
|
|
2014-09-22 13:06:12 -04:00
|
|
|
// Multiprocess:
|
|
|
|
|
2014-10-14 11:11:57 -04:00
|
|
|
void MultiprocessParent() override {
|
2014-09-09 17:04:47 -04:00
|
|
|
}
|
|
|
|
|
2014-10-14 11:11:57 -04:00
|
|
|
void MultiprocessChild() override {
|
2014-09-09 17:04:47 -04:00
|
|
|
if (type_ == kAbort) {
|
|
|
|
abort();
|
|
|
|
} else {
|
|
|
|
_exit(ExitCode());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
TerminationType type_;
|
|
|
|
};
|
|
|
|
|
2014-09-22 13:06:12 -04:00
|
|
|
TEST(Multiprocess, SuccessfulExit) {
|
2014-09-09 17:04:47 -04:00
|
|
|
TestMultiprocessUnclean multiprocess(TestMultiprocessUnclean::kExitSuccess);
|
|
|
|
multiprocess.Run();
|
|
|
|
}
|
|
|
|
|
2014-09-22 13:06:12 -04:00
|
|
|
TEST(Multiprocess, UnsuccessfulExit) {
|
2014-09-09 17:04:47 -04:00
|
|
|
TestMultiprocessUnclean multiprocess(TestMultiprocessUnclean::kExitFailure);
|
|
|
|
multiprocess.Run();
|
|
|
|
}
|
|
|
|
|
2014-09-22 13:06:12 -04:00
|
|
|
TEST(Multiprocess, Exit2) {
|
2014-09-09 17:04:47 -04:00
|
|
|
TestMultiprocessUnclean multiprocess(TestMultiprocessUnclean::kExit2);
|
|
|
|
multiprocess.Run();
|
|
|
|
}
|
|
|
|
|
2014-09-22 13:06:12 -04:00
|
|
|
TEST(Multiprocess, AbortSignal) {
|
2014-09-09 17:04:47 -04:00
|
|
|
TestMultiprocessUnclean multiprocess(TestMultiprocessUnclean::kAbort);
|
|
|
|
multiprocess.Run();
|
|
|
|
}
|
|
|
|
|
2014-09-22 13:06:12 -04:00
|
|
|
class TestMultiprocessClosePipe final : public Multiprocess {
|
|
|
|
public:
|
|
|
|
enum WhoCloses {
|
|
|
|
kParentCloses = 0,
|
|
|
|
kChildCloses,
|
|
|
|
};
|
|
|
|
enum WhatCloses {
|
|
|
|
kReadCloses = 0,
|
|
|
|
kWriteCloses,
|
|
|
|
kReadAndWriteClose,
|
|
|
|
};
|
|
|
|
|
|
|
|
TestMultiprocessClosePipe(WhoCloses who_closes, WhatCloses what_closes)
|
|
|
|
: Multiprocess(),
|
|
|
|
who_closes_(who_closes),
|
|
|
|
what_closes_(what_closes) {
|
2021-04-09 15:16:22 -04:00
|
|
|
// Fails under "threadsafe" mode on macOS 10.11.
|
2023-12-02 14:38:59 -08:00
|
|
|
GTEST_FLAG_SET(death_test_style, "fast");
|
2014-09-22 13:06:12 -04:00
|
|
|
}
|
|
|
|
|
2021-09-20 12:55:12 -07:00
|
|
|
TestMultiprocessClosePipe(const TestMultiprocessClosePipe&) = delete;
|
|
|
|
TestMultiprocessClosePipe& operator=(const TestMultiprocessClosePipe&) =
|
|
|
|
delete;
|
|
|
|
|
2014-09-22 13:06:12 -04:00
|
|
|
~TestMultiprocessClosePipe() {}
|
|
|
|
|
|
|
|
private:
|
|
|
|
void VerifyInitial() {
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
ASSERT_NE(ReadPipeHandle(), -1);
|
|
|
|
ASSERT_NE(WritePipeHandle(), -1);
|
2014-09-22 13:06:12 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
// Verifies that the partner process did what it was supposed to do. This must
|
|
|
|
// only be called when who_closes_ names the partner process, not this
|
|
|
|
// process.
|
|
|
|
//
|
|
|
|
// If the partner was supposed to close its write pipe, the read pipe will be
|
|
|
|
// checked to ensure that it shows end-of-file.
|
|
|
|
//
|
|
|
|
// If the partner was supposed to close its read pipe, the write pipe will be
|
|
|
|
// checked to ensure that a checked write causes death. This can only be done
|
|
|
|
// if the partner also provides some type of signal when it has closed its
|
|
|
|
// read pipe, which is done in the form of it closing its write pipe, causing
|
|
|
|
// the read pipe in this process to show end-of-file.
|
|
|
|
void VerifyPartner() {
|
|
|
|
if (what_closes_ == kWriteCloses) {
|
2015-01-28 14:49:42 -08:00
|
|
|
CheckedReadFileAtEOF(ReadPipeHandle());
|
2014-09-22 13:06:12 -04:00
|
|
|
} else if (what_closes_ == kReadAndWriteClose) {
|
2015-01-28 14:49:42 -08:00
|
|
|
CheckedReadFileAtEOF(ReadPipeHandle());
|
2014-09-22 13:06:12 -04:00
|
|
|
char c = '\0';
|
|
|
|
|
|
|
|
// This will raise SIGPIPE. If fatal (the normal case), that will cause
|
|
|
|
// process termination. If SIGPIPE is being handled somewhere, the write
|
2014-12-17 14:35:18 -08:00
|
|
|
// will still fail and set errno to EPIPE, and CheckedWriteFile() will
|
|
|
|
// abort execution. Regardless of how SIGPIPE is handled, the process will
|
|
|
|
// be terminated. Because the actual termination mechanism is not known,
|
|
|
|
// no regex can be specified.
|
2015-03-09 18:02:14 -04:00
|
|
|
EXPECT_DEATH_CHECK(CheckedWriteFile(WritePipeHandle(), &c, 1), "");
|
2014-09-22 13:06:12 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void Close() {
|
|
|
|
switch (what_closes_) {
|
|
|
|
case kReadCloses:
|
|
|
|
CloseReadPipe();
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_NE(WritePipeHandle(), -1);
|
2015-03-09 18:02:14 -04:00
|
|
|
EXPECT_DEATH_CHECK(ReadPipeHandle(), "fd");
|
2014-09-22 13:06:12 -04:00
|
|
|
break;
|
|
|
|
case kWriteCloses:
|
|
|
|
CloseWritePipe();
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_NE(ReadPipeHandle(), -1);
|
2015-03-09 18:02:14 -04:00
|
|
|
EXPECT_DEATH_CHECK(WritePipeHandle(), "fd");
|
2014-09-22 13:06:12 -04:00
|
|
|
break;
|
|
|
|
case kReadAndWriteClose:
|
|
|
|
CloseReadPipe();
|
|
|
|
CloseWritePipe();
|
2015-03-09 18:02:14 -04:00
|
|
|
EXPECT_DEATH_CHECK(ReadPipeHandle(), "fd");
|
|
|
|
EXPECT_DEATH_CHECK(WritePipeHandle(), "fd");
|
2014-09-22 13:06:12 -04:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Multiprocess:
|
|
|
|
|
2014-10-14 11:11:57 -04:00
|
|
|
void MultiprocessParent() override {
|
2014-10-09 15:08:54 -04:00
|
|
|
ASSERT_NO_FATAL_FAILURE(VerifyInitial());
|
2014-09-22 13:06:12 -04:00
|
|
|
|
|
|
|
if (who_closes_ == kParentCloses) {
|
|
|
|
Close();
|
|
|
|
} else {
|
|
|
|
VerifyPartner();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-10-14 11:11:57 -04:00
|
|
|
void MultiprocessChild() override {
|
2014-10-09 15:08:54 -04:00
|
|
|
ASSERT_NO_FATAL_FAILURE(VerifyInitial());
|
2014-09-22 13:06:12 -04:00
|
|
|
|
|
|
|
if (who_closes_ == kChildCloses) {
|
|
|
|
Close();
|
|
|
|
} else {
|
|
|
|
VerifyPartner();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
WhoCloses who_closes_;
|
|
|
|
WhatCloses what_closes_;
|
|
|
|
};
|
|
|
|
|
|
|
|
TEST(MultiprocessDeathTest, ParentClosesReadPipe) {
|
|
|
|
TestMultiprocessClosePipe multiprocess(
|
|
|
|
TestMultiprocessClosePipe::kParentCloses,
|
|
|
|
TestMultiprocessClosePipe::kReadCloses);
|
|
|
|
multiprocess.Run();
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(MultiprocessDeathTest, ParentClosesWritePipe) {
|
|
|
|
TestMultiprocessClosePipe multiprocess(
|
|
|
|
TestMultiprocessClosePipe::kParentCloses,
|
|
|
|
TestMultiprocessClosePipe::kWriteCloses);
|
|
|
|
multiprocess.Run();
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(MultiprocessDeathTest, ParentClosesReadAndWritePipe) {
|
|
|
|
TestMultiprocessClosePipe multiprocess(
|
|
|
|
TestMultiprocessClosePipe::kParentCloses,
|
|
|
|
TestMultiprocessClosePipe::kReadAndWriteClose);
|
|
|
|
multiprocess.Run();
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(MultiprocessDeathTest, ChildClosesReadPipe) {
|
|
|
|
TestMultiprocessClosePipe multiprocess(
|
|
|
|
TestMultiprocessClosePipe::kChildCloses,
|
|
|
|
TestMultiprocessClosePipe::kReadCloses);
|
|
|
|
multiprocess.Run();
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(MultiprocessDeathTest, ChildClosesWritePipe) {
|
|
|
|
TestMultiprocessClosePipe multiprocess(
|
|
|
|
TestMultiprocessClosePipe::kChildCloses,
|
|
|
|
TestMultiprocessClosePipe::kWriteCloses);
|
|
|
|
multiprocess.Run();
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(MultiprocessDeathTest, ChildClosesReadAndWritePipe) {
|
|
|
|
TestMultiprocessClosePipe multiprocess(
|
|
|
|
TestMultiprocessClosePipe::kChildCloses,
|
|
|
|
TestMultiprocessClosePipe::kReadAndWriteClose);
|
|
|
|
multiprocess.Run();
|
|
|
|
}
|
|
|
|
|
2014-08-26 17:10:19 -04:00
|
|
|
} // namespace
|
2014-10-07 17:28:50 -04:00
|
|
|
} // namespace test
|
|
|
|
} // namespace crashpad
|