2015-05-01 13:48:23 -07:00
|
|
|
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
#include "snapshot/win/process_reader_win.h"
|
|
|
|
|
|
|
|
#include <windows.h>
|
2016-01-06 12:22:50 -05:00
|
|
|
#include <string.h>
|
2015-05-01 13:48:23 -07:00
|
|
|
|
|
|
|
#include "gtest/gtest.h"
|
2015-06-01 10:07:51 -07:00
|
|
|
#include "test/win/win_multiprocess.h"
|
2017-04-28 10:08:35 -04:00
|
|
|
#include "util/misc/from_pointer_cast.h"
|
2015-09-16 12:42:20 -07:00
|
|
|
#include "util/synchronization/semaphore.h"
|
|
|
|
#include "util/thread/thread.h"
|
2015-09-09 12:29:29 -07:00
|
|
|
#include "util/win/scoped_process_suspend.h"
|
2015-05-01 13:48:23 -07:00
|
|
|
|
|
|
|
namespace crashpad {
|
|
|
|
namespace test {
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
TEST(ProcessReaderWin, SelfBasic) {
|
|
|
|
ProcessReaderWin process_reader;
|
2015-09-09 12:29:29 -07:00
|
|
|
ASSERT_TRUE(process_reader.Initialize(GetCurrentProcess(),
|
|
|
|
ProcessSuspensionState::kRunning));
|
2015-05-01 13:48:23 -07:00
|
|
|
|
|
|
|
#if !defined(ARCH_CPU_64_BITS)
|
|
|
|
EXPECT_FALSE(process_reader.Is64Bit());
|
|
|
|
#else
|
|
|
|
EXPECT_TRUE(process_reader.Is64Bit());
|
|
|
|
#endif
|
|
|
|
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_EQ(process_reader.GetProcessInfo().ProcessID(), GetCurrentProcessId());
|
2015-05-01 13:48:23 -07:00
|
|
|
|
2017-07-25 13:34:04 -04:00
|
|
|
static constexpr char kTestMemory[] = "Some test memory";
|
2015-05-01 13:48:23 -07:00
|
|
|
char buffer[arraysize(kTestMemory)];
|
2017-04-28 10:08:35 -04:00
|
|
|
ASSERT_TRUE(process_reader.ReadMemory(
|
|
|
|
reinterpret_cast<uintptr_t>(kTestMemory), sizeof(kTestMemory), &buffer));
|
2015-05-01 13:48:23 -07:00
|
|
|
EXPECT_STREQ(kTestMemory, buffer);
|
|
|
|
}
|
|
|
|
|
2017-07-25 13:34:04 -04:00
|
|
|
constexpr char kTestMemory[] = "Read me from another process";
|
2015-06-01 10:07:51 -07:00
|
|
|
|
|
|
|
class ProcessReaderChild final : public WinMultiprocess {
|
|
|
|
public:
|
|
|
|
ProcessReaderChild() : WinMultiprocess() {}
|
|
|
|
~ProcessReaderChild() {}
|
|
|
|
|
|
|
|
private:
|
|
|
|
void WinMultiprocessParent() override {
|
|
|
|
ProcessReaderWin process_reader;
|
2015-09-09 12:29:29 -07:00
|
|
|
ASSERT_TRUE(process_reader.Initialize(ChildProcess(),
|
|
|
|
ProcessSuspensionState::kRunning));
|
2015-06-01 10:07:51 -07:00
|
|
|
|
|
|
|
#if !defined(ARCH_CPU_64_BITS)
|
|
|
|
EXPECT_FALSE(process_reader.Is64Bit());
|
|
|
|
#else
|
|
|
|
EXPECT_TRUE(process_reader.Is64Bit());
|
|
|
|
#endif
|
|
|
|
|
|
|
|
WinVMAddress address;
|
Make file_io reads more rational and predictable
ReadFile() attempted to continue reading after a short read. In most
cases, this is fine. However, ReadFile() would keep trying to fill a
partially-filled buffer until experiencing a 0-length read(), signaling
end-of-file. For certain weird file descriptors like terminal input, EOF
is an ephemeral condition, and attempting to read beyond EOF doesn’t
actually return 0 (EOF) provided that they remain open, it will block
waiting for more input. Consequently, ReadFile() and anything based on
ReadFile() had an undocumented and quirky interface, which was that any
short read that it returned (not an underlying short read) actually
indicated EOF.
This facet of ReadFile() was unexpected, so it’s being removed. The new
behavior is that ReadFile() will return an underlying short read. The
behavior of FileReaderInterface::Read() is updated in accordance with
this change.
Upon experiencing a short read, the caller can determine the best
action. Most callers were already prepared for this behavior. Outside of
util/file, only crashpad_database_util properly implemented EOF
detection according to previous semantics, and adapting it to new
semantics is trivial.
Callers who require an exact-length read can use the new
ReadFileExactly(), or the newly renamed LoggingReadFileExactly() or
CheckedReadFileExactly(). These functions will retry following a short
read. The renamed functions were previously called LoggingReadFile() and
CheckedReadFile(), but those names implied that they were simply
wrapping ReadFile(), which is not the case. They wrapped ReadFile() and
further, insisted on a full read. Since ReadFile()’s semantics are now
changing but these functions’ are not, they’re now even more distinct
from ReadFile(), and must be renamed to avoid confusion.
Test: *
Change-Id: I06b77e0d6ad8719bd2eb67dab93a8740542dd908
Reviewed-on: https://chromium-review.googlesource.com/456676
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-03-16 13:36:38 -04:00
|
|
|
CheckedReadFileExactly(ReadPipeHandle(), &address, sizeof(address));
|
2015-06-01 10:07:51 -07:00
|
|
|
|
|
|
|
char buffer[sizeof(kTestMemory)];
|
|
|
|
ASSERT_TRUE(
|
|
|
|
process_reader.ReadMemory(address, sizeof(kTestMemory), &buffer));
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_EQ(strcmp(kTestMemory, buffer), 0);
|
2015-06-01 10:07:51 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
void WinMultiprocessChild() override {
|
2017-04-28 10:08:35 -04:00
|
|
|
WinVMAddress address = FromPointerCast<WinVMAddress>(kTestMemory);
|
2015-06-01 10:07:51 -07:00
|
|
|
CheckedWriteFile(WritePipeHandle(), &address, sizeof(address));
|
|
|
|
|
|
|
|
// Wait for the parent to signal that it's OK to exit by closing its end of
|
|
|
|
// the pipe.
|
|
|
|
CheckedReadFileAtEOF(ReadPipeHandle());
|
|
|
|
}
|
|
|
|
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(ProcessReaderChild);
|
|
|
|
};
|
|
|
|
|
|
|
|
TEST(ProcessReaderWin, ChildBasic) {
|
2015-07-31 12:31:58 -04:00
|
|
|
WinMultiprocess::Run<ProcessReaderChild>();
|
2015-06-01 10:07:51 -07:00
|
|
|
}
|
|
|
|
|
2015-05-14 17:37:02 -07:00
|
|
|
TEST(ProcessReaderWin, SelfOneThread) {
|
|
|
|
ProcessReaderWin process_reader;
|
2015-09-09 12:29:29 -07:00
|
|
|
ASSERT_TRUE(process_reader.Initialize(GetCurrentProcess(),
|
|
|
|
ProcessSuspensionState::kRunning));
|
2015-05-14 17:37:02 -07:00
|
|
|
|
|
|
|
const std::vector<ProcessReaderWin::Thread>& threads =
|
|
|
|
process_reader.Threads();
|
|
|
|
|
|
|
|
// If other tests ran in this process previously, threads may have been
|
|
|
|
// created and may still be running. This check must look for at least one
|
|
|
|
// thread, not exactly one thread.
|
|
|
|
ASSERT_GE(threads.size(), 1u);
|
|
|
|
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_EQ(threads[0].id, GetCurrentThreadId());
|
2015-05-14 17:37:02 -07:00
|
|
|
#if defined(ARCH_CPU_64_BITS)
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_NE(threads[0].context.native.Rip, 0);
|
2015-05-14 17:37:02 -07:00
|
|
|
#else
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_NE(threads[0].context.native.Eip, 0u);
|
2015-05-14 17:37:02 -07:00
|
|
|
#endif
|
|
|
|
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_EQ(threads[0].suspend_count, 0);
|
2015-05-14 17:37:02 -07:00
|
|
|
}
|
|
|
|
|
2015-09-09 12:29:29 -07:00
|
|
|
class ProcessReaderChildThreadSuspendCount final : public WinMultiprocess {
|
|
|
|
public:
|
|
|
|
ProcessReaderChildThreadSuspendCount() : WinMultiprocess() {}
|
|
|
|
~ProcessReaderChildThreadSuspendCount() {}
|
|
|
|
|
|
|
|
private:
|
2015-09-16 12:42:20 -07:00
|
|
|
enum : unsigned int { kCreatedThreads = 3 };
|
|
|
|
|
|
|
|
class SleepingThread : public Thread {
|
|
|
|
public:
|
|
|
|
SleepingThread() : done_(nullptr) {}
|
|
|
|
|
|
|
|
void SetHandle(Semaphore* done) {
|
|
|
|
done_= done;
|
|
|
|
}
|
|
|
|
|
|
|
|
void ThreadMain() override {
|
|
|
|
done_->Wait();
|
|
|
|
};
|
|
|
|
|
|
|
|
private:
|
|
|
|
Semaphore* done_;
|
|
|
|
};
|
|
|
|
|
2015-09-09 12:29:29 -07:00
|
|
|
void WinMultiprocessParent() override {
|
2015-09-16 12:42:20 -07:00
|
|
|
char c;
|
Make file_io reads more rational and predictable
ReadFile() attempted to continue reading after a short read. In most
cases, this is fine. However, ReadFile() would keep trying to fill a
partially-filled buffer until experiencing a 0-length read(), signaling
end-of-file. For certain weird file descriptors like terminal input, EOF
is an ephemeral condition, and attempting to read beyond EOF doesn’t
actually return 0 (EOF) provided that they remain open, it will block
waiting for more input. Consequently, ReadFile() and anything based on
ReadFile() had an undocumented and quirky interface, which was that any
short read that it returned (not an underlying short read) actually
indicated EOF.
This facet of ReadFile() was unexpected, so it’s being removed. The new
behavior is that ReadFile() will return an underlying short read. The
behavior of FileReaderInterface::Read() is updated in accordance with
this change.
Upon experiencing a short read, the caller can determine the best
action. Most callers were already prepared for this behavior. Outside of
util/file, only crashpad_database_util properly implemented EOF
detection according to previous semantics, and adapting it to new
semantics is trivial.
Callers who require an exact-length read can use the new
ReadFileExactly(), or the newly renamed LoggingReadFileExactly() or
CheckedReadFileExactly(). These functions will retry following a short
read. The renamed functions were previously called LoggingReadFile() and
CheckedReadFile(), but those names implied that they were simply
wrapping ReadFile(), which is not the case. They wrapped ReadFile() and
further, insisted on a full read. Since ReadFile()’s semantics are now
changing but these functions’ are not, they’re now even more distinct
from ReadFile(), and must be renamed to avoid confusion.
Test: *
Change-Id: I06b77e0d6ad8719bd2eb67dab93a8740542dd908
Reviewed-on: https://chromium-review.googlesource.com/456676
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-03-16 13:36:38 -04:00
|
|
|
CheckedReadFileExactly(ReadPipeHandle(), &c, sizeof(c));
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
ASSERT_EQ(c, ' ');
|
2015-09-16 12:42:20 -07:00
|
|
|
|
2015-09-09 12:29:29 -07:00
|
|
|
{
|
|
|
|
ProcessReaderWin process_reader;
|
|
|
|
ASSERT_TRUE(process_reader.Initialize(ChildProcess(),
|
|
|
|
ProcessSuspensionState::kRunning));
|
|
|
|
|
|
|
|
const auto& threads = process_reader.Threads();
|
2015-09-16 12:42:20 -07:00
|
|
|
ASSERT_GE(threads.size(), kCreatedThreads + 1);
|
2015-09-09 12:29:29 -07:00
|
|
|
for (const auto& thread : threads)
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_EQ(thread.suspend_count, 0u);
|
2015-09-09 12:29:29 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
ScopedProcessSuspend suspend(ChildProcess());
|
|
|
|
|
|
|
|
ProcessReaderWin process_reader;
|
|
|
|
ASSERT_TRUE(process_reader.Initialize(
|
|
|
|
ChildProcess(), ProcessSuspensionState::kSuspended));
|
|
|
|
|
|
|
|
// Confirm that thread counts are adjusted correctly for the process being
|
|
|
|
// suspended.
|
|
|
|
const auto& threads = process_reader.Threads();
|
2015-09-16 12:42:20 -07:00
|
|
|
ASSERT_GE(threads.size(), kCreatedThreads + 1);
|
2015-09-09 12:29:29 -07:00
|
|
|
for (const auto& thread : threads)
|
test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE}
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
https://github.com/google/googletest/commit/77d6b173380332b1c1bc540532641f410ec82d65
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-04-04 00:35:21 -04:00
|
|
|
EXPECT_EQ(thread.suspend_count, 0u);
|
2015-09-09 12:29:29 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void WinMultiprocessChild() override {
|
2015-09-16 12:42:20 -07:00
|
|
|
// Create three dummy threads so we can confirm we read successfully read
|
|
|
|
// more than just the main thread.
|
|
|
|
SleepingThread threads[kCreatedThreads];
|
|
|
|
Semaphore done(0);
|
|
|
|
for (auto& thread : threads)
|
|
|
|
thread.SetHandle(&done);
|
|
|
|
for (auto& thread : threads)
|
|
|
|
thread.Start();
|
|
|
|
|
|
|
|
char c = ' ';
|
|
|
|
CheckedWriteFile(WritePipeHandle(), &c, sizeof(c));
|
2015-09-09 12:29:29 -07:00
|
|
|
|
|
|
|
// Wait for the parent to signal that it's OK to exit by closing its end of
|
|
|
|
// the pipe.
|
|
|
|
CheckedReadFileAtEOF(ReadPipeHandle());
|
2015-09-16 12:42:20 -07:00
|
|
|
|
|
|
|
for (int i = 0; i < arraysize(threads); ++i)
|
|
|
|
done.Signal();
|
|
|
|
for (auto& thread : threads)
|
|
|
|
thread.Join();
|
2015-09-09 12:29:29 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(ProcessReaderChildThreadSuspendCount);
|
|
|
|
};
|
|
|
|
|
|
|
|
TEST(ProcessReaderWin, ChildThreadSuspendCounts) {
|
|
|
|
WinMultiprocess::Run<ProcessReaderChildThreadSuspendCount>();
|
|
|
|
}
|
|
|
|
|
2015-05-01 13:48:23 -07:00
|
|
|
} // namespace
|
|
|
|
} // namespace test
|
|
|
|
} // namespace crashpad
|